Skip to contentSkip to conversation

sdio: add low level i/o functions for workarounds

PATCH Uri Shkolnik 2 participants 2 messages Mar 25, 2009 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw
Quoted 24 lines · Pierre Ossman

From: Pierre Ossman <[email protected]>
Subject: Re: [PATCH 1/1 re-submit 1] sdio: add low level i/o functions for workarounds
To: "Uri Shkolnik" <[email protected]>
Cc: "Mauro Carvalho Chehab" <[email protected]>, "Linux Media Mailing List" <[email protected]>
Date: Tuesday, March 24, 2009, 10:04 PM

Quoted 3 lines · On Sun, 22 Mar 2009 16:48:39 +0200 "Uri Shkolnik" <[email protected]> wrote:

Hi Pierre,

The USB separation patches are ready, and will be

committed for review

Quoted 1 line

shortly (SDIO stack workaround + Siano SDIO driver

were the first to be

Quoted 1 line

re-re-re-committed, SPI will be next, and after them

the "core" which

Quoted 1 line

includes the 'separation' code). You can view one (of

many) older commit

Quoted 4 lines

operations @
http://patchwork.kernel.org/project/linux-media/list/?submitter=Uri&stat
e=*

Quoted 19 lines

I see. Could you hold off on the SDIO patches and allow me to do a
final cleanup once you have the separation patches done? Then I can
send them directly to Mauro and we can have this merged quickly.

Rgds

Signature · 9 lines
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by
the
  Swedish government. Make sure your server uses
encryption
  for SMTP traffic and consider using PGP for
end-to-end
  encryption.

Hi Pierre,

The SDIO patches are part of (at least) dozen patches needed to upgrade the Siano's offering for Linux kernel.

The order is -
1) SDIO SMS interface driver and SDIO stack patch (add)
2) SPI interface driver (add)
3) USB interface driver (modify)
4) IR port (add)
5) USB v3 (modify)
6-15(?) ) "Core" and "Cards" modifications

The order of the patches places the SDIO among the first to be submitted for review (interface drivers must be patched before the "core", in order to make the various commits pass bisect tests).

I suggest that we'll continue the submission, and I'll cc you on ALL submissions. You will be able to review, and either ask for modification and/or suggest your on supplementary patches at any stage.

Regards,
________________________________

Uri Shkolnik

#1 lore raw
Quoted 5 lines · On Wed, 25 Mar 2009 01:43:48 -0700 (PDT) Uri Shkolnik <[email protected]> wrote:

Hi Pierre,

The SDIO patches are part of (at least) dozen patches needed to upgrade the Siano's offering for Linux kernel.

Quoted 8 lines

The order is -
1) SDIO SMS interface driver and SDIO stack patch (add)
2) SPI interface driver (add)
3) USB interface driver (modify)
4) IR port (add)
5) USB v3 (modify)
6-15(?) ) "Core" and "Cards" modifications

I'm not sure where the separation comes in here. So far the driver has had a common entrypoint that calls all the different interface specific startup routines.

Quoted 3 lines

The order of the patches places the SDIO among the first to be submitted for review (interface drivers must be patched before the "core", in order to make the various commits pass bisect tests).

I take it you're referring to your internal repo? Mainline only contains the USB interface so splitting that up into a core and interface driver shouldn't cause any bisect problems.

Quoted 2 lines

I suggest that we'll continue the submission, and I'll cc you on ALL submissions. You will be able to review, and either ask for modification and/or suggest your on supplementary patches at any stage.

I'd prefer to not build a huge monolith just to later take it apart, but I can live with it.

Rgds

Signature · 6 lines
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.