Large block device patch, part 1 of 9
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 3 lines · Peter Chubb
Unfortunately, this doesn't really buy you much ---- standard C type promotion rules mean that whatever (within reason) you pass to
llsect()will work without warning.
Not if someone changes a variable to a pointer by accident without updating the printk. It does happen.
-ben
Signature · 1 line
"You will be reincarnated as a toad; and you will be much happier."
Quoted 7 lines · Benjamin LaHaise
Quoted 3 lines · Peter Chubb
Unfortunately, this doesn't really buy you much ---- standard C type promotion rules mean that whatever (within reason) you pass to
llsect()will work without warning.Not if someone changes a variable to a pointer by accident without updating the printk. It does happen.
The thing is, I don't see why we should be building castles and cathedrals around printk. Just cast to the wider value, if you get it wrong you have lost exactly what? Are people feeding the output of dmesg into scripts that their systems depend upon? If so, we need to let evolution do its work.
If this had something to do with how the kernel worked, it might be worth inventing a new feature.
Signature · 1 line
Daniel
Quoted 5 lines · Daniel Phillips
The thing is, I don't see why we should be building castles and cathedrals around printk. Just cast to the wider value, if you get it wrong you have lost exactly what? Are people feeding the output of dmesg into scripts that their systems depend upon? If so, we need to let evolution do its work.
Why do it the broken way when you can do it a non-broken way? Arguing in favour of having it broken by design isn't something I really understand. Anyways, I'll refrain from posting any further comments on this thread.
-ben
Signature · 1 line
"You will be reincarnated as a toad; and you will be much happier."
Quoted 9 lines · Benjamin LaHaise
Quoted 5 lines · Daniel Phillips
The thing is, I don't see why we should be building castles and cathedrals around printk. Just cast to the wider value, if you get it wrong you have lost exactly what? Are people feeding the output of dmesg into scripts that their systems depend upon? If so, we need to let evolution do its work.
Why do it the broken way when you can do it a non-broken way? Arguing in favour of having it broken by design isn't something I really understand.
Because you're only fixing the printk, and with an inadequate solution at that. Could we please fix something that matters?
Signature · 1 line
Daniel