Skip to contentSkip to conversation

next-20151101 - depmod issues with Lustre modules

DISCUSSION Valdis Kletnieks 5 participants 5 messages Nov 2, 2015 – Nov 12, 2015

lore
Share & tools
lore
#0 lore raw

next-20151101 compiles fine, but depmod has a cow:

depmod: ERROR: Found 2 modules in dependency cycles!
depmod: ERROR: Cycle detected: lnet -> libcfs -> lnet

Sorry, not sure which commit(s) introduced the issue. next-20151022 was OK.

#1 lore raw

Reproduced on mainline v4.3-9038-g27eb427bdc0960 with Arch Linux default config (attached):

depmod: ERROR: Found 2 modules in dependency cycles!
depmod: ERROR: Cycle detected: lnet -> libcfs -> lnet
make: *** [_modinst_post] Error 1

2015-11-02 18:39 GMT+03:00 Valdis Kletnieks <[email protected]>:

Quoted 9 lines

next-20151101 compiles fine, but depmod has a cow:

depmod: ERROR: Found 2 modules in dependency cycles!
depmod: ERROR: Cycle detected: lnet -> libcfs -> lnet

Sorry, not sure which commit(s) introduced the issue. next-20151022 was OK.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: config
Type: application/octet-stream
Size: 175569 bytes
Desc: not available
URL: <http://lists.lustre.org/pipermail/lustre-devel-lustre.org/attachments/20151107/6738d1cc/attachment-0001.obj>

#2 lore raw
Quoted 6 lines · Dmitry Safonov

Reproduced on mainline v4.3-9038-g27eb427bdc0960 with Arch Linux default config (attached):

depmod: ERROR: Found 2 modules in dependency cycles!
depmod: ERROR: Cycle detected: lnet -> libcfs -> lnet
make: *** [_modinst_post] Error 1

The reason seems to be that

- lnet.ko provides the following functions needed by libcfs.ko:

libcfs_next_nidstring
libcfs_nid2str_r

- libcfs.ko provides the following functions needed by lnet.ko:

libcfs_debug
libcfs_debug_msg
libcfs_deregister_ioctl
libcfs_register_ioctl
libcfs_subsystem_debug
lustre_insert_debugfs

but I may have messed up something.

Anyway, the problem seems to be that - insanely - lnet.ko provides those libcfs nid handling functions. They should be in libcfs, as far as I can tell, just judging by the name. Also judging by the use.

The cause seems to be commit 47ca6ec2673e ("staging: lustre: move nidstring handling to LNet layer") by James Simmons.

I do wonder if linux-next could perhaps do some modprobe testing too?

Linus

#3 lore raw

Hi Linus,

Quoted 2 lines · On Sat, 7 Nov 2015 14:30:44 -0800 Linus Torvalds…

I do wonder if linux-next could perhaps do some modprobe testing too?

I have added an x86_64 allmodconfig modules_install to my end-of-day-before-release builds. Is that useful/sufficient? It seems to work fine at the moment.

Signature · 2 lines
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
#4 lore raw
In reply to Dmitry Safonov
Quoted 7 lines

Reproduced on mainline v4.3-9038-g27eb427bdc0960 with Arch Linux default config (attached):

depmod: ERROR: Found 2 modules in dependency cycles!
depmod: ERROR: Cycle detected: lnet -> libcfs -> lnet
make: *** [_modinst_post] Error 1

I submitted a patch (staging: lustre: remove IOC_LIBCFS_PING_TEST ioctl) to fix this. It should be merged soon.