Skip to contentSkip to conversation

crash failure with 2.6.36-rc3 vmcore

PATCH CAI Qian 3 participants 3 messages Sep 4, 2010 1 message not in the archive Driver core

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 856089343.1931201283439399228.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com

CAI Qian

author
#1 lore raw
Quoted 11 lines

crash> mod -S

mod: invalid structure member offset: attribute_owner
FILE: symbols.c LINE: 8577 FUNCTION: add_symbol_file_kallsyms()

MODULE NAME SIZE OBJECT FILE
ffffffffa000de60 dm_mod 76230
/lib/modules/2.6.36-rc2-mm1-wqfix-mkdfix+/kernel/drivers/md/dm-mod.ko [/usr/bin/crash] error trace: 4affb0 => 4f3236 => 4f12b5 => 4e587a

Quoted 7 lines

4e587a: OFFSET_verify.clone.4+186
4f12b5: add_symbol_file+933
4f3236: load_module_symbols+566
4affb0: do_module_cmd+1264

mod: invalid structure member offset: attribute_owner
FILE: symbols.c LINE: 8577 FUNCTION: add_symbol_file_kallsyms()

This failure was due to this commit,

commit 6fd69dc578fa0b1bbc3aad70ae3af9a137211707

Author: Guenter Roeck <[email protected]>
Date:   Wed Jul 28 22:09:26 2010 -0700

sysfs: Remove owner field from sysfs struct attribute

include/linux/sysfs.h +0 -6
index 8bf06b6..3c92121 100644
@@ -22,14 +22,8 @@ struct kobject;
 struct module;
 enum kobj_ns_type;
 
-/* FIXME
- * The *owner field is no longer used.
- * x86 tree has been cleaned up. The owner
- * attribute is still left for other arches.
- */
 struct attribute {
        const char              *name;
-       struct module           *owner;
        mode_t                  mode;
 #ifdef CONFIG_DEBUG_LOCK_ALLOC
        struct lock_class_key   *key;
#2 lore raw
Quoted 16 lines · CAI Qian
Quoted 16 lines

crash> mod -S

mod: invalid structure member offset: attribute_owner
FILE: symbols.c LINE: 8577 FUNCTION: add_symbol_file_kallsyms()

MODULE NAME SIZE OBJECT FILE
ffffffffa000de60 dm_mod 76230
/lib/modules/2.6.36-rc2-mm1-wqfix-mkdfix+/kernel/drivers/md/dm-mod.ko [/usr/bin/crash] error trace: 4affb0 => 4f3236 => 4f12b5 => 4e587a

4e587a: OFFSET_verify.clone.4+186
4f12b5: add_symbol_file+933
4f3236: load_module_symbols+566
4affb0: do_module_cmd+1264

Quoted 5 lines
Quoted 2 lines

mod: invalid structure member offset: attribute_owner
FILE: symbols.c LINE: 8577 FUNCTION: add_symbol_file_kallsyms()

This failure was due to this commit,

commit 6fd69dc578fa0b1bbc3aad70ae3af9a137211707

<snip>

I don't understand, is this patch causing a problem, or did you forget to rebuild your code?

confused,

greg k-h

#3 lore raw
In reply to CAI Qian

Hi,

Quoted 11 lines · CAI Qian
Quoted 11 lines

crash> mod -S

mod: invalid structure member offset: attribute_owner
FILE: symbols.c LINE: 8577 FUNCTION: add_symbol_file_kallsyms()

MODULE NAME SIZE OBJECT FILE
ffffffffa000de60 dm_mod 76230
/lib/modules/2.6.36-rc2-mm1-wqfix-mkdfix+/kernel/drivers/md/dm-mod.ko [/usr/bin/crash] error trace: 4affb0 => 4f3236 => 4f12b5 => 4e587a

Quoted 7 lines
Quoted 7 lines

4e587a: OFFSET_verify.clone.4+186
4f12b5: add_symbol_file+933
4f3236: load_module_symbols+566
4affb0: do_module_cmd+1264

mod: invalid structure member offset: attribute_owner
FILE: symbols.c LINE: 8577 FUNCTION: add_symbol_file_kallsyms()

What do I have to do to reproduce this crash ?

Was the module in question compiled w/ the kernel, or separately ? Did it use the correct kernel header files for compilation ? Was the kernel version -rc3, or some other patched version ?

Just wondering, since the above message says 2.6.36-rc2-mm1-wqfix-mkdfix+, which seems to indicate that it included some modifications.

Thanks,
Guenter

Quoted 31 lines

This failure was due to this commit,

commit 6fd69dc578fa0b1bbc3aad70ae3af9a137211707

Author: Guenter Roeck <[email protected]>
Date:   Wed Jul 28 22:09:26 2010 -0700

sysfs: Remove owner field from sysfs struct attribute

include/linux/sysfs.h +0 -6
index 8bf06b6..3c92121 100644
@@ -22,14 +22,8 @@ struct kobject;
 struct module;
 enum kobj_ns_type;
 
-/* FIXME
- * The *owner field is no longer used.
- * x86 tree has been cleaned up. The owner
- * attribute is still left for other arches.
- */
 struct attribute {
        const char              *name;
-       struct module           *owner;
        mode_t                  mode;
 #ifdef CONFIG_DEBUG_LOCK_ALLOC
        struct lock_class_key   *key;