Skip to contentSkip to conversation

s3c2410fb: cleanup and fix

PATCH New Arnaud Patard (Rtp) 1 participant 1 message Dec 15, 2005

Subsystems (2)
Framebuffer layer Arm Samsung Exynos
lore
Share & tools
lore

Arnaud Patard (Rtp)

author
#0 lore raw

PATCH 1/1 s3c2410fb: cleanup and fix

Hi,

Here are some cleanups for the s3c2410fb drivers. It :
* Removes a buggy call to s3c2410fb_init_registers. There was two calls to this function but the first was done without all initialisations done. No oops but it may confuse some LCDs.
* Makes two functions static.

Signed-off-by Arnaud Patard <[email protected]>
---
 s3c2410fb.c |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/video/s3c2410fb.c +4 -6
Index: linux-2.6/drivers/video/s3c2410fb.c
===================================================================
@@ -679,7 +679,7 @@
  * s3c2410fb_init_registers - Initialise all LCD-related registers
  */
 
-int s3c2410fb_init_registers(struct s3c2410fb_info *fbi)
+static int s3c2410fb_init_registers(struct s3c2410fb_info *fbi)
 {
 	unsigned long flags;
 

@@ -761,7 +761,7 @@
 
 static char driver_name[]="s3c2410fb";
 
-int __init s3c2410fb_probe(struct platform_device *pdev)
+static int __init s3c2410fb_probe(struct platform_device *pdev)
 {
 	struct s3c2410fb_info *info;
 	struct fb_info	   *fbinfo;

@@ -795,8 +795,6 @@
 	info->fb = fbinfo;
 	dev_set_drvdata(dev, fbinfo);
 
-	s3c2410fb_init_registers(info);
-
 	dprintk("devinit\n");
 
 	strcpy(fbinfo->fix.id, driver_name);

@@ -829,8 +827,8 @@
 	fbinfo->var.yres_virtual    = mach_info->yres.defval;
 	fbinfo->var.bits_per_pixel  = mach_info->bpp.defval;
 
-	fbinfo->var.upper_margin    = S3C2410_LCDCON2_GET_VBPD(mregs->lcdcon2) +1;
-	fbinfo->var.lower_margin    = S3C2410_LCDCON2_GET_VFPD(mregs->lcdcon2) +1;
+	fbinfo->var.upper_margin    = S3C2410_LCDCON2_GET_VBPD(mregs->lcdcon2) + 1;
+	fbinfo->var.lower_margin    = S3C2410_LCDCON2_GET_VFPD(mregs->lcdcon2) + 1;
 	fbinfo->var.vsync_len	    = S3C2410_LCDCON2_GET_VSPW(mregs->lcdcon2) + 1;
 
 	fbinfo->var.left_margin	    = S3C2410_LCDCON3_GET_HFPD(mregs->lcdcon3) + 1;