Skip to contentSkip to conversation

ufs compile error in 2.5.19

DISCUSSION [email protected] 3 participants 3 messages May 29, 2002 – May 30, 2002

lore
Share & tools
lore

[email protected]

author
#0 lore raw

truncate.c: In function `ufs_truncate':
truncate.c:456: `tq_disk' undeclared (first use in this function) truncate.c:456: (Each undeclared identifier is reported only once truncate.c:456: for each function it appears in.) make[2]: *** [truncate.o] Error 1
make[2]: Leaving directory `/usr/src/linux-2.5.19/fs/ufs'

#1 lore raw
Quoted 7 lines · [email protected] wrote:

truncate.c: In function `ufs_truncate':
truncate.c:456: `tq_disk' undeclared (first use in this function) truncate.c:456: (Each undeclared identifier is reported only once truncate.c:456: for each function it appears in.) make[2]: *** [truncate.o] Error 1
make[2]: Leaving directory `/usr/src/linux-2.5.19/fs/ufs'

I guess this is right...

fs/ufs/truncate.c +1 -1
@@ -453,7 +453,7 @@
 			break;
 		if (IS_SYNC(inode) && (inode->i_state & I_DIRTY))
 			ufs_sync_inode (inode);
-		run_task_queue(&tq_disk);
+		blk_run_queues();
 		yield();
 	}
 	offset = inode->i_size & uspi->s_fshift;
Signature · 1 line
Skip
#2 lore raw
In reply to [email protected]
Quoted 14 lines · Skip Ford
Quoted 7 lines · [email protected] wrote:

truncate.c: In function `ufs_truncate':
truncate.c:456: `tq_disk' undeclared (first use in this function) truncate.c:456: (Each undeclared identifier is reported only once truncate.c:456: for each function it appears in.) make[2]: *** [truncate.o] Error 1
make[2]: Leaving directory `/usr/src/linux-2.5.19/fs/ufs'

I guess this is right...

fs/ufs/truncate.c line 459

Quoted 8 lines
fs/ufs/truncate.c +1 -1
@@ -453,7 +453,7 @@
 			break;
 		if (IS_SYNC(inode) && (inode->i_state & I_DIRTY))
 			ufs_sync_inode (inode);
-		run_task_queue(&tq_disk);
+		blk_run_queues();
 		yield();
 	}
 	offset = inode->i_size & uspi->s_fshift;

Yeah it's right, and I see I missed exactly this change in the patch I just sent to Linus a few hours ago... So I've sent this one on as well, thanks.

Signature · 1 line
Jens Axboe