Skip to contentSkip to conversation

: 1/2 cleanup of c-andes.c

PATCH New Juan Quintela 1 participant 1 message Mar 13, 2003 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : 1/2 cleanup of c-andes.c

Hi ralf

Make only once the detection of the secondary cache line size. Once there, make andes_flush_icache_page have the right types and remove the wrong export.

Later, Juan.

 build/arch/mips64/mm/c-andes.c     |   53 ++++++++++++++++++++++++-------------
 build/include/asm-mips64/pgtable.h |    7 ----
 2 files changed, 36 insertions(+), 24 deletions(-)
build/include/asm-mips64/pgtable.h renamed from build/include/asm-mips64/pgtable.h~mips64-sc-line-size +1 -6
diff -puN build/include/asm-mips64/pgtable.h~mips64-sc-line-size build/include/asm-mips64/pgtable.h
@@ -61,7 +61,6 @@ extern void (*_flush_cache_l1)(void);
  * are io coherent. The only place where we might be overoptimizing
  * out icache flushes are from mprotect (when PROT_EXEC is added).
  */
-extern void andes_flush_icache_page(unsigned long);
 #define flush_cache_mm(mm)		do { } while(0)
 #define flush_cache_range(mm,start,end)	do { } while(0)
 #define flush_cache_page(vma,page)	do { } while(0)
@@ -69,11 +68,7 @@ extern void andes_flush_icache_page(unsi
 #define flush_icache_range(start, end)	_flush_cache_l1()
 #define flush_icache_user_range(vma, page, addr, len) \
 	flush_icache_page((vma), (page))
-#define flush_icache_page(vma, page)					\
-do {									\
-	if ((vma)->vm_flags & VM_EXEC)					\
-		andes_flush_icache_page(phys_to_virt(page_to_phys(page))); \
-} while (0)
+#define flush_icache_page(vma, page)	_flush_icache_page(vma, page)
 
 #else
 
build/arch/mips64/mm/c-andes.c renamed from build/arch/mips64/mm/c-andes.c~mips64-sc-line-size +35 -18

89 lines not on this page · raw message

_

Signature · 2 lines
In theory, practice and theory are the same, but in practice they 
are different -- Larry McVoy