ALSA: snd-usb-line6 depends on CONFIG_SND_HWDEP
PATCH 1/1 ALSA: snd-usb-line6 depends on CONFIG_SND_HWDEP
ALSA - snd-usb-line6 depends on CONFIG_SND_HWDEP
ERROR: "snd_hwdep_new" [sound/usb/line6/snd-usb-line6.ko] undefined! scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1
sound/usb/line6/Kconfig +1 -0
@@ -2,6 +2,7 @@ config SND_USB_LINE6 tristate select SND_RAWMIDI select SND_PCM + select SND_HWDEP config SND_USB_POD tristate "Line 6 POD USB support"
Quoted 7 lines · Valdis Kletnieks
ALSA - snd-usb-line6 depends on
CONFIG_SND_HWDEPERROR: "
snd_hwdep_new" [sound/usb/line6/snd-usb-line6.ko] undefined!scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1Signed-off-by Valdis Kletnieks <[email protected]>
As a nitpicking, I think it better to change the subject line with a prefix of 'ALSA: line6:' or 'ALSA: usb-line6:', following to our fashion.
sound/usb/line6/Kconfig config SND_USB_LINE6 · line 8
Quoted 12 lines
sound/usb/line6/Kconfig +1
-0@@ -2,6 +2,7 @@ config SND_USB_LINE6 tristate select SND_RAWMIDI select SND_PCM + select SND_HWDEP config SND_USB_POD tristate "Line 6 POD USB support"
Thanks
Takashi Sakamoto
Quoted 8 lines · Takashi Sakamoto
Quoted 6 lines · Valdis Kletnieks
ALSA - snd-usb-line6 depends on
CONFIG_SND_HWDEPERROR: "
snd_hwdep_new" [sound/usb/line6/snd-usb-line6.ko] undefined!scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1
Quoted 7 lines
Quoted 1 line
Signed-off-by Valdis Kletnieks <[email protected]>Reviewed-by Takashi Sakamoto <[email protected]>As a nitpicking, I think it better to change the subject line with a prefix of 'ALSA: line6:' or 'ALSA: usb-line6:', following to our fashion.
Yes, I modified the subject line and added fixes tag.
thanks,
Takashi
Quoted 18 lines
sound/usb/line6/Kconfig config SND_USB_LINE6 · line 8
Quoted 12 lines
sound/usb/line6/Kconfig +1
-0@@ -2,6 +2,7 @@ config SND_USB_LINE6 tristate select SND_RAWMIDI select SND_PCM + select SND_HWDEP config SND_USB_POD tristate "Line 6 POD USB support"Thanks
Takashi Sakamoto
Quoted 12 lines · Takashi Iwai
Quoted 10 lines · Takashi Sakamoto
Quoted 7 lines · Valdis Kletnieks
ALSA - snd-usb-line6 depends on
CONFIG_SND_HWDEPERROR: "
snd_hwdep_new" [sound/usb/line6/snd-usb-line6.ko] undefined!scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1Signed-off-by Valdis Kletnieks <[email protected]>
Quoted 7 lines
Quoted 5 lines
Reviewed-by Takashi Sakamoto <[email protected]>As a nitpicking, I think it better to change the subject line with a prefix of 'ALSA: line6:' or 'ALSA: usb-line6:', following to our fashion.
Yes, I modified the subject line and added fixes tag.
Thanks.
As another issue, I can see sparse (v0.5.0) errors:
sound/usb/line6/driver.c:274:43: error: cannot size expression sound/usb/line6/driver.c:275:16: error: cannot size expression sound/usb/line6/driver.c:276:16: error: cannot size expression sound/usb/line6/driver.c:277:16: error: cannot size expression
And this fix can suppresses them:
$ git diff sound/usb/line6
sound/usb/line6/driver.c +1 -1
@@ -30,7 +30,7 @@/* This is Line 6's MIDI manufacturer ID. */ -const unsigned char line6_midi_id[] = { +const unsigned char line6_midi_id[3 ] = {0x00 ,0x01 ,0x0c };EXPORT_SYMBOL_GPL (line6_midi_id);
Besides, there's a difference of the declaration between header and code:
$ cat sound/usb/line6/driver.h ... extern const unsigned char line6_midi_id[3];
This is quite minor. So I can't judge to fix it or not... What do you think about it?
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
sound/usb/line6/Kconfig +1
-0@@ -2,6 +2,7 @@ config SND_USB_LINE6 tristate select SND_RAWMIDI select SND_PCM + select SND_HWDEP
Quoted 2 lines
Quoted 2 lines
sound/usb/line6/Kconfig config SND_USB_LINE6 · line 8
Quoted 2 lines
sound/usb/line6/Kconfig +0
-0config SND_USB_POD tristate "Line 6 POD USB support"
Regards
Takashi Sakamoto
Quoted 48 lines · Takashi Sakamoto
Quoted 12 lines · Takashi Iwai
Quoted 10 lines · Takashi Sakamoto
Quoted 7 lines · Valdis Kletnieks
ALSA - snd-usb-line6 depends on
CONFIG_SND_HWDEPERROR: "
snd_hwdep_new" [sound/usb/line6/snd-usb-line6.ko] undefined!scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1Signed-off-by Valdis Kletnieks <[email protected]>Quoted 7 lines
Quoted 5 lines
Reviewed-by Takashi Sakamoto <[email protected]>As a nitpicking, I think it better to change the subject line with a prefix of 'ALSA: line6:' or 'ALSA: usb-line6:', following to our fashion.
Yes, I modified the subject line and added fixes tag.
Thanks.
As another issue, I can see sparse (v0.5.0) errors:
sound/usb/line6/driver.c:274:43: error: cannot size expressionsound/usb/line6/driver.c:275:16: error: cannot size expressionsound/usb/line6/driver.c:276:16: error: cannot size expressionsound/usb/line6/driver.c:277:16: error: cannot size expressionAnd this fix can suppresses them:
$ git diff sound/usb/line6sound/usb/line6/driver.c +1
-1@@ -30,7 +30,7 @@/* This is Line 6's MIDI manufacturer ID. */ -const unsigned char line6_midi_id[] = { +const unsigned char line6_midi_id[3 ] = {0x00 ,0x01 ,0x0c };EXPORT_SYMBOL_GPL (line6_midi_id);
Quoted 7 lines
Besides, there's a difference of the declaration between header and code:
$ cat sound/usb/line6/driver.h ... extern const unsigned char line6_midi_id[3];This is quite minor. So I can't judge to fix it or not... What do you think about it?
The only problem I can see is the inconsistency between the declaration and the definition. So yes, we should align to [3], if we keep the declaration as is. (And actually it's sometimes safer to have the explicit array size.)
thanks,
Takashi
Quoted 55 lines · Takashi Iwai
Quoted 53 lines · Takashi Sakamoto
Quoted 12 lines · Takashi Iwai
Quoted 10 lines · Takashi Sakamoto
Quoted 7 lines · Valdis Kletnieks
ALSA - snd-usb-line6 depends on
CONFIG_SND_HWDEPERROR: "
snd_hwdep_new" [sound/usb/line6/snd-usb-line6.ko] undefined!scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1Signed-off-by Valdis Kletnieks <[email protected]>Quoted 7 lines
Quoted 5 lines
Reviewed-by Takashi Sakamoto <[email protected]>As a nitpicking, I think it better to change the subject line with a prefix of 'ALSA: line6:' or 'ALSA: usb-line6:', following to our fashion.
Yes, I modified the subject line and added fixes tag.
Thanks.
As another issue, I can see sparse (v0.5.0) errors:
sound/usb/line6/driver.c:274:43: error: cannot size expressionsound/usb/line6/driver.c:275:16: error: cannot size expressionsound/usb/line6/driver.c:276:16: error: cannot size expressionsound/usb/line6/driver.c:277:16: error: cannot size expressionAnd this fix can suppresses them:
$ git diff sound/usb/line6sound/usb/line6/driver.c +1
-1@@ -30,7 +30,7 @@/* This is Line 6's MIDI manufacturer ID. */ -const unsigned char line6_midi_id[] = { +const unsigned char line6_midi_id[3 ] = {0x00 ,0x01 ,0x0c };EXPORT_SYMBOL_GPL (line6_midi_id);Besides, there's a difference of the declaration between header and code:
$ cat sound/usb/line6/driver.h ... extern const unsigned char line6_midi_id[3];
Quoted 5 lines
Quoted 2 lines
This is quite minor. So I can't judge to fix it or not... What do you think about it?
The only problem I can see is the inconsistency between the declaration and the definition.
I have the same opinion. Sparse is not versatile.
Quoted 2 lines
So yes, we should align to [3], if we keep the declaration as is. (And actually it's sometimes safer to have the explicit array size.)
OK. I'll post the fix later.
Thanks
Takashi Sakamoto