(no subject)
Subject: Re: [PATCH 04/12] drm: Nuke mode->vrefresh
Message-ID: <[email protected]>
References: <[email protected]>
<CGME20200219203620eucas1p24b4990a91e758dbcf3e9b943669b0c8f@eucas1p2.samsung.com> <[email protected]> <[email protected]> <[email protected]> <[email protected]> <[email protected]> <[email protected]> <CACRpkdZk9QEy+Kzkmy4BXiHB+aq9hprf=dmA_-R23yqH3NCt1g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CACRpkdZk9QEy+Kzkmy4BXiHB+aq9hprf=dmA_-R23yqH3NCt1g@mail.gmail.com>
X-Patchwork-Hint: comment
User-Agent: Mutt/1.10.1 (2018-07-13)
Quoted 11 lines · Linus Walleij
Quoted 1 line · Ville Syrj�l�
OK, so I went ahead a wrote a bit of cocci [1] to find the bad apples.
That's impressive :D
Quoted 1 line
Unfortunately it found a lot of strange stuff:
I will answer for the weirdness I caused.
Quoted 7 lines
I have long suspected that a whole bunch of the "simple" displays are not simple but contains a display controller and memory. That means that the speed over the link to the display and actual refresh rate on the actual display is asymmetric because well we are just updating a RAM, the resolution just limits how much data we are sending, the clock limits the speed on the bus over to the RAM on the other side.
IMO even in command mode mode->clock should probably be the actual dotclock used by the display. If there's another clock for the bus speed/etc. it should be stored somewhere else.
Signature · 2 lines
Ville Syrj�l� Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re:
Quoted 10 lines · Ville Syrjälä
Quoted 7 lines · Linus Walleij
I have long suspected that a whole bunch of the "simple" displays are not simple but contains a display controller and memory. That means that the speed over the link to the display and actual refresh rate on the actual display is asymmetric because well we are just updating a RAM, the resolution just limits how much data we are sending, the clock limits the speed on the bus over to the RAM on the other side.
Quoted 3 lines
IMO even in command mode
mode->clockshould probably be the actual dotclock used by the display. If there's another clock for the bus speed/etc. it should be stored somewhere else.
Good point. For the DSI panels we have the field hs_rate for the HS clock in struct mipi_dsi_device which is based on exactly this reasoning. And that is what I actually use for setting the HS clock.
The problem is however that we in many cases have so substandard documentation of these panels that we have absolutely no idea about the dotclock. Maybe we should just set it to 0 in these cases?
Yours,
Linus Walleij
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re:
Quoted 21 lines · Linus Walleij
Quoted 10 lines · Ville Syrjälä
Quoted 7 lines · Linus Walleij
I have long suspected that a whole bunch of the "simple" displays are not simple but contains a display controller and memory. That means that the speed over the link to the display and actual refresh rate on the actual display is asymmetric because well we are just updating a RAM, the resolution just limits how much data we are sending, the clock limits the speed on the bus over to the RAM on the other side.
Quoted 3 lines
IMO even in command mode
mode->clockshould probably be the actual dotclock used by the display. If there's another clock for the bus speed/etc. it should be stored somewhere else.Good point. For the DSI panels we have the field
hs_ratefor the HS clock in structmipi_dsi_devicewhich is based on exactly this reasoning. And that is what I actually use for setting the HS clock.
Quoted 4 lines
The problem is however that we in many cases have so substandard documentation of these panels that we have absolutely no idea about the dotclock. Maybe we should just set it to 0 in these cases?
Don't you always have a TE interrupt or something like that available? Could just measure it from that if no better information is available?
Signature · 2 lines
Ville Syrjälä Intel
Re:
Quoted 22 lines · Ville Syrjälä
Quoted 21 lines · Linus Walleij
Quoted 10 lines · Ville Syrjälä
Quoted 7 lines · Linus Walleij
I have long suspected that a whole bunch of the "simple" displays are not simple but contains a display controller and memory. That means that the speed over the link to the display and actual refresh rate on the actual display is asymmetric because well we are just updating a RAM, the resolution just limits how much data we are sending, the clock limits the speed on the bus over to the RAM on the other side.
Quoted 3 lines
IMO even in command mode
mode->clockshould probably be the actual dotclock used by the display. If there's another clock for the bus speed/etc. it should be stored somewhere else.Good point. For the DSI panels we have the field
hs_ratefor the HS clock in structmipi_dsi_devicewhich is based on exactly this reasoning. And that is what I actually use for setting the HS clock.
Quoted 8 lines
Quoted 4 lines
The problem is however that we in many cases have so substandard documentation of these panels that we have absolutely no idea about the dotclock. Maybe we should just set it to 0 in these cases?
Don't you always have a TE interrupt or something like that available? Could just measure it from that if no better information is available?
Yes and I did exactly that, so that is why this comment is in the driver:
static const struct drm_display_mode sony_acx424akp_cmd_mode = { (...)
/*
* Some desired refresh rate, experiments at the maximum "pixel"
* clock speed (HS clock 420 MHz) yields around 117Hz.
*/
.vrefresh = 60,I got a review comment at the time saying 117 Hz was weird. We didn't reach a proper conclusion on this:
https://lore.kernel.org/dri-devel/CACRpkdYW3YNPSNMY3A44GQn8DqK-n9TLvr7uipF7LM_DHZ5=Lg@mail.gmail.com/
Thierry wasn't sure if 60Hz was good or not, so I just had to go with something.
We could calculate the resulting pixel clock for ~117 Hz with this resolution and put that in the clock field but ... don't know what is the best?
Yours,
Linus Walleij
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re:
Quoted 48 lines · Linus Walleij
Quoted 22 lines · Ville Syrjälä
Quoted 21 lines · Linus Walleij
Quoted 10 lines · Ville Syrjälä
Quoted 7 lines · Linus Walleij
I have long suspected that a whole bunch of the "simple" displays are not simple but contains a display controller and memory. That means that the speed over the link to the display and actual refresh rate on the actual display is asymmetric because well we are just updating a RAM, the resolution just limits how much data we are sending, the clock limits the speed on the bus over to the RAM on the other side.
Quoted 3 lines
IMO even in command mode
mode->clockshould probably be the actual dotclock used by the display. If there's another clock for the bus speed/etc. it should be stored somewhere else.Good point. For the DSI panels we have the field
hs_ratefor the HS clock in structmipi_dsi_devicewhich is based on exactly this reasoning. And that is what I actually use for setting the HS clock.Quoted 8 lines
Quoted 4 lines
The problem is however that we in many cases have so substandard documentation of these panels that we have absolutely no idea about the dotclock. Maybe we should just set it to 0 in these cases?
Don't you always have a TE interrupt or something like that available? Could just measure it from that if no better information is available?
Yes and I did exactly that, so that is why this comment is in the driver:
static const struct
drm_display_modesony_acx424akp_cmd_mode= { (...)/* * Some desired refresh rate, experiments at the maximum "pixel" * clock speed (HS clock 420 MHz) yields around 117Hz. */ .vrefresh = 60,I got a review comment at the time saying 117 Hz was weird. We didn't reach a proper conclusion on this:
https://lore.kernel.org/dri-devel/CACRpkdYW3YNPSNMY3A44GQn8DqK-n9TLvr7uipF7LM_DHZ5=Lg@mail.gmail.com/
Quoted 6 lines
Thierry wasn't sure if 60Hz was good or not, so I just had to go with something.
We could calculate the resulting pixel clock for ~117 Hz with this resolution and put that in the clock field but ... don't know what is the best?
I would vote for that approach.
Signature · 2 lines
Ville Syrjälä Intel