Skip to contentSkip to conversation

mmc: sdhci-s3c: Remove use of card_tasklet, which no longer exists

PATCH In review Chris Ball 2 participants 3 messages Jun 4, 2014 – Jun 5, 2014

Subsystems (3)
MMC, SD and SDIO Secure digital host controller interface (SDHCI) driver Secure digital host controller interface (SDHCI) Samsung driver
lore
Share & tools
lore

Chris Ball

author
#0 lore raw

PATCH 1/1 mmc: sdhci-s3c: Remove use of card_tasklet, which no longer exists

"mmc: sdhci: push card_tasklet into threaded irq handler" removed the card_tasklet, but it is still in use by sdhci-s3c.c.

Signed-off-by Chris Ball <[email protected]>

---
Hi,

sdhci-s3c is currently failing to build due to the removal of card_tasklet. I think this trivial patch might do the right thing -- please could someone test that card detection still works and ACK if so? Thanks!

 drivers/mmc/host/sdhci-s3c.c | 1 -
 1 file changed, 1 deletion(-)
drivers/mmc/host/sdhci-s3c.c +0 -1
index 781b8a9..53a32e2 100644
@@ -399,7 +399,6 @@ static void sdhci_s3c_notify_change(struct platform_device *dev, int state)
 			clk_disable_unprepare(sc->clk_io);
 #endif
 		}
-		tasklet_schedule(&host->card_tasklet);
 		spin_unlock_irqrestore(&host->lock, flags);
 	}
 }
Signature · 1 line
Chris Ball   <http://printf.net/>
maintainer
#1 lore raw

Hi, Chris.

Didn't you want to merge the below patch?

https://patchwork.kernel.org/patch/4239541/

I have tested with exynos series, and working fine.

Best Regards,
Jaehoon Chung

Quoted 28 lines · Chris Ball

"mmc: sdhci: push card_tasklet into threaded irq handler" removed the card_tasklet, but it is still in use by sdhci-s3c.c.

Signed-off-by Chris Ball <[email protected]>

---
Hi,

sdhci-s3c is currently failing to build due to the removal of card_tasklet. I think this trivial patch might do the right thing -- please could someone test that card detection still works and ACK if so? Thanks!

 drivers/mmc/host/sdhci-s3c.c | 1 -
 1 file changed, 1 deletion(-)
drivers/mmc/host/sdhci-s3c.c +0 -1
index 781b8a9..53a32e2 100644
@@ -399,7 +399,6 @@ static void sdhci_s3c_notify_change(struct platform_device *dev, int state)
 			clk_disable_unprepare(sc->clk_io);
 #endif
 		}
-		tasklet_schedule(&host->card_tasklet);
 		spin_unlock_irqrestore(&host->lock, flags);
 	}
 }
author
#2 lore raw

Hi,

Quoted 5 lines · Jaehoon Chung

Didn't you want to merge the below patch?

https://patchwork.kernel.org/patch/4239541/

I have tested with exynos series, and working fine.

Oops, of course -- thanks! Pushed to mmc-next for 3.16.

- Chris.

Signature · 1 line
Chris Ball   <http://printf.net/>