Skip to contentSkip to conversation

GFS2: Eliminate gfs2_rg_lops

PATCH New Bob Peterson 2 participants 2 messages May 21, 2013 – May 22, 2013 1 message not in the archive GFS2 file system

lore
Share & tools
lore
#1 lore raw

PATCH 1/1 GFS2: Eliminate gfs2_rg_lops

In reply to a message not in the archive

Hi,

With recent changes to the transactions, it appears that we are no longer using the "log ops" for resource groups. Since the log commit code processes the array of log ops, eliminating this should be marginally better for performance. Therefore this patch eliminates it.

Regards,

Bob Peterson
Red Hat File Systems

---
 fs/gfs2/lops.c | 5 -----
 fs/gfs2/lops.h | 1 -
 2 files changed, 6 deletions(-)
fs/gfs2/lops.c +0 -5
index e069041..0457768 100644
@@ -850,10 +850,6 @@ const struct gfs2_log_operations gfs2_revoke_lops = {
 	.lo_name = "revoke",
 };
 
-const struct gfs2_log_operations gfs2_rg_lops = {
-	.lo_name = "rg",
-};
-
 const struct gfs2_log_operations gfs2_databuf_lops = {
 	.lo_before_commit = databuf_lo_before_commit,
 	.lo_after_commit = databuf_lo_after_commit,
@@ -865,7 +861,6 @@ const struct gfs2_log_operations gfs2_databuf_lops = {
 const struct gfs2_log_operations *gfs2_log_ops[] = {
 	&gfs2_databuf_lops,
 	&gfs2_buf_lops,
-	&gfs2_rg_lops,
 	&gfs2_revoke_lops,
 	NULL,
 };
fs/gfs2/lops.h +0 -1
index 87e062e..9ca2e64 100644
@@ -23,7 +23,6 @@
 extern const struct gfs2_log_operations gfs2_glock_lops;
 extern const struct gfs2_log_operations gfs2_buf_lops;
 extern const struct gfs2_log_operations gfs2_revoke_lops;
-extern const struct gfs2_log_operations gfs2_rg_lops;
 extern const struct gfs2_log_operations gfs2_databuf_lops;
 
 extern const struct gfs2_log_operations *gfs2_log_ops[];
#2 lore raw

PATCH 1/1 GFS2: Eliminate gfs2_rg_lops

Hi,

Added to the -nmw tree. Thanks,

Steve.

Quoted 55 lines · Bob Peterson

Hi,

With recent changes to the transactions, it appears that we are no longer using the "log ops" for resource groups. Since the log commit code processes the array of log ops, eliminating this should be marginally better for performance. Therefore this patch eliminates it.

Regards,

Bob Peterson
Red Hat File Systems

---
 fs/gfs2/lops.c | 5 -----
 fs/gfs2/lops.h | 1 -
 2 files changed, 6 deletions(-)
fs/gfs2/lops.c +0 -5
index e069041..0457768 100644
@@ -850,10 +850,6 @@ const struct gfs2_log_operations gfs2_revoke_lops = {
 	.lo_name = "revoke",
 };
 
-const struct gfs2_log_operations gfs2_rg_lops = {
-	.lo_name = "rg",
-};
-
 const struct gfs2_log_operations gfs2_databuf_lops = {
 	.lo_before_commit = databuf_lo_before_commit,
 	.lo_after_commit = databuf_lo_after_commit,
@@ -865,7 +861,6 @@ const struct gfs2_log_operations gfs2_databuf_lops = {
 const struct gfs2_log_operations *gfs2_log_ops[] = {
 	&gfs2_databuf_lops,
 	&gfs2_buf_lops,
-	&gfs2_rg_lops,
 	&gfs2_revoke_lops,
 	NULL,
 };
fs/gfs2/lops.h +0 -1
index 87e062e..9ca2e64 100644
@@ -23,7 +23,6 @@
 extern const struct gfs2_log_operations gfs2_glock_lops;
 extern const struct gfs2_log_operations gfs2_buf_lops;
 extern const struct gfs2_log_operations gfs2_revoke_lops;
-extern const struct gfs2_log_operations gfs2_rg_lops;
 extern const struct gfs2_log_operations gfs2_databuf_lops;
 
 extern const struct gfs2_log_operations *gfs2_log_ops[];