Interrupt chip driver maintainence
Folks!
I'm wading through my inbox full of patches for interrupt chip drivers and I'm thoroughly annoyed. The way how this works today is not sustainable.
Patches end up in my and Radu's inbox and all we can do is go through them mostly on a formal basis, but it's out of our scope to look at the correctness vs. a particular hardware. In the past I just picked up patches when I had the gut feeling they are remotely correct, but I'm tired of this.
I've just marked about 20 patches and patch series obsolete due to zero feedback from the relevant architecture/SoC people who were on Cc.
And I'm going to do that from now on very consequently. If the architecture, SoC experts can't be bothered to look after their stuff, then don't expect me to suck all of this crap up and then deal with the complaints when it breaks.
I'm still going to pick up obvious and simple bug fixes, but for anything which requires deep knowledge on the underlying hardware, I'm going to just mark them obsolete when they molded in my inbox unreviewed by the people who understand it for six weeks.
Thanks,
Thomas
Quoted 21 lines · Thomas Gleixner
Folks!
I'm wading through my inbox full of patches for interrupt chip drivers and I'm thoroughly annoyed. The way how this works today is not sustainable.
Patches end up in my and Radu's inbox and all we can do is go through them mostly on a formal basis, but it's out of our scope to look at the correctness vs. a particular hardware. In the past I just picked up patches when I had the gut feeling they are remotely correct, but I'm tired of this.
I've just marked about 20 patches and patch series obsolete due to zero feedback from the relevant architecture/SoC people who were on Cc.
And I'm going to do that from now on very consequently. If the architecture, SoC experts can't be bothered to look after their stuff, then don't expect me to suck all of this crap up and then deal with the complaints when it breaks.
Quoted 4 lines
I'm still going to pick up obvious and simple bug fixes, but for anything which requires deep knowledge on the underlying hardware, I'm going to just mark them obsolete when they molded in my inbox unreviewed by the people who understand it for six weeks.
Works for me. I didn't expect anything else.
Thanks,
M.
Signature · 1 line
Jazz isn't dead. It just smells funny.
Quoted 18 lines · Thomas Gleixner
I'm wading through my inbox full of patches for interrupt chip drivers and I'm thoroughly annoyed. The way how this works today is not sustainable.
Patches end up in my and Radu's inbox and all we can do is go through them mostly on a formal basis, but it's out of our scope to look at the correctness vs. a particular hardware. In the past I just picked up patches when I had the gut feeling they are remotely correct, but I'm tired of this.
I've just marked about 20 patches and patch series obsolete due to zero feedback from the relevant architecture/SoC people who were on Cc.
And I'm going to do that from now on very consequently. If the architecture, SoC experts can't be bothered to look after their stuff, then don't expect me to suck all of this crap up and then deal with the complaints when it breaks.
Quoted 4 lines
I'm still going to pick up obvious and simple bug fixes, but for anything which requires deep knowledge on the underlying hardware, I'm going to just mark them obsolete when they molded in my inbox unreviewed by the people who understand it for six weeks.
I think that's fair!
For what it's worth, as a simple reviewer, I also consciously ignored multiple patches that required knowledge of the hardware, simply because I didn't have that knowledge.
Signature · 2 lines
Best regards, Radu
Quoted 9 lines · Thomas Gleixner
I'm wading through my inbox full of patches for interrupt chip drivers and I'm thoroughly annoyed. The way how this works today is not sustainable.
Patches end up in my and Radu's inbox and all we can do is go through them mostly on a formal basis, but it's out of our scope to look at the correctness vs. a particular hardware. In the past I just picked up patches when I had the gut feeling they are remotely correct, but I'm tired of this.
I have hardware to test the SiFive PLIC. I also spent quite some time staring at the specification attempting to cleanse the mess we have for plic_irq_eoi() (which sadly yielded nothing).
I can help looking at patches. Would that help moving things forward?
Nam
Nam!
Quoted 11 lines · Nam Cao
Quoted 9 lines · Thomas Gleixner
I'm wading through my inbox full of patches for interrupt chip drivers and I'm thoroughly annoyed. The way how this works today is not sustainable.
Patches end up in my and Radu's inbox and all we can do is go through them mostly on a formal basis, but it's out of our scope to look at the correctness vs. a particular hardware. In the past I just picked up patches when I had the gut feeling they are remotely correct, but I'm tired of this.
Quoted 5 lines
I have hardware to test the SiFive PLIC. I also spent quite some time staring at the specification attempting to cleanse the mess we have for
plic_irq_eoi()(which sadly yielded nothing).I can help looking at patches. Would that help moving things forward?
Help is always welcome.
But the point is that the companies who build and sell that stuff have the responsibility to take care of it and not just dump their crap into the kernel and then expect that someone else will take care of it for free.
If SiFive pays you or your employer to provide that service that's fine, but you doing it on your on [dt]ime to proliferate the carelessness of those who profit from it is just wrong.
Thanks,
tglx
Quoted 21 lines · Thomas Gleixner
Folks!
I'm wading through my inbox full of patches for interrupt chip drivers and I'm thoroughly annoyed. The way how this works today is not sustainable.
Patches end up in my and Radu's inbox and all we can do is go through them mostly on a formal basis, but it's out of our scope to look at the correctness vs. a particular hardware. In the past I just picked up patches when I had the gut feeling they are remotely correct, but I'm tired of this.
I've just marked about 20 patches and patch series obsolete due to zero feedback from the relevant architecture/SoC people who were on Cc.
And I'm going to do that from now on very consequently. If the architecture, SoC experts can't be bothered to look after their stuff, then don't expect me to suck all of this crap up and then deal with the complaints when it breaks.
Quoted 5 lines
I'm still going to pick up obvious and simple bug fixes, but for anything which requires deep knowledge on the underlying hardware, I'm going to just mark them obsolete when they molded in my inbox unreviewed by the people who understand it for six weeks.
I think this is a fair ask.
Currently, I am focused on reviewing and testing anything which touches RISC-V AIA drivers. The SiFive PLIC driver on other hand seems to have no active reivewers from RISC-V space. Few years back I did try to actively review SiFive PLIC driver but these days I don't have bandwidth for that.
Regards,
Anup
Quoted 7 lines · Anup Patel
Quoted 5 lines · Thomas Gleixner
I'm still going to pick up obvious and simple bug fixes, but for anything which requires deep knowledge on the underlying hardware, I'm going to just mark them obsolete when they molded in my inbox unreviewed by the people who understand it for six weeks.
Quoted 7 lines
I think this is a fair ask.
Currently, I am focused on reviewing and testing anything which touches RISC-V AIA drivers. The SiFive PLIC driver on other hand seems to have no active reivewers from RISC-V space. Few years back I did try to actively review SiFive PLIC driver but these days I don't have bandwidth for that.
I don't blame you and I put you on the CC list because you are in the RISCV space.
I don't know what's wrong with SiFive but they really need to get their act together. Paul?
Thanks,
tglx
Paul Walmsley
maintainer+ Samuel
Hi Thomas,
Sorry for the delay; I've been on vacation this week.
Quoted 7 lines · Thomas Gleixner
Quoted 5 lines · Anup Patel
Quoted 4 lines · Thomas Gleixner
I'm still going to pick up obvious and simple bug fixes, but for anything which requires deep knowledge on the underlying hardware, I'm going to just mark them obsolete when they molded in my inbox unreviewed by the people who understand it for six weeks.
[ ... ]
Quoted 3 lines
I don't know what's wrong with SiFive but they really need to get their act together. Paul?
The approach you described above is fine. Please feel free to ignore anything beyond bug fixes that doesn't have an appropriate ack, at least until we figure out how to broaden the pool of maintainers for those drivers.
For what it's worth, several other companies also adopted SiFive PLIC-like interrupt controllers, and reuse those drivers. It would be great if kernel folks from those other companies can step in and help maintain the underlying code.
thanks,
- Paul