Remove duplicate Kconfig LEDS_LP5521 entry introduced by 67a32ec7

PATCH In review Arnaud Ebalard 2 participants 3 messages Jun 24, 2009 LED

Share & tools

Felipe Balbi

2009-06-24 09:01 UTC #1 lore raw

Quoted 10 lines · ext Arnaud Ebalard

Hi,
While playing with kernel configuration for my N810, I noticed a duplicate config entry for LEDS_LP5521.
AFAICT, it was added by commit 67a32ec7 (leds: introduce lp5521 led driver) but the entry was already there from 43350bf4 (leds: lp5521:
move to drivers/leds).
Following patch is against current linux-omap tree.

probably automerge issues.

Signature · 1 line

balbi

Arnaud Ebalard

author

2009-06-24 09:33 UTC #0 lore raw

PATCH 1/1 Remove duplicate Kconfig LEDS_LP5521 entry introduced by 67a32ec7

Hi,

While playing with kernel configuration for my N810, I noticed a duplicate config entry for LEDS_LP5521.

AFAICT, it was added by commit 67a32ec7 (leds: introduce lp5521 led driver) but the entry was already there from 43350bf4 (leds: lp5521:
move to drivers/leds).

Following patch is against current linux-omap tree.

Cheers,

Signed-off-by Arnaud Ebalard <[email protected]>

---
 drivers/leds/Kconfig |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)

drivers/leds/Kconfig +0 ~~-10~~

index 788f48c..0493c17 100644
@@ -170,16 +170,6 @@ config LEDS_LP5521
 	  This driver can be built as a module by choosing 'M'. The module
 	  will be called leds-lp5521.
 
-config LEDS_LP5521
-	tristate "LED Support for the LP5521 LEDs"
-	depends on LEDS_CLASS && I2C
-	help
-	  If you say 'Y' here you get support for the National Semiconductor
-	  LP5521 LED driver used in n8x0 boards.
-
-	  This driver can be built as a module by choosing 'M'. The module
-	  will be called leds-lp5521.
-
 config LEDS_CLEVO_MAIL
 	tristate "Mail LED on Clevo notebook"
 	depends on LEDS_CLASS && X86 && SERIO_I8042 && DMI

Signature · 1 line

1.6.3.1

Arnaud Ebalard

author

2009-06-24 10:42 UTC #2 lore raw

In reply to Felipe Balbi

Hi Felipe,

Quoted 6 lines · Felipe Balbi

Quoted 5 lines · ext Arnaud Ebalard
Hi,
While playing with kernel configuration for my N810, I noticed a duplicate config entry for LEDS_LP5521.

Quoted 7 lines

Quoted 5 lines
AFAICT, it was added by commit 67a32ec7 (leds: introduce lp5521 led driver) but the entry was already there from 43350bf4 (leds: lp5521:
move to drivers/leds).
Following patch is against current linux-omap tree.
probably automerge issues.

I have no clue on how it happened. After noticing the duplication, I just did a git annotate to get some info and then took a look at associated patches.

Cheers,