Skip to contentSkip to conversation

xfsprogs-6.10 breaks C++ compilation

DISCUSSION Sam James 1 participant 2 messages Aug 27, 2024

lore
Share & tools
lore

Sam James

author
#0 lore raw

Hi!

Forwarding a downstream report from https://bugs.gentoo.org/938569.

xfs_fs.h's xfs_getparents_next_rec relies on an implicit void*-to-T* cast which is legal in C, but not C++.

It fails like so when a C++ project tries to use the header:

```
/usr/include/xfs/xfs_fs.h: In function 'xfs_getparents_rec* xfs_getparents_next_rec(xfs_getparents*, xfs_getparents_rec*)':
/usr/include/xfs/xfs_fs.h:915:16: error: invalid conversion from 'void*' to 'xfs_getparents_rec*' [-fpermissive]
  915 |         return next;
      |                ^~~~
      |                |
      |                void*

```

It came up when building libktorrent.

thanks,
sam