Skip to contentSkip to conversation

net: stmmac: Premature loop termination check was ignored

PATCH Superseded Jochen Henneberg 1 participant 1 message Feb 21, 2023

Subsystems (4)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 net: stmmac: Premature loop termination check was ignored

The premature loop termination check makes sense only in case of the jump to read_again where the count may have been updated. But read_again did not include the check.

Fixes bba2556efad6 (net: stmmac: Enable RX via AF_XDP zero-copy)
Fixes ec222003bd94 (net: stmmac: Prepare to add Split Header support)

---
V2: Added fixes tags for both commits that introduced the issues

 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +2 -2
index 1a5b8dab5e9b..de98c009866a 100644
@@ -5031,10 +5031,10 @@ static int stmmac_rx_zc(struct stmmac_priv *priv, int limit, u32 queue)
 			len = 0;
 		}
 
+read_again:
 		if (count >= limit)
 			break;
 
-read_again:
 		buf1_len = 0;
 		entry = next_entry;
 		buf = &rx_q->buf_pool[entry];
@@ -5221,10 +5221,10 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue)
 			len = 0;
 		}
 
+read_again:
 		if (count >= limit)
 			break;
 
-read_again:
 		buf1_len = 0;
 		buf2_len = 0;
 		entry = next_entry;
Signature · 1 line
2.39.2