Skip to contentSkip to conversation

crypto: rsa - Add Makefile dependencies to fix parallel builds

PATCH New David Michael 1 participant 1 message Nov 29, 2016 Crypto API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: rsa - Add Makefile dependencies to fix parallel builds

Both asn1 headers are included by rsa_helper.c, so rsa_helper.o should explicitly depend on them.

---

Hi,

Our automated CI builds randomly fail with the following:

../source/crypto/rsa_helper.c:19:29: fatal error: rsaprivkey-asn1.h: No such file or directory ../source/scripts/Makefile.build:289: recipe for target 'crypto/rsa_helper.o' failed

I've added the following line and run a dozen or so builds, and they have not failed since. Can this patch be applied?

Thanks.

David

 crypto/Makefile | 1 +
 1 file changed, 1 insertion(+)
crypto/Makefile +1 -0
index 99cc64a..bd6a029 100644
@@ -40,6 +40,7 @@ obj-$(CONFIG_CRYPTO_ECDH) += ecdh_generic.o
 
 $(obj)/rsapubkey-asn1.o: $(obj)/rsapubkey-asn1.c $(obj)/rsapubkey-asn1.h
 $(obj)/rsaprivkey-asn1.o: $(obj)/rsaprivkey-asn1.c $(obj)/rsaprivkey-asn1.h
+$(obj)/rsa_helper.o: $(obj)/rsapubkey-asn1.h $(obj)/rsaprivkey-asn1.h
 clean-files += rsapubkey-asn1.c rsapubkey-asn1.h
 clean-files += rsaprivkey-asn1.c rsaprivkey-asn1.h
 
Signature · 1 line
2.7.4