Device-tree and Marvell vendor prefix
Hi Haojian, Grant and Rob,
I'm submitting various patches for Marvell PXA27x architecture to support device-tree.
In a review from Guennadi, he made me a comment that the official prefix for Marvell is "marvell" (according to Documentation/devicetree/bindings/vendor-prefixes.txt).
As a matter of fact, there are 2 prefixes used :
- "marvell" : 264 uses in *.c files
- "mrvl" : 64 uses in *.c files
So which one should I use ?
Cheers.
Signature · 5 lines
Robert -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 14 lines · Robert Jarzmik
Hi Haojian, Grant and Rob,
I'm submitting various patches for Marvell PXA27x architecture to support device-tree.
In a review from Guennadi, he made me a comment that the official prefix for Marvell is "marvell" (according to
Documentation/devicetree/bindings/vendor-prefixes.txt).As a matter of fact, there are 2 prefixes used :
- "marvell" : 264 uses in *.c files
- "mrvl" : 64 uses in *.c files
Quoted 6 lines
So which one should I use ?
Cheers.
--
Robert
Please use "marvell" instead since it's preferred. We can't replace "mrvl" by "marvell" roughly.
It may cause incompatible in other's tree. We can add "marvell" for all "mrvl" entries.
Regards
Haojian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 6 lines · Robert Jarzmik
Hi Haojian, Grant and Rob,
I'm submitting various patches for Marvell PXA27x architecture to support device-tree.
Quoted 7 lines
In a review from Guennadi, he made me a comment that the official prefix for Marvell is "marvell" (according to
Documentation/devicetree/bindings/vendor-prefixes.txt).As a matter of fact, there are 2 prefixes used :
- "marvell" : 264 uses in *.c files
- "mrvl" : 64 uses in *.c files
Yes, that's unfortunate. When we first started converting the Marvell legacy platforms (kirwkood, etc) to DT, there was discussion on which one to use. We chose to stay with 'marvell', despite 'mrvl' being the official stock ticker symbol. This was to maintain reverse compatibility with the binding for the marvell ethernet driver, mv643xx_eth, which had been is use on powerpc for years before us.
So, my preference is to use 'marvell'. I've attempted to correct any new bindings I see that use 'mrvl', but apparently I didn't catch them all. :(
Quoted 1 line
So which one should I use ?
I say 'marvell', but apparently there are others who think differently.
A check of the bindings docs and arch/*/boot/dts/ would be more telling than the C files.
thx,
Jason.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html