Copying to loop device hangs up everything
Subsystems (5)
Ok, I'm convinced, given that writers are throttled above the loopback thread. Follows the Andrea's patch, but against 2.4.17-rc2 + removed unused gfp_mask parameter of sync_page_buffers.
Regards,
-velco
fs/buffer.c +3 -2
@@ -2432,7 +2432,7 @@return 1 ; } -static int sync_page_buffers (struct buffer_head *head,unsigned int gfp_mask) +static int sync_page_buffers (struct buffer_head *head) {struct buffer_head * bh = head;int tryagain =0 ;
@@ -2533,9 +2533,10 @@/* Uhhuh, start writeback so that we don't end up with all dirty pages */ write_unlock (&hash_table_lock);spin_unlock (&lru_list_lock); + gfp_mask =pf_gfp_mask (gfp_mask);if (gfp_mask & __GFP_IO) {if ((gfp_mask & __GFP_HIGHIO) || !PageHighMem (page)) { -if (sync_page_buffers (bh, gfp_mask)) { +if (sync_page_buffers (bh)) {/* no IO or waiting next time */ gfp_mask =0 ; goto cleaned_buffers_try_again;
include/linux/mm.h +8 -0
@@ -547,6 +547,14 @@platforms, used as appropriate on others */ #define GFP_DMA __GFP_DMA +static inline unsigned int pf_gfp_mask (unsigned int gfp_mask) +{ +/* avoid all memory balancing I/O methods if this task cannot block on I/O */ +if (current->flags &PF_NOIO ) + gfp_mask &= ~(__GFP_IO | __GFP_HIGHIO | __GFP_FS); + +return gfp_mask; +}/* vma is the first one with address < vma->vm_end, * and even address < vma->vm_start. Have to extend vma. */
mm/vmscan.c +2 -0
@@ -588,6 +588,8 @@int priority =DEF_PRIORITY ;int nr_pages =SWAP_CLUSTER_MAX ; + gfp_mask =pf_gfp_mask (gfp_mask); + do { nr_pages = shrink_caches(classzone, priority, gfp_mask, nr_pages); if (nr_pages <= 0)