Skip to contentSkip to conversation

Fix trivial unwind info bug

PATCH In review Markus Armbruster 4 participants 4 messages Jul 27, 2006 – Jul 31, 2006

lore
Share & tools
lore

Markus Armbruster

author
#0 lore raw

PATCH 1/1 Fix trivial unwind info bug

CFA needs to be adjusted upwards for push, and downwards for pop. arch/i386/kernel/entry.S gets it wrong in one place.

Signed-off-by Markus Armbruster <[email protected]>
arch/i386/kernel/entry.S +1 -1
index d9a260f..37a7d2e 100644
@@ -204,7 +204,7 @@ #define RING0_PTREGS_FRAME \
 ENTRY(ret_from_fork)
        CFI_STARTPROC
        pushl %eax
-       CFI_ADJUST_CFA_OFFSET -4
+       CFI_ADJUST_CFA_OFFSET 4
        call schedule_tail
        GET_THREAD_INFO(%ebp)
        popl %eax
#1 lore raw
Quoted 4 lines · Markus Armbruster

CFA needs to be adjusted upwards for push, and downwards for pop. arch/i386/kernel/entry.S gets it wrong in one place.

Signed-off-by Markus Armbruster <[email protected]>

Thanks for the patch Markus. Andi Kleen is now maintaining i386 so please cc him in future for i386 patches.

arch/i386/kernel/entry.S #define RING0_PTREGS_FRAME \ · line 210

Quoted 13 lines
arch/i386/kernel/entry.S +1 -1
index d9a260f..37a7d2e 100644
@@ -204,7 +204,7 @@ #define RING0_PTREGS_FRAME \
 ENTRY(ret_from_fork)
       CFI_STARTPROC
       pushl %eax
-       CFI_ADJUST_CFA_OFFSET -4
+       CFI_ADJUST_CFA_OFFSET 4
       call schedule_tail
       GET_THREAD_INFO(%ebp)
       popl %eax

I wonder if this is related to the problem of dump_stack() crashing...

Cheers,

Signature · 4 lines
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#2 lore raw
Quoted 8 lines · On Tue, 01 Aug 2006 00:52:32 +1000 Herbert Xu wrote:
Quoted 4 lines · Markus Armbruster

CFA needs to be adjusted upwards for push, and downwards for pop. arch/i386/kernel/entry.S gets it wrong in one place.

Signed-off-by Markus Armbruster <[email protected]>

Thanks for the patch Markus. Andi Kleen is now maintaining i386 so please cc him in future for i386 patches.

Oh, that's clearer than what I heard. Please add it to MAINTAINERS.

Thanks,
---
~Randy

#3 lore raw
In reply to Herbert Xu
Quoted 8 lines · Herbert Xu
Quoted 4 lines · Markus Armbruster

CFA needs to be adjusted upwards for push, and downwards for pop. arch/i386/kernel/entry.S gets it wrong in one place.

Signed-off-by Markus Armbruster <[email protected]>

Thanks for the patch Markus. Andi Kleen is now maintaining i386 so please cc him in future for i386 patches.

Sorry, but that's not true. I do occassional i386 patches, but overall it is still maintainerless or done by Andrew.

-Andi