Skip to contentSkip to conversation

2.6.10-rc2-mm1: oops when accessing reiser4 fs's (maybe fix provided)

DISCUSSION Mathieu Segaud 2 participants 3 messages Nov 16, 2004 – Nov 17, 2004

lore
Share & tools
lore
#0 lore raw

I tried 2.6.10-rc2-mm1 and the last reiser4 updates gave some (many many) oopses flooding my screen :).
I tried reverting reiser4-fix-deadlock.patch and oopses are gone.

I tried this one because thru the quick traces on my screen, I saw a reference to get_current_context.
The speed of the traces and the unasibility of the box prevented me from making differences between "real" oopses and BUG_ON(), sorry for that...

If you want some traces I can provide them ASAP (e.g. tomorrow)

Best,

Signature · 3 lines
"I am getting pretty good at running diff and patch now."

	- Jeff Merkey
#1 lore raw

Hello

Quoted 4 lines · Mathieu Segaud

I tried 2.6.10-rc2-mm1 and the last reiser4 updates gave some (many many) oopses flooding my screen :).
I tried reverting reiser4-fix-deadlock.patch and oopses are gone.

Would you please instead try the attached patch?

Quoted 6 lines

I tried this one because thru the quick traces on my screen, I saw a reference to get_current_context.
The speed of the traces and the unasibility of the box prevented me from making differences between "real" oopses and BUG_ON(), sorry for that...

If you want some traces I can provide them ASAP (e.g. tomorrow)

# This is a BitKeeper generated diff -Nru style patch. #
# ChangeSet
# 2004/11/15 16:23:47+03:00 [email protected]
# unix_file_filemap_nopage: missing context creation is added
#

# plugin/file/file.c
#   2004/11/15 16:23:45+03:00 [email protected] +5 -1
#   unix_file_filemap_nopage: missing context creation is added
# 
diff -Nru a/plugin/file/file.c b/plugin/file/file.c
--- a/plugin/file/file.c	2004-11-17 09:36:11 +03:00
+++ b/plugin/file/file.c	2004-11-17 09:36:11 +03:00
@@ -1961,8 +1961,10 @@
 {
 	struct page *page;
 	struct inode *inode;
-
+	reiser4_context ctx;
+	
 	inode = area->vm_file->f_dentry->d_inode;
+	init_context(&ctx, inode->i_sb);

/* block filemap_nopage if copy on capture is processing with a node of this file */ down_read(&reiser4_inode_data(inode)->coc_sem);
@@ -1972,6 +1974,8 @@

drop_nonexclusive_access(unix_file_inode_data(inode)); up_read(&reiser4_inode_data(inode)->coc_sem);
+
+ reiser4_exit_context(&ctx);
return page;
}

#2 lore raw

Vladimir Saveliev <[email protected]> disait dernièrement que :

Quoted 8 lines

Hello

Quoted 4 lines · Mathieu Segaud

I tried 2.6.10-rc2-mm1 and the last reiser4 updates gave some (many many) oopses flooding my screen :).
I tried reverting reiser4-fix-deadlock.patch and oopses are gone.

Would you please instead try the attached patch?

yep.
indeed it worked
anyway, for the quick answer

Quoted 11 lines
Quoted 7 lines

I tried this one because thru the quick traces on my screen, I saw a reference to get_current_context.
The speed of the traces and the unasibility of the box prevented me from making differences between "real" oopses and BUG_ON(), sorry for that...

If you want some traces I can provide them ASAP (e.g. tomorrow)

Signature · 3 lines
Carrots work on rabbits, they don't work on hungry weasels.

	- Alan Cox on linux-kernel