Skip to contentSkip to conversation

Sashiko to track linux-mtd

DISCUSSION Miquel Raynal 6 participants 12 messages Jun 24 – Sep 3 Memory technology devices (MTD)

lore
Share & tools
lore

Miquel Raynal

author maintainer
#0 lore raw

Hello MTD folks,

I mentioned it rapidly on IRC but I believe a formal e-mail is more appropriate. I consider asking the Sashiko team to track linux-mtd to help us with reviews:

* [email protected]
* Roman Gushchin <[email protected]>

I believe Sashiko will be a useful tool given that our time is limited. We were already monitoring the output of Sashiko when other (Sashiko enabled) mailing lists were copied, so I propose to officially add linux-mtd to the list.

Richard said he was fine with the idea as long as it remained a tool. I agree with this approach, Sashiko is not the Alpha & Omega, but I believe it proved itself useful just by the amount of corner cases it managed to catch already. Not all recommendations should be followed and we are not looking for an empty Sashiko response for merging.

There is apparently the possibility to tune the prompt per subsystem. At this stage I haven't thought very deeply about it and considered not adding any subsystem specific rules. Maybe the SPI NOR team wants to come up with some guidelines, such as the need for a record (using the script in the documentation) for new chips additions. I would propose to not delay the addition of our mailing list for that. This does not need to be done from day 1, as we can make PRs to their GH repository with these extra requirements whenever we are ready, see below.

Thanks a lot,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

#1 lore raw
Quoted 6 lines · Miquel Raynal

Hello MTD folks,

I mentioned it rapidly on IRC but I believe a formal e-mail is more appropriate. I consider asking the Sashiko team to track linux-mtd to help us with reviews:

Quoted 7 lines

* [email protected]
* Roman Gushchin <[email protected]>

I believe Sashiko will be a useful tool given that our time is limited. We were already monitoring the output of Sashiko when other (Sashiko enabled) mailing lists were copied, so I propose to officially add linux-mtd to the list.

I have been using Sashiko a lot and I think it is quite useful. It helps catch bugs that are very hard for humans to see.

It doesn't do so well at design and high level patch review, so we aren't out of a job just yet ;-)

Quoted 7 lines

Richard said he was fine with the idea as long as it remained a tool. I agree with this approach, Sashiko is not the Alpha & Omega, but I believe it proved itself useful just by the amount of corner cases it managed to catch already. Not all recommendations should be followed and we are not looking for an empty Sashiko response for merging.

Quoted 8 lines

There is apparently the possibility to tune the prompt per subsystem. At this stage I haven't thought very deeply about it and considered not adding any subsystem specific rules. Maybe the SPI NOR team wants to come up with some guidelines, such as the need for a record (using the script in the documentation) for new chips additions. I would propose to not delay the addition of our mailing list for that. This does not need to be done from day 1, as we can make PRs to their GH repository with these extra requirements whenever we are ready, see below.

I think we should not do subsystem prompts unless we see it keeps tripping up on something it can't infer from looking at the source code. That is normally things like "this is a problem but we don't support this".

Other than that, you want it to run free and look at the source code as the source of truth, and not the prompts, which can go out of date.

Also, I think the prompts were more useful for older models which weren't as capable. Today's models are very good at looking at code, and generally don't need that much hand holding.

Quoted 2 lines
Signature · 6 lines
Regards,
Pratyush Yadav

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
author maintainer
#2 lore raw

Hello,

Quoted 1 line
Quoted 1 line

https://github.com/sashiko-dev/sashiko/blob/main/MAINTAINERS_GUIDE.md

There are a couple more questions we should answer regarding e-mail delivery:

- Shall Sashiko reply to all/just the author/a list of individuals?

If we go for e-mails, I'd answer to the thread, so "reply_all". But I'm open.

- Shall we set an embargo?

I'd be tempted to say "no").

- Shall Sashiko send a positive review in case nothing was spot?

If we enable e-mails, I'd be tempted to say "yes".

Thanks for your feedback.

Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

#3 lore raw

Hi,

Quoted 9 lines
Quoted 1 line
Quoted 1 line

https://github.com/sashiko-dev/sashiko/blob/main/MAINTAINERS_GUIDE.md

There are a couple more questions we should answer regarding e-mail delivery:

- Shall Sashiko reply to all/just the author/a list of individuals?

If we go for e-mails, I'd answer to the thread, so "reply_all". But I'm open.

I'd go to let it only reply to us, which will review the comments and forward them (or mention them with a link to the webinterface). But I'm open to just use reply_all, I just fear that a submitter will reply to useless/wrong suggestions.

Quoted 3 lines

- Shall we set an embargo?

I'd be tempted to say "no").

Whatever that is and how it will work with the reply_all option?

Quoted 3 lines

- Shall Sashiko send a positive review in case nothing was spot?

If we enable e-mails, I'd be tempted to say "yes".

yeah probably.

-michael

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

#4 lore raw

Hi,

Quoted 7 lines

Hi,

Quoted 5 lines
Quoted 1 line
Quoted 1 line

https://github.com/sashiko-dev/sashiko/blob/main/MAINTAINERS_GUIDE.md

There are a couple more questions we should answer regarding e-mail delivery:

Quoted 7 lines
Quoted 4 lines

- Shall Sashiko reply to all/just the author/a list of individuals?

If we go for e-mails, I'd answer to the thread, so "reply_all". But I'm open.

I'd go to let it only reply to us, which will review the comments and forward them (or mention them with a link to the webinterface).

I'd lean toward 'only reply to us'.

Quoted 9 lines

But I'm open to just use reply_all, I just fear that a submitter will reply to useless/wrong suggestions.

Quoted 3 lines

- Shall we set an embargo?

I'd be tempted to say "no").

Whatever that is and how it will work with the reply_all option?

Quoted 7 lines
Quoted 3 lines

- Shall Sashiko send a positive review in case nothing was spot?

If we enable e-mails, I'd be tempted to say "yes".

yeah probably.

-michael

Thanks,
Takahiro

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

author maintainer
#5 lore raw

Hello,

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 1 line
Quoted 1 line

https://github.com/sashiko-dev/sashiko/blob/main/MAINTAINERS_GUIDE.md

There are a couple more questions we should answer regarding e-mail delivery:

- Shall Sashiko reply to all/just the author/a list of individuals?

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

If we go for e-mails, I'd answer to the thread, so "reply_all". But I'm open.

I'd go to let it only reply to us, which will review the comments and forward them (or mention them with a link to the webinterface).

I'd lean toward 'only reply to us'.

That means more load on us somehow, I would have preferred an open answer, but let's try it your way first. We can adjust later.

Quoted 5 lines
Quoted 5 lines
Quoted 3 lines

- Shall Sashiko send a positive review in case nothing was spot?

If we enable e-mails, I'd be tempted to say "yes".

yeah probably.

Actually, I got annoyed by the amount of feedback (as a contributor in other subsystems) already, and as the answers are pretty fast, I believe it is not worth the extra load of e-mails to get those positive answers. Let's just stick to the "issues" if you don't mind for now.

FYI there is a pretty "hot" discussion about the usage by maintainers of Sashiko (and AI review in general) on the users mailing list. I am personally not aligned with the LF position stating that the Linux kernel is about technology and not ethics, though at this stage I want to try enabling reviews on linux-mtd, because hopefully it will help us. So I will make a PR for enabling it, but let's keep in mind that this is experimental and can be re-discussed at any time.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

author maintainer
#7 lore raw

Hello,

Quoted 6 lines · Miquel Raynal

Hello folks,

Quoted 2 lines

So I will make a PR for enabling it, but let's keep in mind that this is experimental and can be re-discussed at any time.

FYI: https://github.com/sashiko-dev/sashiko/pull/336

I am partially satisfied about how Sashiko intervenes in my review flow, here is my current feeling.

About Sashiko itself:
+ many interesting findings, worth enabling for sure
+ most of the findings are correct, but not always worth another version
- no possible feedback loop (eg. "this is an hallucination, stop bothering us with this")
- pre-existing issues are flagged at the same "level" as new issues

About our configuration of Sashiko:
- it takes more time to me to do the check, copy & paste dance every time there is something I find really needed
- I get Cc'ed on reviews of patches I did not receive (eg. jffs2 things)

In the end I would like to modify the current configuration in order for Sashiko to act as a regular reviewer, ie. just answer to all recipients, including the author:

- cc = ...
+ reply_all = true
+ reply_to_author = true

Cheers,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

#8 lore raw

Hi,

Am 25. August 2026 11:25:38 MESZ schrieb Miquel Raynal <[email protected]>:

Quoted 21 lines

Hello,

Quoted 6 lines · Miquel Raynal

Hello folks,

Quoted 2 lines

So I will make a PR for enabling it, but let's keep in mind that this is experimental and can be re-discussed at any time.

FYI: https://github.com/sashiko-dev/sashiko/pull/336

I am partially satisfied about how Sashiko intervenes in my review flow, here is my current feeling.

About Sashiko itself:
+ many interesting findings, worth enabling for sure
+ most of the findings are correct, but not always worth another version
- no possible feedback loop (eg. "this is an hallucination, stop bothering us with this")
- pre-existing issues are flagged at the same "level" as new issues

Quoted 4 lines

About our configuration of Sashiko:
- it takes more time to me to do the check, copy & paste dance every time there is something I find really needed
- I get Cc'ed on reviews of patches I did not receive (eg. jffs2 things)

Yeah I noticed that, too.

Quoted 7 lines

In the end I would like to modify the current configuration in order for Sashiko to act as a regular reviewer, ie. just answer to all recipients, including the author:

- cc = ...
+ reply_all = true
+ reply_to_author = true

I'm fine with the change. Let's see how patch submitters will react.

-michael

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

#9 lore raw
Quoted 35 lines

Hi,

Am 25. August 2026 11:25:38 MESZ schrieb Miquel Raynal <[email protected]>:

Quoted 21 lines

Hello,

Quoted 6 lines · Miquel Raynal

Hello folks,

Quoted 2 lines

So I will make a PR for enabling it, but let's keep in mind that this is experimental and can be re-discussed at any time.

FYI: https://github.com/sashiko-dev/sashiko/pull/336

I am partially satisfied about how Sashiko intervenes in my review flow, here is my current feeling.

About Sashiko itself:
+ many interesting findings, worth enabling for sure
+ most of the findings are correct, but not always worth another version
- no possible feedback loop (eg. "this is an hallucination, stop bothering us with this")
- pre-existing issues are flagged at the same "level" as new issues

Quoted 4 lines

About our configuration of Sashiko:
- it takes more time to me to do the check, copy & paste dance every time there is something I find really needed
- I get Cc'ed on reviews of patches I did not receive (eg. jffs2 things)

Yeah I noticed that, too.

Quoted 4 lines

In the end I would like to modify the current configuration in order for Sashiko to act as a regular reviewer, ie. just answer to all recipients, including the author:

Quoted 7 lines
Quoted 3 lines

- cc = ...
+ reply_all = true
+ reply_to_author = true

I'm fine with the change. Let's see how patch submitters will react.

-michael

I'm fine too.

Takahiro

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

author maintainer
#10 lore raw

Hello,

Quoted 8 lines
Quoted 8 lines
Quoted 7 lines

In the end I would like to modify the current configuration in order for Sashiko to act as a regular reviewer, ie. just answer to all recipients, including the author:

- cc = ...
+ reply_all = true
+ reply_to_author = true

Quoted 5 lines
Quoted 3 lines

I'm fine with the change. Let's see how patch submitters will react.

-michael

I'm fine too.

Thanks for your feedback, I made the request.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/