nommu: remove __GFP_HIGHMEM in vmalloc/vzalloc
Subsystems (2)
PATCH 1/1 nommu: remove __GFP_HIGHMEM in vmalloc/vzalloc
From mm/nommu.c:
void *__vmalloc(unsigned long size, gfp_t gfp_mask)
{
/*
* You can't specify __GFP_HIGHMEM with kmalloc() since kmalloc()
* returns only a logical address.
*/
return kmalloc(size, (gfp_mask | __GFP_COMP) & ~__GFP_HIGHMEM);
}nommu's __vmalloc just uses kmalloc internally and elimitates __GFP_HIGHMEM, so it makes no sense to add __GFP_HIGHMEM for nommu's vmalloc/vzalloc.
--- mm/nommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
mm/nommu.c +2 -2
@@ -233,7 +233,7 @@ long vwrite(char *buf, char *addr, unsigned long count)*/ void *vmalloc (unsigned long size) { -return __vmalloc (size,GFP_KERNEL | __GFP_HIGHMEM); +return __vmalloc (size,GFP_KERNEL ); }EXPORT_SYMBOL (vmalloc);
@@ -251,7 +251,7 @@ EXPORT_SYMBOL(vmalloc);*/ void *vzalloc (unsigned long size) { -return __vmalloc (size,GFP_KERNEL | __GFP_HIGHMEM | __GFP_ZERO); +return __vmalloc (size,GFP_KERNEL | __GFP_ZERO); }EXPORT_SYMBOL (vzalloc);
Signature · 1 line
2.31.1
Quoted 11 lines · Chen Li
From
mm/nommu.c:
void *__vmalloc(unsigned long size,gfp_tgfp_mask){ /* * You can't specify __GFP_HIGHMEM with kmalloc() since kmalloc() * returns only a logical address. */ return kmalloc(size, (gfp_mask | __GFP_COMP) & ~__GFP_HIGHMEM); }
Quoted 2 lines
nommu's
__vmallocjust uses kmalloc internally and elimitates__GFP_HIGHMEM, so it makes no sense to add__GFP_HIGHMEMfor nommu's vmalloc/vzalloc.
I think this was originally [1] a copy of vmalloc() from vmalloc.c, but of course the two have drifted apart over time. At the time, vmalloc.c's vmalloc() looked like this:
+void * vmalloc (unsigned long size)
+{
+ return __vmalloc(size, GFP_KERNEL | __GFP_HIGHMEM, PAGE_KERNEL);
+}
[1] And I do mean originally; this was present in Alan Cox's original submission of mm/nommu.c in 2002.
This patch makes sense to me, although I don't imagine it makes much difference.
Quoted 33 lines
Signed-off-by Chen Li <[email protected]>--- mm/nommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)mm/nommu.c +2
-2@@ -233,7 +233,7 @@ long vwrite(char *buf, char *addr, unsigned long count)*/ void *vmalloc (unsigned long size) { -return __vmalloc (size,GFP_KERNEL | __GFP_HIGHMEM); +return __vmalloc (size,GFP_KERNEL ); }EXPORT_SYMBOL (vmalloc);@@ -251,7 +251,7 @@ EXPORT_SYMBOL(vmalloc);*/ void *vzalloc (unsigned long size) { -return __vmalloc (size,GFP_KERNEL | __GFP_HIGHMEM | __GFP_ZERO); +return __vmalloc (size,GFP_KERNEL | __GFP_ZERO); }EXPORT_SYMBOL (vzalloc);Signature · 1 line
2.31.1
Quoted 34 lines · Chen Li
From
mm/nommu.c:
void *__vmalloc(unsigned long size,gfp_tgfp_mask){ /* * You can't specify __GFP_HIGHMEM with kmalloc() since kmalloc() * returns only a logical address. */ return kmalloc(size, (gfp_mask | __GFP_COMP) & ~__GFP_HIGHMEM); }nommu's
__vmallocjust uses kmalloc internally and elimitates__GFP_HIGHMEM, so it makes no sense to add__GFP_HIGHMEMfor nommu's vmalloc/vzalloc.Signed-off-by Chen Li <[email protected]>--- mm/nommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)mm/nommu.c +1
-1@@ -233,7 +233,7 @@ long vwrite(char *buf, char *addr, unsigned long count)*/ void *vmalloc (unsigned long size) { -return __vmalloc (size,GFP_KERNEL | __GFP_HIGHMEM); +return __vmalloc (size,GFP_KERNEL ); }EXPORT_SYMBOL (vmalloc);
mm/nommu.c EXPORT_SYMBOL(vmalloc); · line 257
Quoted 8 lines
mm/nommu.c +1
-1@@ -251,7 +251,7 @@ EXPORT_SYMBOL(vmalloc);*/ void *vzalloc (unsigned long size) { -return __vmalloc (size,GFP_KERNEL | __GFP_HIGHMEM | __GFP_ZERO); +return __vmalloc (size,GFP_KERNEL | __GFP_ZERO); }EXPORT_SYMBOL (vzalloc);
Signature · 3 lines
Thanks, David / dhildenb