Skip to contentSkip to conversation

usb: dwc2: disable power_down on rockchip for regression

PATCH RESEND New Felipe Balbi 1 participant 1 message Nov 14, 2018 USB

lore
Share & tools
lore
#0 lore raw

PATCH RESEND v2 1/1 usb: dwc2: disable power_down on rockchip for regression

Quoted 15 lines · Hal Emmerich

From 04fbf78e4e569bf872f1ffcb0a6f9b89569dc913 Mon Sep 17 00:00:00 2001
From: Hal Emmerich <[email protected]>
Date: Thu, 19 Jul 2018 21:48:08 -0500
Subject: [PATCH] usb: dwc2: disable power_down on rockchip devices

 The bug would let the usb controller enter partial power down, which was formally known as hibernate, upon boot if nothing was plugged in to the port. Partial power down couldn't be exited properly, so any usb devices plugged in after boot would not be usable.

 Before the name change, params.hibernation was false by default, so _dwc2_hcd_suspend() would skip entering hibernation. With the rename, _dwc2_hcd_suspend() was changed to use  params.power_down to decide whether or not to enter partial power down.

Quoted 8 lines

 Since params.power_down is non-zero by default, it needs to be set to 0 for rockchip devices to restore functionality.

 This bug was reported in the linux-usb thread:
 REGRESSION: usb: dwc2: USB device not seen after boot

 The commit that caused this regression is:
 6d23ee9caa6790aea047f9aca7f3c03cb8d96eb6

What are these weird space characters you're using in your commit log? I've fixed it locally this time, but please fix your editor.