how to force IVA2 powerdomain OFF on boot

PATCH Kevin Hilman 3 participants 3 messages Nov 25, 2008

Subsystems (4)

Arm (32-bit) Arm sub-architectures OMAP2+ support OMAP power management support

lore

Share & tools

lore

Kevin Hilman

author

2008-11-25 02:06 UTC #0 lore raw

Hello,

For some strange reason, some bootloaders (like u-boot on Beagle) seem to power up the DSP/IVA2 during boot. This of course will prevent full-chip retention until the IVA is put into retention.

On several boards I've tested the PM branch, after kernel boot the unused domains (like SGX, DSS, CAM, IVA2) are all in RET since the init code sets next states to retention. This is working except if the bootloader has powered up the IVA2.

I'm trying to figure out why the IVA2 isn't going into RET, even when iva2_fck is disabled during boot as part of the 'reset unused clocks' feature.

I'm now trying to force the IVA2 into RET/OFF during boot by following 'Figure 14-46: IVA2 Power Down' in the TRM (see patch[1] below), but that is not working. IVA2 still stays ON.

Any ideas?

Kevin

[1] This is an attempt to implement Figure 14-46, and then the 'reset unused clocks' will disable iva2_fck an finish the procedure.

khilman@vence:~/work/kernel/omap/dev$ git diff

arch/arm/mach-omap2/pm34xx.c +18 -0

index 804b3ac..5ef7cf8 100644
@@ -591,6 +591,24 @@ int __init omap3_pm_init(void)
 
 	(void) clkdm_for_each(clkdms_setup, NULL);
 
+	{
+		struct powerdomain *iva2_pwrdm;
+		struct clockdomain *iva2_clkdm;
+
+		iva2_pwrdm = pwrdm_lookup("iva2_pwrdm");
+		iva2_clkdm = clkdm_lookup("iva2_clkdm");
+
+		if (iva2_pwrdm && iva2_clkdm) {
+			u32 pwrst;
+
+			pwrdm_set_next_pwrst(iva2_pwrdm, PWRDM_POWER_OFF);
+			cm_write_mod_reg(0x1, OMAP3430_IVA2_MOD, CM_CLKSTCTRL);
+			prm_write_mod_reg(0, OMAP3430_IVA2_MOD, PM_WKDEP);
+			omap2_clkdm_sleep(iva2_clkdm);
+		} else 
+			printk(KERN_ERR "KJH: Cannot reset IVA2\n");
+	}
+
 	mpu_pwrdm = pwrdm_lookup("mpu_pwrdm");
 	if (mpu_pwrdm == NULL) {
 		printk(KERN_ERR "Failed to get mpu_pwrdm\n");

Hiroshi DOYU

2008-11-25 07:06 UTC #1 lore raw

Hi Kevin,

From: "ext Kevin Hilman" <[email protected]>
Subject: how to force IVA2 powerdomain OFF on boot
Date: Mon, 24 Nov 2008 18:05:59 -0800

Quoted 15 lines

Hello,
For some strange reason, some bootloaders (like u-boot on Beagle) seem to power up the DSP/IVA2 during boot. This of course will prevent full-chip retention until the IVA is put into retention.
On several boards I've tested the PM branch, after kernel boot the unused domains (like SGX, DSS, CAM, IVA2) are all in RET since the init code sets next states to retention. This is working except if the bootloader has powered up the IVA2.
I'm trying to figure out why the IVA2 isn't going into RET, even when iva2_fck is disabled during boot as part of the 'reset unused clocks' feature.

Quoted 5 lines

I'm now trying to force the IVA2 into RET/OFF during boot by following 'Figure 14-46: IVA2 Power Down' in the TRM (see patch[1] below), but that is not working. IVA2 still stays ON.
Any ideas?

I think that, this is because there's no 'Figure 14-45' steps, which goes into 'IVA2 ready to go to off mode', before the following code?

The explanation in 'Figure 14-45' says:

The user must also ensure that no other instruction is executed parallel to the IDLE instruction. When IVA2 is ready to go to off mode, there are two ways to completely shut down IVA2 subsystem (see Figure 14-46):

So I guess that 'Figure 14-45' should be done in DSP side for 'Figure 14-46' in advance?

Hiroshi DOYU

Quoted 47 lines

Kevin

[1] This is an attempt to implement Figure 14-46, and then the 'reset unused clocks' will disable iva2_fck an finish the procedure.

khilman@vence:~/work/kernel/omap/dev$ git diff

arch/arm/mach-omap2/pm34xx.c +18 -1

index 804b3ac..5ef7cf8 100644
@@ -591,6 +591,24 @@ int __init omap3_pm_init(void)
 
 	(void) clkdm_for_each(clkdms_setup, NULL);
 
+	{
+		struct powerdomain *iva2_pwrdm;
+		struct clockdomain *iva2_clkdm;
+
+		iva2_pwrdm = pwrdm_lookup("iva2_pwrdm");
+		iva2_clkdm = clkdm_lookup("iva2_clkdm");
+
+		if (iva2_pwrdm && iva2_clkdm) {
+			u32 pwrst;
+
+			pwrdm_set_next_pwrst(iva2_pwrdm, PWRDM_POWER_OFF);
+			cm_write_mod_reg(0x1, OMAP3430_IVA2_MOD, CM_CLKSTCTRL);
+			prm_write_mod_reg(0, OMAP3430_IVA2_MOD, PM_WKDEP);
+			omap2_clkdm_sleep(iva2_clkdm);
+		} else 
+			printk(KERN_ERR "KJH: Cannot reset IVA2\n");
+	}
+
 	mpu_pwrdm = pwrdm_lookup("mpu_pwrdm");
 	if (mpu_pwrdm == NULL) {
 		printk(KERN_ERR "Failed to get mpu_pwrdm\n");
 
 
 
 
 
 
--

To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Jean Pihet

2008-11-25 10:30 UTC #2 lore raw

In reply to Kevin Hilman

Hi Kevin,

In fact the IVA2 needs to execute the WFI instruction for its domain to go into idle.

Fortunately the IVA2 ROM code has some provision to do it in certain cases. The trick is to reset the IVA2, configure IVA to boot in idle mode, then let it run.

The attached patch might help.

Regards,
Jean.

Quoted 64 lines · On Tuesday 25 November 2008 03:05:59 Kevin Hilman wrote:

Hello,
For some strange reason, some bootloaders (like u-boot on Beagle) seem to power up the DSP/IVA2 during boot. This of course will prevent full-chip retention until the IVA is put into retention.
On several boards I've tested the PM branch, after kernel boot the unused domains (like SGX, DSS, CAM, IVA2) are all in RET since the init code sets next states to retention. This is working except if the bootloader has powered up the IVA2.
I'm trying to figure out why the IVA2 isn't going into RET, even when iva2_fck is disabled during boot as part of the 'reset unused clocks' feature.
I'm now trying to force the IVA2 into RET/OFF during boot by following 'Figure 14-46: IVA2 Power Down' in the TRM (see patch[1] below), but that is not working. IVA2 still stays ON.
Any ideas?
Kevin
[1] This is an attempt to implement Figure 14-46, and then the 'reset unused clocks' will disable iva2_fck an finish the procedure.
khilman@vence:~/work/kernel/omap/dev$ git diff
arch/arm/mach-omap2/pm34xx.c +18 -1
index 804b3ac..5ef7cf8 100644
@@ -591,6 +591,24 @@ int __init omap3_pm_init(void)
 
 	(void) clkdm_for_each(clkdms_setup, NULL);
 
+	{
+		struct powerdomain *iva2_pwrdm;
+		struct clockdomain *iva2_clkdm;
+
+		iva2_pwrdm = pwrdm_lookup("iva2_pwrdm");
+		iva2_clkdm = clkdm_lookup("iva2_clkdm");
+
+		if (iva2_pwrdm && iva2_clkdm) {
+			u32 pwrst;
+
+			pwrdm_set_next_pwrst(iva2_pwrdm, PWRDM_POWER_OFF);
+			cm_write_mod_reg(0x1, OMAP3430_IVA2_MOD, CM_CLKSTCTRL);
+			prm_write_mod_reg(0, OMAP3430_IVA2_MOD, PM_WKDEP);
+			omap2_clkdm_sleep(iva2_clkdm);
+		} else
+			printk(KERN_ERR "KJH: Cannot reset IVA2\n");
+	}
+
 	mpu_pwrdm = pwrdm_lookup("mpu_pwrdm");
 	if (mpu_pwrdm == NULL) {
 		printk(KERN_ERR "Failed to get mpu_pwrdm\n");
 
 
 
 
 
 
--

Quoted 3 lines

To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

From ee70db50f96681579019db54e2b89b837f34a916 Mon Sep 17 00:00:00 2001
From: Andy Lowe <[email protected]>
Date: Wed, 8 Oct 2008 19:23:04 -0500
Subject: [PATCH] OMAP3: Force IVA2 idle

The OMAP processor can't suspend unless the IVA2 (dsp) domain is idle. Transitioning the dsp into the idle state generally requires cooperation from the dsp software. However, in the case that the dsp is not being used, the MPU must force the dsp into the idle state. This patch forces the dsp into the idle state when the prcm is initialized.

Signed-off-by Andy Lowe <[email protected]>

---
 arch/arm/mach-omap2/prcm_34xx.c |   42 ++++++++++++++++++++++++++------------
 1 files changed, 29 insertions(+), 13 deletions(-)

arch/arm/mach-omap2/prcm_34xx.c +29 ~~-13~~

index 8e54d6c..f6a3f51 100644
@@ -4123,19 +4123,35 @@ int prcm_init(void)
 	}
 #endif
 
-	if (is_sil_rev_equal_to(OMAP3430_REV_ES1_0) ||
-			is_sil_rev_equal_to(OMAP3430_REV_ES2_0)) {
-		/* Due to Errata 1.27, IVA2 will not go to ret/off*/
-		/* during bootup.We need to manually boot it to  */
-		/* idle mode This is only required during bootup and not for*/
-		/* subsequent transitions */
-		/* Configure IVA to boot in idle mode */
-		CONTROL_IVA2_BOOTMOD = 0x1;
-		/* Clear reset of IVA2*/
-		RM_RSTCTRL_IVA2 = 0x0;
-		/* Clear reset status */
-		RM_RSTST_IVA2 = 0xFFFFFFFF;
-	}
+	/* Due to Errata 1.27, IVA2 will not go to ret/off
+	 * during bootup.  We need to manually boot it to
+	 * idle mode.  This is only required during bootup and not for
+	 * subsequent transitions.
+	 *
+	 * Note: this is needed on all OMAP revisions to allow
+	 *  suspend/resume to work: IVA2 needs to execute WFI inst
+	 *  for the IVA2 to go in OFF mode
+	 */
+	if (prcm_set_domain_functional_clocks(DOM_IVA2, 0))
+		printk(KERN_ERR "prcm_set_domain_functional_clocks for IVA2 "
+			"failed.\n");
+	RM_RSTCTRL_IVA2 = 0xFFFF;	/* Reset IVA2 */
+	if (prcm_set_domain_functional_clocks(DOM_IVA2, 1))
+		printk(KERN_ERR "prcm_set_domain_functional_clocks for IVA2 "
+			"failed.\n");
+	CONTROL_IVA2_BOOTMOD = 0x1;	/* set boot mode to idle */
+	RM_RSTCTRL_IVA2 = 0x0;		/* unreset the DSP */
+	if (prcm_set_domain_functional_clocks(DOM_IVA2, 0))
+		printk(KERN_ERR "prcm_set_domain_functional_clocks for IVA2 "
+			"failed.\n");
+	RM_RSTCTRL_IVA2 = 0xFFFF;	/* Reset IVA2 */
+	if (prcm_force_power_domain_state(DOM_IVA2, PRCM_OFF))
+		printk(KERN_ERR "prcm_set_power_domain_state for IVA2 "
+			"failed.\n");
+	if (prcm_set_clock_domain_state(DOM_IVA2, PRCM_HWSUP_AUTO, PRCM_FALSE))
+		printk(KERN_ERR "prcm_set_clock_domain_state for IVA2 "
+			"failed.\n");
+
 #ifdef CONFIG_HW_SUP_TRANS
 	/* L3, L4 and D2D clock autogating */
 	CM_CLKSTCTRL_CORE = (CLK_D2D_HW_SUP_ENABLE | CLK_L4_HW_SUP_ENABLE |

Signature · 1 line

1.5.4.4.21.gc4a6c