mount: call setgroups() before setuid()
Subsystems (2)
PATCH 1/1 mount: call setgroups() before setuid()
It is generally wise to call setgroups() (and setgid()) before calling setuid() to ensure no unexpected permission leaks happen. SUSE's build system checks all binaries for conformance with this and generates a warning for mountd.
As we are setting the uid to 0, there is no risk that the group list will provide extra permissions, so there is no real risk here. But it is nice to silence warnings, and including a setgroups() call is probably a good practice to encourage.
--- utils/mount/network.c | 2 ++ 1 file changed, 2 insertions(+)
utils/mount/network.c +2 -0
@@ -33,6 +33,7 @@#include <errno.h> #include <netdb.h> #include <time.h> +#include <grp.h> #include <sys/types.h> #include <sys/socket.h>
@@ -804,6 +805,7 @@ int start_statd(void)pid_t pid =fork ();switch (pid) {case 0 :/* child */ +setgroups (0 ,NULL );setgid (0 );setuid (0 );execle (START_STATD ,START_STATD ,NULL , envp);
Signature · 1 line
2.11.0
Quoted 11 lines · NeilBrown
It is generally wise to call
setgroups()(andsetgid()) before callingsetuid()to ensure no unexpected permission leaks happen. SUSE's build system checks all binaries for conformance with this and generates a warning for mountd.As we are setting the uid to 0, there is no risk that the group list will provide extra permissions, so there is no real risk here. But it is nice to silence warnings, and including a
setgroups()call is probably a good practice to encourage.Signed-off-by NeilBrown <[email protected]>
Committed...
steved.
Quoted 24 lines
--- utils/mount/network.c | 2 ++ 1 file changed, 2 insertions(+)utils/mount/network.c +2
-0@@ -33,6 +33,7 @@#include <errno.h> #include <netdb.h> #include <time.h> +#include <grp.h> #include <sys/types.h> #include <sys/socket.h> @@ -804,6 +805,7 @@ int start_statd(void)pid_t pid =fork ();switch (pid) {case 0 :/* child */ +setgroups (0 ,NULL );setgid (0 );setuid (0 );execle (START_STATD ,START_STATD ,NULL , envp);