Skip to contentSkip to conversation

Comment added in 63662139e "params: Fix potential memory leak in add_sysfs_param()"

DISCUSSION Rasmus Villemoes 1 participant 1 message Mar 21, 2014

lore
Share & tools
lore
#0 lore raw

Hi,

I'm not at all convinced by the comment added in commit 63662139e519ce. If krealloc(attrs, ...) fails, nothing seems to free attrs; the krealloc() call certainly doesn't do it. If attrs was NULL to begin with, no harm done, but otherwise it is "attrs = mk->mp->grp.attrs;", and mk->mp is NULL'ed on the error path fail_free_new: (and the value of mk->mp is anyway invalidated by the krealloc() above).

Am I missing something?

Rasmus