net ipv4: Allow unprivileged users to use most of the per net systctls
Subsystems (2)
PATCH 1/1 net ipv4: Allow unprivileged users to use most of the per net systctls
Allow unprivileged users to use:/proc/sys/net/ipv4/icmp_echo_ignore_all /proc/sys/net/ipv4/icmp_echo_ignore_broadcasts /proc/sys/net/ipv4/icmp_ignore_bogus_error_response /proc/sys/net/ipv4/icmp_errors_use_inbound_ifaddr /proc/sys/net/ipv4/icmp_ratelimit /proc/sys/net/ipv4/icmp_ratemask /proc/sys/net/ipv4/ping_group_range /proc/sys/net/ipv4/tcp_ecn /proc/sys/net/ipv4/ip_local_ports_range
These are occassionally handy and after a quick review I don't see any problems with unprivileged users using them.
--- net/ipv4/sysctl_net_ipv4.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
net/ipv4/sysctl_net_ipv4.c +2 -2
@@ -898,9 +898,9 @@ static __net_init int ipv4_sysctl_init_net(struct net *net) table[8 ].data = &net->ipv4.sysctl_local_ports.range; -/* Don't export sysctls to unprivileged users */ +/* Don't export dangerous sysctls to unprivileged users */ if (net->user_ns != &init_user_ns) - table[0 ].procname =NULL ; + table[9 ].procname =NULL ; }/*
Signature · 1 line
1.7.5.4
David Miller
maintainerFrom: [email protected] (Eric W. Biederman)
Date: Mon, 07 Oct 2013 16:58:43 -0700
Quoted 11 lines
Allow unprivileged users to use:
/proc/sys/net/ipv4/icmp_echo_ignore_all/proc/sys/net/ipv4/icmp_echo_ignore_broadcasts/proc/sys/net/ipv4/icmp_ignore_bogus_error_response/proc/sys/net/ipv4/icmp_errors_use_inbound_ifaddr/proc/sys/net/ipv4/icmp_ratelimit/proc/sys/net/ipv4/icmp_ratemask/proc/sys/net/ipv4/ping_group_range/proc/sys/net/ipv4/tcp_ecn/proc/sys/net/ipv4/ip_local_ports_range
...
net/ipv4/sysctl_net_ipv4.c static __net_init int ipv4_sysctl_init_net(struct net *net) · line 903
Quoted 2 lines
net/ipv4/sysctl_net_ipv4.c +1
-1- table[0 ].procname =NULL ; + table[9 ].procname =NULL ;
Regardless of what I think semantically of this change, you really have to find some way to avoid this magic constant.
Thanks.