Skip to contentSkip to conversation

Register the bus, vendor and product IDs for dvb-usb remote device

PATCH In review Chris Rankin 2 participants 2 messages Jan 21, 2007 – Jan 22, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Register the bus, vendor and product IDs for dvb-usb remote device

Hi,

This patch writes the USB vendor and product IDs into the /sys/class/input/inputX/id/ files, so that udev can find them. A rule like this does the trick for me:

KERNEL="event*", SYSFS{../id/vendor}=="2040", SYSFS{../id/product}=="9301", SYMLINK+="input/dvb-remote"

--- linux-2.6.18/drivers/media/dvb/dvb-usb/dvb-usb-remote.c.old 2007-01-21 02:43:11.000000000 +0000
+++ linux-2.6.18/drivers/media/dvb/dvb-usb/dvb-usb-remote.c 2007-01-21 02:39:02.000000000
+0000
@@ -107,6 +107,9 @@

        d->rc_input_dev->keycodemax = KEY_MAX;
        d->rc_input_dev->name = "IR-receiver inside an USB DVB receiver";
        d->rc_input_dev->phys = d->rc_phys;
+       d->rc_input_dev->id.bustype = BUS_USB;
+       d->rc_input_dev->id.vendor = d->udev->descriptor.idVendor;
+       d->rc_input_dev->id.product = d->udev->descriptor.idProduct;
        /* set the bits for the keys */
        deb_rc("key map size: %d\n", d->props.rc_key_map_size);

Cheers,
Chris

___________________________________________________________
What kind of emailer are you? Find out today - get a free analysis of your email personality. Take the quiz at the Yahoo! Mail Championship.
http://uk.rd.yahoo.com/evt=44106/*http://mail.yahoo.net/uk

#1 lore raw
Quoted 13 lines · Chris Rankin

Hi,

This patch writes the USB vendor and product IDs into the /sys/class/input/inputX/id/ files, so that udev can find them. A rule like this does the trick for me:

KERNEL="event*", SYSFS{../id/vendor}=="2040", SYSFS{../id/product}=="9301", SYMLINK+="input/dvb-remote"

--- linux-2.6.18/drivers/media/dvb/dvb-usb/dvb-usb-remote.c.old 2007-01-21 02:43:11.000000000 +0000
+++ linux-2.6.18/drivers/media/dvb/dvb-usb/dvb-usb-remote.c 2007-01-21 02:39:02.000000000
+0000

Review line 115

Quoted 9 lines
(quoted diff) +3 -0
@@ -107,6 +107,9 @@
        d->rc_input_dev->keycodemax = KEY_MAX;
        d->rc_input_dev->name = "IR-receiver inside an USB DVB receiver";
        d->rc_input_dev->phys = d->rc_phys;
+       d->rc_input_dev->id.bustype = BUS_USB;
+       d->rc_input_dev->id.vendor = d->udev->descriptor.idVendor;
+       d->rc_input_dev->id.product = d->udev->descriptor.idProduct;
 
        /* set the bits for the keys */
        deb_rc("key map size: %d\n", d->props.rc_key_map_size);

Chris,

The patch is fine. Could you please provide a sign-off, in the form:

...so that we can apply this to the kernel sources?

Cheers,

Mike Krufky