h8300 CONFIG_KALLSYMS fix
PATCH 4/6 h8300 CONFIG_KALLSYMS fix
Please comment "C_SYMBOL_PREFIX".
Makefile | 3 ++- arch/h8300/Kconfig | 4 ++++ 2 files changed, 6 insertions(+), 1 deletions(-)
Makefile +2 -1
@@ -751,7 +751,8 @@ endef # Generate .S file with all kernel symbols quiet_cmd_kallsyms = KSYM $@ cmd_kallsyms = $(NM) -n $< | $(KALLSYMS) \ - $(if $(CONFIG_KALLSYMS_ALL),--all-symbols) > $@ + $(if $(CONFIG_KALLSYMS_ALL),--all-symbols) \ + $(if $(CONFIG_C_SYMBOL_PREFIX),--symbol-prefix='_') > $@ .tmp_kallsyms1.o .tmp_kallsyms2.o .tmp_kallsyms3.o: %.o: %.S scripts FORCE $(call if_changed_dep,as_o_S)
arch/h8300/Kconfig +4 -0
@@ -87,6 +87,10 @@ config HZ int default 100 +config C_SYMBOL_PREFIX + bool + default y + source "init/Kconfig" source "arch/h8300/Kconfig.cpu"
Signature · 5 lines
1.5.4.1 -- Yoshinori Sato <[email protected]>
At Sat, 16 Feb 2008 01:13:47 -0500,
Quoted 42 lines · Yoshinori Sato
Please comment "
C_SYMBOL_PREFIX".Makefile | 3 ++- arch/h8300/Kconfig | 4 ++++ 2 files changed, 6 insertions(+), 1 deletions(-)Makefile +2
-1@@ -751,7 +751,8 @@ endef # Generate .S file with all kernel symbols quiet_cmd_kallsyms = KSYM $@ cmd_kallsyms = $(NM) -n $< | $(KALLSYMS) \ - $(if $(CONFIG_KALLSYMS_ALL),--all-symbols) > $@ + $(if $(CONFIG_KALLSYMS_ALL),--all-symbols) \ + $(if $(CONFIG_C_SYMBOL_PREFIX),--symbol-prefix='_') > $@ .tmp_kallsyms1.o .tmp_kallsyms2.o .tmp_kallsyms3.o: %.o: %.S scripts FORCE $(call if_changed_dep,as_o_S)arch/h8300/Kconfig +4
-0@@ -87,6 +87,10 @@ config HZ int default 100 +config C_SYMBOL_PREFIX + bool + default y + source "init/Kconfig" source "arch/h8300/Kconfig.cpu"Signature · 5 lines
1.5.4.1 -- Yoshinori Sato <[email protected]>
Quoted 26 lines · On Sat, 16 Feb 2008 01:13:47 -0500 Yoshinori Sato <[email protected]>…
Please comment "
C_SYMBOL_PREFIX".Makefile | 3 ++- arch/h8300/Kconfig | 4 ++++ 2 files changed, 6 insertions(+), 1 deletions(-)Makefile +2
-1@@ -751,7 +751,8 @@ endef # Generate .S file with all kernel symbols quiet_cmd_kallsyms = KSYM $@ cmd_kallsyms = $(NM) -n $< | $(KALLSYMS) \ - $(if $(CONFIG_KALLSYMS_ALL),--all-symbols) > $@ + $(if $(CONFIG_KALLSYMS_ALL),--all-symbols) \ + $(if $(CONFIG_C_SYMBOL_PREFIX),--symbol-prefix='_') > $@ .tmp_kallsyms1.o .tmp_kallsyms2.o .tmp_kallsyms3.o: %.o: %.S scripts FORCE $(call if_changed_dep,as_o_S)arch/h8300/Kconfig +0
-0
arch/h8300/Kconfig config HZ · line 96
Quoted 10 lines
arch/h8300/Kconfig +4
-0@@ -87,6 +87,10 @@ config HZ int default 100 +config C_SYMBOL_PREFIX + bool + default y + source "init/Kconfig" source "arch/h8300/Kconfig.cpu"
Sam looks after that code.
None of these patches added your Signed-off-by:. Please confirm that it is OK if I add it.
Quoted 30 lines · Andrew Morton
Quoted 28 lines · On Sat, 16 Feb 2008 01:13:47 -0500 Yoshinori Sato <[email protected]>…
Please comment "
C_SYMBOL_PREFIX".Makefile | 3 ++- arch/h8300/Kconfig | 4 ++++ 2 files changed, 6 insertions(+), 1 deletions(-)Makefile +2
-1@@ -751,7 +751,8 @@ endef # Generate .S file with all kernel symbols quiet_cmd_kallsyms = KSYM $@ cmd_kallsyms = $(NM) -n $< | $(KALLSYMS) \ - $(if $(CONFIG_KALLSYMS_ALL),--all-symbols) > $@ + $(if $(CONFIG_KALLSYMS_ALL),--all-symbols) \ + $(if $(CONFIG_C_SYMBOL_PREFIX),--symbol-prefix='_') > $@ .tmp_kallsyms1.o .tmp_kallsyms2.o .tmp_kallsyms3.o: %.o: %.S scripts FORCE $(call if_changed_dep,as_o_S)arch/h8300/Kconfig +0
-0@@ -87,6 +87,10 @@ config HZ int default 100
Quoted 8 lines
arch/h8300/Kconfig config HZ · line 96
Quoted 8 lines
arch/h8300/Kconfig +4
-0+config C_SYMBOL_PREFIX + bool + default y + source "init/Kconfig" source "arch/h8300/Kconfig.cpu"
The intent with this patch is fine but we should go for another implementation.
In arch/Kconfig we should put the general config symbol that says if we use '_' or not - where the default is to not use underscore.
Something like this:
arch/Kconfig +5 -0
@@ -29,3 +29,8 @@ config KPROBES config HAVE_KPROBES def_bool n + +# Architectures where binutils prefix C symbols with +# underscore '_' shall select this symbol. +config SYMBOL_C_PREFIX + bool
Then in the relevant architectures we should do a
config H8300
+ select SYMBOL_C_PREFIX # We prefix C symbols with '_'
And we should do this for all the relevant architectures:
blackfin, v850 springs to my mind.
For the other archs as separate patches via the respective maintainers.
Sam
Quoted 21 lines · Sam Ravnborg
Something like this:
arch/Kconfig +5
-0@@ -29,3 +29,8 @@ config KPROBES config HAVE_KPROBES def_bool n + +# Architectures where binutils prefix C symbols with +# underscore '_' shall select this symbol. +config SYMBOL_C_PREFIX + boolThen in the relevant architectures we should do a
config H8300
arch/Kconfig +1
-0+ select SYMBOL_C_PREFIX # We prefix C symbols with '_'
Quoted 5 lines
And we should do this for all the relevant architectures:
blackfin, v850 springs to my mind.
For the other archs as separate patches via the respective maintainers.
It's really a product of the toolchain, not the architecture. For SH also we have some toolchains that do this, and others that don't. (Usually sh-elf insteatd of sh-linux, the -elf toolchains in general are pretty common for the nommu targets). In general we've just not supported the symbol prefixing toolchains, but if there's a way we can handle this cleanly at compile time then it's certainly worth trying to support.