potential parse error in ifdef
Subsystems (8)
PATCH 1/1 potential parse error in ifdef
Hi,
I have made a tool to parse the kernel that does not pre-process the source. That means that my parser tries to parse all the code, including code in the #else branch or code that is not often compiled because the driver is not very used (or not used at all). So, my parser sometimes reports parse error not originally detected by gcc. Here is my (first) patch.
---
drivers/char/watchdog/ixp2000_wdt.c | 2 +- drivers/mtd/devices/pmc551.c | 2 +- drivers/mtd/nand/autcpu12.c | 2 +- drivers/mtd/nand/ppchameleonevb.c | 2 +- drivers/net/amd8111e.c | 2 +- drivers/net/skfp/smt.c | 2 +- drivers/scsi/aic7xxx/aic79xx_core.c | 2 +- sound/arm/sa11xx-uda1341.c | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-)
drivers/char/watchdog/ixp2000_wdt.c +1 -1
@@ -205,7 +205,7 @@ static void __exit ixp2000_wdt_exit(voidmodule_init (ixp2000_wdt_init);module_exit (ixp2000_wdt_exit); -MODULE_AUTHOR("Deepak Saxena <[email protected]">); +MODULE_AUTHOR ("Deepak Saxena <[email protected]>" );MODULE_DESCRIPTION ("IXP2000 Network Processor Watchdog" );module_param (heartbeat, int,0 );
drivers/mtd/devices/pmc551.c +1 -1
@@ -650,7 +650,7 @@ MODULE_DESCRIPTION(PMC551_VERSION);*/ static int msize =0 ;#if defined(CONFIG_MTD_PMC551_APERTURE_SIZE ) -static int asize = CONFIG_MTD_PMC551_APERTURE_SIZE +static int asize =CONFIG_MTD_PMC551_APERTURE_SIZE ;#else static int asize =0 ;#endif
drivers/mtd/nand/autcpu12.c +1 -1
@@ -101,7 +101,7 @@ static void autcpu12_hwcontrol(struct mtstruct nand_chip *chip = mtd->priv;if (ctrl &NAND_CTRL_CHANGE ) { - void __iomem *addr +void __iomem *addr;unsigned char bits; addr =CS89712_VIRT_BASE +AUTCPU12_SMC_PORT_OFFSET ;
drivers/mtd/nand/ppchameleonevb.c +1 -1
@@ -81,7 +81,7 @@ #ifdef CONFIG_MTD_PARTITIONS*/ static struct mtd_partition partition_info_hi[] = { { .name ="PPChameleon HI Nand Flash" , - offset =0 , + .offset =0 , .size =128 *1024 *1024 } };
drivers/net/amd8111e.c +1 -1
@@ -155,7 +155,7 @@ This function will write into PHY regist*/ static int amd8111e_write_phy (struct amd8111e_priv * lp,int phy_id,int reg,u32 val) { -unsigned int repeat =REPEAT_CNT +unsigned int repeat =REPEAT_CNT ;void __iomem *mmio = lp->mmio;unsigned int reg_val;
drivers/net/skfp/smt.c +1 -1
@@ -1748,7 +1748,7 @@ char *addr_to_string(struct fddi_addr *a#endif #ifdef AM29K -smt_ifconfig(int argc, char *argv[]) +int smt_ifconfig (int argc,char *argv[]) {if (argc >=2 && !strcmp (argv[0 ],"opt_bypass" ) && !strcmp (argv[1 ],"yes" )) {
drivers/scsi/aic7xxx/aic79xx_core.c +1 -1
@@ -5180,7 +5180,7 @@ #ifdef AHD_TARGET_MODE cur_lun = lun; max_lun = lun; } - for (cur_lun <= max_lun; cur_lun++) { +for (;cur_lun <= max_lun; cur_lun++) {struct ahd_tmode_lstate * lstate; lstate = tstate->enabled_luns[cur_lun];
sound/arm/sa11xx-uda1341.c +1 -1
@@ -987,7 +987,7 @@ static int __init sa11xx_uda1341_init(voif (platform_get_drvdata (device))return 0 ;platform_device_unregister (device); - err = -ENODEV + err = -ENODEV ; }else err =PTR_ERR (device);platform_driver_unregister (&sa11xx_uda1341_driver);
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
Quoted 6 lines · Yoann Padioleau
I have made a tool to parse the kernel that does not pre-process the source. That means that my parser tries to parse all the code, including code in the #else branch or code that is not often compiled because the driver is not very used (or not used at all). So, my parser sometimes reports parse error not originally detected by gcc. Here is my (first) patch.
Quoted 9 lines
drivers/char/watchdog/ixp2000_wdt.c | 2 +- drivers/mtd/devices/pmc551.c | 2 +- drivers/mtd/nand/autcpu12.c | 2 +- drivers/mtd/nand/ppchameleonevb.c | 2 +- drivers/net/amd8111e.c | 2 +- drivers/net/skfp/smt.c | 2 +- drivers/scsi/aic7xxx/aic79xx_core.c | 2 +- sound/arm/sa11xx-uda1341.c | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-)
As these are totally independent fixes across various subsystems, you should probably split the patch into per-subsystem patches and submit them separately.
Thanks,
Signature · 5 lines
Jiri Kosina _______________________________________________ Kernel-janitors mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
Quoted 18 lines · On Fri, 25 May 2007 13:50:37 +0200 (CEST) Jiri Kosina <[email protected]> wrote:
Quoted 6 lines · Yoann Padioleau
I have made a tool to parse the kernel that does not pre-process the source. That means that my parser tries to parse all the code, including code in the #else branch or code that is not often compiled because the driver is not very used (or not used at all). So, my parser sometimes reports parse error not originally detected by gcc. Here is my (first) patch.
Quoted 9 lines
drivers/char/watchdog/ixp2000_wdt.c | 2 +- drivers/mtd/devices/pmc551.c | 2 +- drivers/mtd/nand/autcpu12.c | 2 +- drivers/mtd/nand/ppchameleonevb.c | 2 +- drivers/net/amd8111e.c | 2 +- drivers/net/skfp/smt.c | 2 +- drivers/scsi/aic7xxx/aic79xx_core.c | 2 +- sound/arm/sa11xx-uda1341.c | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-)
Quoted 3 lines
As these are totally independent fixes across various subsystems, you should probably split the patch into per-subsystem patches and submit them separately.
That's normally true, yes. But for a bunch of obviously-better one-line fixes in code which nobody has even compiled in ages, I think we can bend the rules a bit and just slam it in.
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors