Skip to contentSkip to conversation

compile error

2.5.69, TR Jochen Hein 2 participants 4 messages May 5, 2003 Network drivers

lore
Share & tools
lore
#0 lore raw

This seems to be a fallout from the irq-type changes:

gcc -Wp,-MD,drivers/net/pcmcia/.ibmtr_cs.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=pentium2 -Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include
-DMODULE -DKBUILD_BASENAME=ibmtr_cs -DKBUILD_MODNAME=ibmtr_cs -c
-o drivers/net/pcmcia/ibmtr_cs.o drivers/net/pcmcia/ibmtr_cs.c
In file included from drivers/net/pcmcia/ibmtr_cs.c:71:
drivers/net/tokenring/ibmtr.c: In function `tok_open':
drivers/net/tokenring/ibmtr.c:903: warning: `MOD_INC_USE_COUNT' is
deprecated (declared at include/linux/module.h:456)
In file included from drivers/net/pcmcia/ibmtr_cs.c:71:
drivers/net/tokenring/ibmtr.c: In function `tok_close':
drivers/net/tokenring/ibmtr.c:1068: warning: `MOD_DEC_USE_COUNT' is
deprecated (declared at include/linux/module.h:468)
drivers/net/pcmcia/ibmtr_cs.c: At top level:
drivers/net/pcmcia/ibmtr_cs.c:130: conflicting types for
`tok_interrupt'
drivers/net/tokenring/ibmtr.c:1170: previous declaration of
`tok_interrupt'
make[3]: *** [drivers/net/pcmcia/ibmtr_cs.o] Fehler 1 make[2]: *** [drivers/net/pcmcia] Fehler 2
make[1]: *** [drivers/net] Fehler 2
make: *** [drivers] Fehler 2

Signature · 1 line
#include <~/.signature>: permission denied
#1 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 17 lines · Jochen Hein

This seems to be a fallout from the irq-type changes:

gcc -Wp,-MD,drivers/net/pcmcia/.ibmtr_cs.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=pentium2 -Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include
-DMODULE -DKBUILD_BASENAME=ibmtr_cs -DKBUILD_MODNAME=ibmtr_cs -c
-o drivers/net/pcmcia/ibmtr_cs.o drivers/net/pcmcia/ibmtr_cs.c
In file included from drivers/net/pcmcia/ibmtr_cs.c:71:
drivers/net/tokenring/ibmtr.c: In function `tok_open':
drivers/net/tokenring/ibmtr.c:903: warning: `MOD_INC_USE_COUNT' is
deprecated (declared at include/linux/module.h:456)
In file included from drivers/net/pcmcia/ibmtr_cs.c:71:
drivers/net/tokenring/ibmtr.c: In function `tok_close':
drivers/net/tokenring/ibmtr.c:1068: warning: `MOD_DEC_USE_COUNT' is
deprecated (declared at include/linux/module.h:468)
drivers/net/pcmcia/ibmtr_cs.c: At top level:

Quoted 8 lines

drivers/net/pcmcia/ibmtr_cs.c:130: conflicting types for
`tok_interrupt'
drivers/net/tokenring/ibmtr.c:1170: previous declaration of
`tok_interrupt'
make[3]: *** [drivers/net/pcmcia/ibmtr_cs.o] Fehler 1 make[2]: *** [drivers/net/pcmcia] Fehler 2 make[1]: *** [drivers/net] Fehler 2
make: *** [drivers] Fehler 2

Can you please post your .config, as I'm not able to reproduce it. thanks.

- --
Regards Michael Büsch
http://www.8ung.at/tuxsoft
20:32:19 up 2:57, 1 user, load average: 1.17, 1.06, 1.14
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+tq5moxoigfggmSgRAghNAJ0UOjfMe+00LE5Rfo4zMOFKZMwJvACeOtWg Vcf0mH80oXgwedcBrDk/NsE=
=7vUk
-----END PGP SIGNATURE-----

#2 lore raw
Quoted 27 lines · Michael Buesch
Quoted 17 lines · Jochen Hein

This seems to be a fallout from the irq-type changes:

gcc -Wp,-MD,drivers/net/pcmcia/.ibmtr_cs.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=pentium2 -Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include
-DMODULE -DKBUILD_BASENAME=ibmtr_cs -DKBUILD_MODNAME=ibmtr_cs -c
-o drivers/net/pcmcia/ibmtr_cs.o drivers/net/pcmcia/ibmtr_cs.c
In file included from drivers/net/pcmcia/ibmtr_cs.c:71:
drivers/net/tokenring/ibmtr.c: In function `tok_open':
drivers/net/tokenring/ibmtr.c:903: warning: `MOD_INC_USE_COUNT' is
deprecated (declared at include/linux/module.h:456)
In file included from drivers/net/pcmcia/ibmtr_cs.c:71:
drivers/net/tokenring/ibmtr.c: In function `tok_close':
drivers/net/tokenring/ibmtr.c:1068: warning: `MOD_DEC_USE_COUNT' is
deprecated (declared at include/linux/module.h:468)
drivers/net/pcmcia/ibmtr_cs.c: At top level:

Quoted 8 lines

drivers/net/pcmcia/ibmtr_cs.c:130: conflicting types for
`tok_interrupt'
drivers/net/tokenring/ibmtr.c:1170: previous declaration of
`tok_interrupt'
make[3]: *** [drivers/net/pcmcia/ibmtr_cs.o] Fehler 1 make[2]: *** [drivers/net/pcmcia] Fehler 2 make[1]: *** [drivers/net] Fehler 2
make: *** [drivers] Fehler 2

Quoted 2 lines

Can you please post your .config, as I'm not able to reproduce it. thanks.

The following patch fixes it for me, but I think this prototype should be removed:

drivers/net/pcmcia/ibmtr_cs.c renamed from drivers/net/pcmcia/ibmtr_cs.c~ +1 -1
@@ -127,7 +127,7 @@
 
 extern int ibmtr_probe(struct net_device *dev);
 extern int trdev_init(struct net_device *dev);
-extern void tok_interrupt (int irq, void *dev_id, struct pt_regs *regs);
+extern irqreturn_t tok_interrupt (int irq, void *dev_id, struct pt_regs *regs);
 
 /*====================================================================*/
 

Relevant part of .config:

CONFIG_TR=y
CONFIG_IBMTR=m
CONFIG_PCMCIA_IBMTR=m

Jochen

Signature · 1 line
#include <~/.signature>: permission denied
#3 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 1 line · Jochen Hein

The following patch fixes it for me,

[snip]

thanks. For me, too.

- --
Regards Michael Büsch
http://www.8ung.at/tuxsoft
21:01:04 up 3:25, 2 users, load average: 1.10, 1.07, 1.01
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+trVKoxoigfggmSgRAql2AKCNz28Whjf9DHQLD7brA5mz7bExbwCeM5jt B0y8XFhZpuofPyCHBRpP0Cg=
=AyQi
-----END PGP SIGNATURE-----