Skip to contentSkip to conversation

Pass additional metadata to sendemail-validate hook from git send-email

Proposal Strawbridge, Michael 2 participants 3 messages Aug 26, 2022 – Aug 29, 2022

lore
Share & tools
lore
#0 lore raw

Hi,

I was hoping to put a feature proposal forward for git send-email.

For git send-email there is a git hook, sendemail-validate which gets the body of the email that will be sent but is missing some of the metadata that git send-email has access to. I propose that we also pass the extra metadata that gets presented to the user later on via stdout such as: From, To, Cc, Subject, Date, Message-Id, X-Mailer, MIME-Version, Content-Transfer-Encoding to the git hook.

I'm willing to work on the patch but want to make sure the idea would be accepted first.

Thank you,
Michael

#1 lore raw

Re: [Proposal] Pass additional metadata to sendemail-validate hook from git send-emailg

Quoted 1 line · Michael

Hi,

Hey,

Quoted 10 lines

I was hoping to put a feature proposal forward for git send-email.

For git send-email there is a git hook, sendemail-validate which gets the body of the email that will be sent but is missing some of the metadata that git send-email has access to. I propose that we also pass the extra metadata that gets presented to the user later on via stdout such as: From, To, Cc, Subject, Date, Message-Id, X-Mailer, MIME-Version, Content-Transfer-Encoding to the git hook.

Quoted 2 lines

I'm willing to work on the patch but want to make sure the idea would be accepted first.

I think the idea is interesting and would be willing to see a patch come to the list.

However, having said that, we typically evaluate patches, not proposals, so to see if it's actually accepted, you'd have to actually send a patch. We may find that while the idea is interesting, it turns out to be infeasible, or, for whatever reason, the patch is unsuitable.

I know that this is different from how other projects typically work, where you typically pitch an idea first and then implement, but it's what we do here.

Signature · 2 lines
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA
#2 lore raw
In reply to Strawbridge, Michael

Thanks for getting back to me. I'll write up a patch.

Quoted 45 lines · brian m. carlson
Quoted 1 line · Michael

Hi,

Hey,

Quoted 16 lines

I was hoping to put a feature proposal forward for git send-email.

For git send-email there is a git hook, sendemail-validate which
gets the body of the email that will be sent but is missing some
of the metadata that git send-email has access to. I propose that
we also pass the extra metadata that gets presented to the user
later on via stdout such as: From, To, Cc, Subject, Date, Message-Id, X-Mailer, MIME-Version, Content-Transfer-Encoding to
the git hook.

Quoted 3 lines

I'm willing to work on the patch but want to make sure the idea
would be accepted first.

I think the idea is interesting and would be willing to see a patch come
to the list.

However, having said that, we typically evaluate patches, not proposals,
so to see if it's actually accepted, you'd have to actually send a
patch. We may find that while the idea is interesting, it turns out to
be infeasible, or, for whatever reason, the patch is unsuitable.

I know that this is different from how other projects typically work,
where you typically pitch an idea first and then implement, but it's
what we do here.

Signature · 2 lines
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA