Skip to contentSkip to conversation

error out if ENOSPC during file layout

RFC PATCH In review Kushal Kumaran 3 participants 3 messages Nov 20, 2020 – Nov 22, 2020

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 error out if ENOSPC during file layout

Hi,

When I run fio with --create_only=1 and it runs out of space, it still exits with status 0. I could not figure out if this was intentional (except for the fill_device case, where this is obviously the expected behavior).

$ cat ~/fio 
[global]
ioengine=posixaio
rw=readwrite
size=2g
directory=${HOME}/mounts/testdisk
thread=1

[trivial-readwrite-1g]

$ df -h .
Filesystem      Size  Used Avail Use% Mounted on
/dev/loop6      976M  2.6M  907M   1% /home/kushal/mounts/testdisk
$ fio ~/fio --create_only=1
trivial-readwrite-1g: (g=0): rw=rw, bs=(R) 4096B-4096B, (W) 4096B-4096B, (T) 4096B-4096B, ioengine=pos
ixaio, iodepth=1                                                                                     
fio-3.12
Starting 1 thread
trivial-readwrite-1g: Laying out IO file (1 file / 2048MiB)
fio: ENOSPC on laying out file, stopping

Run status group 0 (all jobs):

Disk stats (read/write):
loop6: ios=0/0, merge=0/0, ticks=0/0, in_queue=0, util=0.00%

$ echo $?
0

A trivial patch for this gives me the behavior I expect.

---
 filesetup.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
filesetup.c +1 -2
index f4360a6f..42c5f630 100644
@@ -231,13 +231,12 @@ static int extend_file(struct thread_data *td, struct fio_file *f)
 						break;
 					log_info("fio: ENOSPC on laying out "
 						 "file, stopping\n");
-					break;
 				}
 				td_verror(td, errno, "write");
 			} else
 				td_verror(td, EIO, "write");
 
-			break;
+			goto err;
 		}
 	}
 
Signature · 1 line
2.20.1
#1 lore raw

Hi,

This does look like better behaviour to me.

Jens, can we pick this one up?

Quoted 63 lines · Kushal Kumaran

Hi,

When I run fio with --create_only=1 and it runs out of space, it still exits with status 0. I could not figure out if this was intentional (except for the fill_device case, where this is obviously the expected behavior).

$ cat ~/fio
[global]
ioengine=posixaio
rw=readwrite
size=2g
directory=${HOME}/mounts/testdisk
thread=1

[trivial-readwrite-1g]

$ df -h .
Filesystem      Size  Used Avail Use% Mounted on
/dev/loop6      976M  2.6M  907M   1% /home/kushal/mounts/testdisk
$ fio ~/fio --create_only=1
trivial-readwrite-1g: (g=0): rw=rw, bs=(R) 4096B-4096B, (W) 4096B-4096B, (T) 4096B-4096B, ioengine=pos
ixaio, iodepth=1
fio-3.12
Starting 1 thread
trivial-readwrite-1g: Laying out IO file (1 file / 2048MiB)
fio: ENOSPC on laying out file, stopping

Run status group 0 (all jobs):

Disk stats (read/write):
loop6: ios=0/0, merge=0/0, ticks=0/0, in_queue=0, util=0.00%

$ echo $?
0

A trivial patch for this gives me the behavior I expect.

---
 filesetup.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
filesetup.c +1 -3
index f4360a6f..42c5f630 100644
@@ -231,13 +231,12 @@ static int extend_file(struct thread_data *td, struct fio_file *f)
                                                break;
                                        log_info("fio: ENOSPC on laying out "
                                                 "file, stopping\n");
-                                       break;
                                }
                                td_verror(td, errno, "write");
                        } else
                                td_verror(td, EIO, "write");
 
-                       break;
+                       goto err;
                }
        }
 
--

2.20.1

Signature · 1 line
Sitsofe | http://sucs.org/~sits/
#2 lore raw
In reply to Kushal Kumaran
Quoted 28 lines · Kushal Kumaran

Hi,

When I run fio with --create_only=1 and it runs out of space, it still exits with status 0. I could not figure out if this was intentional (except for the fill_device case, where this is obviously the expected behavior).

$ cat ~/fio 
[global]
ioengine=posixaio
rw=readwrite
size=2g
directory=${HOME}/mounts/testdisk
thread=1

[trivial-readwrite-1g]

$ df -h .
Filesystem      Size  Used Avail Use% Mounted on
/dev/loop6      976M  2.6M  907M   1% /home/kushal/mounts/testdisk
$ fio ~/fio --create_only=1
trivial-readwrite-1g: (g=0): rw=rw, bs=(R) 4096B-4096B, (W) 4096B-4096B, (T) 4096B-4096B, ioengine=pos
ixaio, iodepth=1                                                                                     
fio-3.12
Starting 1 thread
trivial-readwrite-1g: Laying out IO file (1 file / 2048MiB)
fio: ENOSPC on laying out file, stopping
Quoted 8 lines

Run status group 0 (all jobs):

Disk stats (read/write):
loop6: ios=0/0, merge=0/0, ticks=0/0, in_queue=0, util=0.00%

$ echo $?
0

A trivial patch for this gives me the behavior I expect.

That seems reasonable. Applied, thanks.

Signature · 1 line
Jens Axboe