Skip to contentSkip to conversation

mm __page_symlink retry loop error code fix

PATCH New Dmitriy Monakhov 1 participant 1 message Feb 15, 2007 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm __page_symlink retry loop error code fix

If prepare_write or commit_write return AOP_TRUNCATED_PAGE we jump to "retry" label and than if find_or_create_page() failed function return incorrect error code. Initilally i've add this fix as a part of prepare_write_retval patch, but IMHO it is better to split this to separate fix.
Patch against 2.6.20-rc6-mm3.

-------

fs/namei.c +2 -1
index 723db81..6b6fe43 100644
@@ -2692,10 +2692,11 @@ int __page_symlink(struct inode *inode, const char *symname, int len,
 {
 	struct address_space *mapping = inode->i_mapping;
 	struct page *page;
-	int err = -ENOMEM;
+	int err;
 	char *kaddr;
 
 retry:
+	err = -ENOMEM;
 	page = find_or_create_page(mapping, 0, gfp_mask);
 	if (!page)
 		goto fail;