roles: Fix USB 3.0 OTG issue on Intel platform

PATCH New Felipe Balbi 1 participant 1 message Sep 7, 2018 USB

lore

Share & tools

lore

Felipe Balbi

author

2018-09-07 08:33 UTC #0 lore raw

PATCH v6 1/1 roles: Fix USB 3.0 OTG issue on Intel platform

Hi Greg,

Quoted 12 lines · Saranya

Quoted 12 lines
Review
Quoted 1 line
(quoted diff) +0 -0
b/drivers/usb/roles/intel-xhci-usb-role-switch.c
drivers/usb/roles/intel-xhci-usb-role-switch.c line 28
Quoted 8 lines
index dad2d19..0d1ea82 100644
drivers/usb/roles/intel-xhci-usb-role-switch.c +1 -0
@@ -25,6 +25,9 @@
 #define SW_VBUS_VALID			BIT(24)
 #define SW_IDPIN_EN			BIT(21)
 #define SW_IDPIN			BIT(20)
+#define SW_SWITCH_EN_CFG0		BIT(16)
Why is this not in the correct sorted order with the items above it?

they are sorted in descending order.

/* register definition */
#define DUAL_ROLE_CFG0 0x68
#define SW_VBUS_VALID BIT(24)
#define SW_IDPIN_EN BIT(21)
#define SW_IDPIN BIT(20)