Skip to contentSkip to conversation

virtio console: don't manually set or finalize VIRTIO_CONSOLE_F_MULTIPORT.

PATCH In review Rusty Russell 2 participants 2 messages Mar 9, 2011

Subsystems (3)
Char and misc drivers virtio core virtio console driver
lore
Share & tools
lore

Rusty Russell

author
#0 lore raw

PATCH 1/1 virtio console: don't manually set or finalize VIRTIO_CONSOLE_F_MULTIPORT.

That's already been done by the virtio infrastructure before the probe function is called.

Reported-by [email protected]
Signed-off-by Rusty Russell <[email protected]>
drivers/char/virtio_console.c +0 -5
@@ -1680,17 +1680,12 @@ static int __devinit virtcons_probe(stru
 	portdev->config.max_nr_ports = 1;
 	if (virtio_has_feature(vdev, VIRTIO_CONSOLE_F_MULTIPORT)) {
 		multiport = true;
-		vdev->features[0] |= 1 << VIRTIO_CONSOLE_F_MULTIPORT;
-
 		vdev->config->get(vdev, offsetof(struct virtio_console_config,
 						 max_nr_ports),
 				  &portdev->config.max_nr_ports,
 				  sizeof(portdev->config.max_nr_ports));
 	}
 
-	/* Let the Host know we support multiple ports.*/
-	vdev->config->finalize_features(vdev);
-
 	err = init_vqs(portdev);
 	if (err < 0) {
 		dev_err(&vdev->dev, "Error %d initializing vqs\n", err);