wait_task_zombie plus WNOWAIT question
Hi!
I'm working on (sigh) next version of wait_task_* cleanups and stuck in wait_task_zombie. I'm trying to move put_user(stat, wo->wo_stat) code from all wait_task_* functions to common place, but wait_task_zombie does not fill wo_stat if WNOWAIT flag is set and does it w/o that flag. Is it done so by design, or I can make user-visible change and add put_user in WNOWAIT path?
Thanks!
Signature · 1 line
wbr, Vitaly
Quoted 5 lines · Vitaly Mayatskikh
I'm working on (sigh) next version of wait_task_* cleanups and stuck in
wait_task_zombie. I'm trying to moveput_user(stat, wo->wo_stat)code from all wait_task_* functions to common place, butwait_task_zombiedoes not fillwo_statif WNOWAIT flag is set
Only waitid() can use WNOWAIT, and in this case ->wo_stat == NULL.
Quoted 3 lines
and does
it w/o that flag. Is it done so by design, or I can make user-visible change and addput_userin WNOWAIT path?
Just check do not do put_user(->wo_stat) if it is NULL in do_wait pathes.
Oleg.
Quoted 8 lines · Oleg Nesterov
Quoted 5 lines · Vitaly Mayatskikh
I'm working on (sigh) next version of wait_task_* cleanups and stuck in
wait_task_zombie. I'm trying to moveput_user(stat, wo->wo_stat)code from all wait_task_* functions to common place, butwait_task_zombiedoes not fillwo_statif WNOWAIT flag is set
Quoted 8 lines
Only
waitid()can use WNOWAIT, and in this case ->wo_stat == NULL.Quoted 3 lines
and does
it w/o that flag. Is it done so by design, or I can make user-visible change and addput_userin WNOWAIT path?Just check do not do
put_user(->wo_stat)if it is NULL indo_waitpathes.
Got it! Thanks, Oleg!
Signature · 1 line
wbr, Vitaly