Skip to contentSkip to conversation

glib-2.0: add -dev dependencies to fix ptest failures

PATCH Superseded Mingde (Matthew) Zeng 2 participants 2 messages Jan 30, 2020 – Jan 31, 2020

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 glib-2.0: add -dev dependencies to fix ptest failures

There are a number of ptest failures due to glib-genmarshal, glib-mkenums and couple other executables not in the image. Since these executables are in FILES_${PN}-dev, we add ${PN}-dev to ptest RDEPENDS.

When starting a glib ptest but decided to Ctrl-c interrupt midway, ./run-ptest cannot be restarted unless running userdel glib2-test manually. Therefore adding a check prior to ptest will ensure the ptest can be restarted.

---
 meta/recipes-core/glib-2.0/glib-2.0/run-ptest | 3 +++
 meta/recipes-core/glib-2.0/glib.inc           | 3 +++
 2 files changed, 6 insertions(+)
meta/recipes-core/glib-2.0/glib-2.0/run-ptest +3 -0
index fc50082c8e..7a231b514b 100644
@@ -1,6 +1,9 @@
 #! /bin/sh
 
 set -eux
+if id -u glib2-test; then
+   userdel glib2-test
+fi
 useradd glib2-test
 su glib2-test -c 'gnome-desktop-testing-runner glib'
 userdel glib2-test
meta/recipes-core/glib-2.0/glib.inc +3 -0
index f4aff297e5..7204fc908a 100644
@@ -138,6 +138,9 @@ CODEGEN_PYTHON_RDEPENDS_mingw32 = ""
 
 RDEPENDS_${PN}-codegen += "${CODEGEN_PYTHON_RDEPENDS}"
 
+RDEPENDS_${PN}-ptest += "${PN}-dev"
+INSANE_SKIP_${PN}-ptest += "dev-deps"
+
 RDEPENDS_${PN}-ptest += "\
             coreutils \
             libgcc \

--
2.24.0

#1 lore raw
Quoted 3 lines · Mingde (Matthew) Zeng

There are a number of ptest failures due to glib-genmarshal, glib-mkenums and couple other executables not in the image. Since these executables are in FILES_${PN}-dev, we add ${PN}-dev to ptest RDEPENDS.

All of -dev is a bit overkill. Maybe we should just move those binaries from PN-dev to PN-utils, and depend on that instead?

Ross