Skip to contentSkip to conversation

PM branch updates: 3430sdp and omap3evm results

PATCH Kevin Hilman 5 participants 18 messages Jan 27, 2009 – Feb 12, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hello,

I've updated the PM branch with a couple of fixes that get it working on the 3430SDP.

For it to work on the SDP, you need the latest u-boot from the omapzoom u-boot tree[1]. This fixes the problems I was having with the D2D clockdomain remaining active or hanging upon clock disable.

For omap3evm, it is not hitting retention because it uses the GPIO debounce feature for the touchscreen and the GPIO debounce clocks are not disabled in idle or suspend. As a temporary hack, you can test the patch below[2] which simply doesn't call the gpio debounce functions for the touchscreen. In the meantime, I'm working on a patch to disable the debounce clocks on idle.

Kevin

[1] git://git.omapzoom.org/repo/u-boot.git

[2]
da7df18bc7f5648ac7fe6e674065ca5899ff8d3d

 arch/arm/mach-omap2/board-omap3evm.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-omap2/board-omap3evm.c +2 -2
index 6fbbe95..18a07b5 100644
@@ -176,8 +176,8 @@ static void ads7846_dev_init(void)
 
 	gpio_direction_input(OMAP3_EVM_TS_GPIO);
 
-	omap_set_gpio_debounce(OMAP3_EVM_TS_GPIO, 1);
-	omap_set_gpio_debounce_time(OMAP3_EVM_TS_GPIO, 0xa);
+/* 	omap_set_gpio_debounce(OMAP3_EVM_TS_GPIO, 1); */
+/* 	omap_set_gpio_debounce_time(OMAP3_EVM_TS_GPIO, 0xa); */
 }
 
#1 lore raw

Op 27 jan 2009, om 19:16 heeft Kevin Hilman het volgende geschreven:

Quoted 4 lines

Hello,

I've updated the PM branch with a couple of fixes that get it working on the 3430SDP.

Any chance of the beagle cpufreq patch ending up in the branch?

regards,

Koen

Quoted 41 lines

For it to work on the SDP, you need the latest u-boot from the omapzoom u-boot tree[1]. This fixes the problems I was having with the D2D clockdomain remaining active or hanging upon clock disable.

For omap3evm, it is not hitting retention because it uses the GPIO debounce feature for the touchscreen and the GPIO debounce clocks are not disabled in idle or suspend. As a temporary hack, you can test the patch below[2] which simply doesn't call the gpio debounce functions for the touchscreen. In the meantime, I'm working on a patch to disable the debounce clocks on idle.

Kevin

[1] git://git.omapzoom.org/repo/u-boot.git

[2]
da7df18bc7f5648ac7fe6e674065ca5899ff8d3d
arch/arm/mach-omap2/board-omap3evm.c | 4 ++--

1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-omap2/board-omap3evm.c +2 -3
index 6fbbe95..18a07b5 100644
@@ -176,8 +176,8 @@ static void ads7846_dev_init(void)
 
 	gpio_direction_input(OMAP3_EVM_TS_GPIO);
 
-	omap_set_gpio_debounce(OMAP3_EVM_TS_GPIO, 1);
-	omap_set_gpio_debounce_time(OMAP3_EVM_TS_GPIO, 0xa);
+/* 	omap_set_gpio_debounce(OMAP3_EVM_TS_GPIO, 1); */
+/* 	omap_set_gpio_debounce_time(OMAP3_EVM_TS_GPIO, 0xa); */
 }
 
--

To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
Quoted 9 lines · Koen Kooi

Op 27 jan 2009, om 19:16 heeft Kevin Hilman het volgende geschreven:

Quoted 4 lines

Hello,

I've updated the PM branch with a couple of fixes that get it working on the 3430SDP.

Any chance of the beagle cpufreq patch ending up in the branch?

Yes, a 100% chance. :)

I reworked the version you sent me to use a common header for the rates since it was shared between beagle and SDP.

Just pushed it to my pm branch[1].

NOTE: Tony's tree wont sync yet for while, so I recomment you pull straight from mine. Also, I just pushed this, so the git.kernel.org mirrors might take some time to sync up as well.

The tip of the branch should now be:
OMAP3: PM: add common OPP definitions and use them on Beagle

Kevin

[1] http://git.kernel.org/?p=linux/kernel/git/khilman/linux-omap-pm.git;a=summary

Quoted 43 lines
Quoted 43 lines

For it to work on the SDP, you need the latest u-boot from the omapzoom u-boot tree[1]. This fixes the problems I was having with the D2D clockdomain remaining active or hanging upon clock disable.

For omap3evm, it is not hitting retention because it uses the GPIO debounce feature for the touchscreen and the GPIO debounce clocks are not disabled in idle or suspend. As a temporary hack, you can test the patch below[2] which simply doesn't call the gpio debounce functions for the touchscreen. In the meantime, I'm working on a patch to disable the debounce clocks on idle.

Kevin

[1] git://git.omapzoom.org/repo/u-boot.git

[2]
da7df18bc7f5648ac7fe6e674065ca5899ff8d3d
arch/arm/mach-omap2/board-omap3evm.c | 4 ++--

1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-omap2/board-omap3evm.c +0 -0

omap2/board-omap3evm.c
index 6fbbe95..18a07b5 100644

arch/arm/mach-omap2/board-omap3evm.c +2 -3
@@ -176,8 +176,8 @@ static void ads7846_dev_init(void)
 
 	gpio_direction_input(OMAP3_EVM_TS_GPIO);
 
-	omap_set_gpio_debounce(OMAP3_EVM_TS_GPIO, 1);
-	omap_set_gpio_debounce_time(OMAP3_EVM_TS_GPIO, 0xa);
+/* 	omap_set_gpio_debounce(OMAP3_EVM_TS_GPIO, 1); */
+/* 	omap_set_gpio_debounce_time(OMAP3_EVM_TS_GPIO, 0xa); */
 }
 
--

To unsubscribe from this list: send the line "unsubscribe linux- omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw

Op 27 jan 2009, om 20:52 heeft Kevin Hilman het volgende geschreven:

Quoted 12 lines
Quoted 9 lines · Koen Kooi

Op 27 jan 2009, om 19:16 heeft Kevin Hilman het volgende geschreven:

Quoted 4 lines

Hello,

I've updated the PM branch with a couple of fixes that get it working on the 3430SDP.

Any chance of the beagle cpufreq patch ending up in the branch?

Quoted 6 lines

Yes, a 100% chance. :)

I reworked the version you sent me to use a common header for the rates since it was shared between beagle and SDP.

Just pushed it to my pm branch[1].

Thanks! I checked 15 minutes ago, just before you pushed it :)

regards,

Koen

Quoted 56 lines

NOTE: Tony's tree wont sync yet for while, so I recomment you pull straight from mine. Also, I just pushed this, so the git.kernel.org mirrors might take some time to sync up as well.

The tip of the branch should now be:
OMAP3: PM: add common OPP definitions and use them on Beagle

Kevin

[1] http://git.kernel.org/?p=linux/kernel/git/khilman/linux-omap-pm.git;a=summary

Quoted 43 lines
Quoted 43 lines

For it to work on the SDP, you need the latest u-boot from the omapzoom u-boot tree[1]. This fixes the problems I was having with the D2D clockdomain remaining active or hanging upon clock disable.

For omap3evm, it is not hitting retention because it uses the GPIO debounce feature for the touchscreen and the GPIO debounce clocks are not disabled in idle or suspend. As a temporary hack, you can test the patch below[2] which simply doesn't call the gpio debounce functions for the touchscreen. In the meantime, I'm working on a patch to disable the debounce clocks on idle.

Kevin

[1] git://git.omapzoom.org/repo/u-boot.git

[2]
da7df18bc7f5648ac7fe6e674065ca5899ff8d3d
arch/arm/mach-omap2/board-omap3evm.c | 4 ++--

1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-omap2/board-omap3evm.c +0 -0

omap2/board-omap3evm.c
index 6fbbe95..18a07b5 100644

arch/arm/mach-omap2/board-omap3evm.c +2 -3
@@ -176,8 +176,8 @@ static void ads7846_dev_init(void)
 
 	gpio_direction_input(OMAP3_EVM_TS_GPIO);
 
-	omap_set_gpio_debounce(OMAP3_EVM_TS_GPIO, 1);
-	omap_set_gpio_debounce_time(OMAP3_EVM_TS_GPIO, 0xa);
+/* 	omap_set_gpio_debounce(OMAP3_EVM_TS_GPIO, 1); */
+/* 	omap_set_gpio_debounce_time(OMAP3_EVM_TS_GPIO, 0xa); */
 }
 
--

To unsubscribe from this list: send the line "unsubscribe linux- omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw
In reply to Kevin Hilman

Hi Kevin,

Quoted 8 lines · Kevin Hilman

Hello,

I've updated the PM branch with a couple of fixes that get it working on the 3430SDP.

For it to work on the SDP, you need the latest u-boot from the omapzoom u-boot tree[1]. This fixes the problems I was having with the D2D clockdomain remaining active or hanging upon clock disable.

I have tested this on my 3430SDP, I am seeing all domains hitting the off mode.

But I am seeing some issues while waking up iva domain after suspend.

There are couple of cases.

1. after booting the kernel
I run
echo 1 > /sys/power/clocks_off_while_idle
echo 1 > /sys/power/voltage_off_while_idle
echo 1 > /sys/power/enable_off_mode

and
echo mem > /sys/power/state

# echo mem > /sys/power/state
<6>PM: Syncing filesystems ... PM: Syncing filesystems ... done.
done.
Freezing user space processes ... Freezing user space processes ... (elapsed 0.0
0 seconds) (elapsed 0.00 seconds) done.
done.
Freezing remaining freezable tasks ... Freezing remaining freezable tasks ... (e
lapsed 0.00 seconds) (elapsed 0.00 seconds) done.done.

Suspending console(s) (use no_console_suspend to debug) Suspending console(s) (use no_console_suspend to debug) <6>Successfully put all powerdomains to target state Successfully put all powerdomains to target state Restarting tasks ... Restarting tasks ... done. done.
#

If I install bridgedriver and enable iva2 clock I am getting below messages
clock: dpll2_ck failed transition to 'locked'

<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'
<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'

2. I run below commands as soon as kernel is booted. echo 1 > /sys/power/clocks_off_while_idle echo 1 > /sys/power/voltage_off_while_idle echo 1 > /sys/power/enable_off_mode

installed bridge driver, loaded an dsp image(which also enables iva2_ck, gpt6_ick/fck, mail box clocks)

I run system suspend, I am seeing all powerdomains enters into OFF mode, but after this I am not able to wakeup iva domain, I reenabled clocks but no use.

3. Without the option
echo 1 > /sys/power/clocks_off_while_idle every thing works fine but perdomain is not hitting the off mode.

Please let me know any thoghts on these issues I am seeing.

Signature · 2 lines
Thanks
Ramesh Gupta G
#5 lore raw

Hi,

I am able to resolve all other issues with this pm branch except one issue,

I am not able to enable the iva2 clock once system is suspended and resumed, I am getting below messages.

Quoted 5 lines

<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'
<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'

Once after booting ( without adding bridgedriver/ installing bridgedriver) CM_CLKEN_PLL_IVA2 value shows as 0x37 indicates IVA2 DPLL in locked mode.

once after system suspend the value is not restored I am seeing that as
0x11 indicates IVA2 DPLL is low power stop mode.

Can any one please provide your inputs on the above error? I tried reconfiguring the CM_CLKEN_PLL_IVA2 to lock mode but still I am seeing the same messages as above while enabling iva2 clock.

thanks & regards
Ramesh Gupta G

#6 lore raw
Quoted 15 lines · Ramesh Gupta Guntha

Hi,

I am able to resolve all other issues with this pm branch except one issue,

I am not able to enable the iva2 clock once system is suspended and resumed, I am getting below messages.

Quoted 5 lines

<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'
<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'

Once after booting ( without adding bridgedriver/ installing bridgedriver) CM_CLKEN_PLL_IVA2 value shows as 0x37 indicates IVA2 DPLL in locked mode.

Quoted 6 lines

once after system suspend the value is not restored I am seeing that as
0x11 indicates IVA2 DPLL is low power stop mode.

Can any one please provide your inputs on the above error? I tried reconfiguring the CM_CLKEN_PLL_IVA2 to lock mode but still I am seeing the same messages as above while enabling iva2 clock.

Are you suspending into retention or off-mode?

Kevin

#7 lore raw

Kevin,

Quoted 17 lines · Kevin Hilman
Quoted 15 lines · Ramesh Gupta Guntha

Hi,

I am able to resolve all other issues with this pm branch except one issue,

I am not able to enable the iva2 clock once system is suspended and resumed, I am getting below messages.

Quoted 5 lines

<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'
<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'

Once after booting ( without adding bridgedriver/ installing bridgedriver) CM_CLKEN_PLL_IVA2 value shows as 0x37 indicates IVA2 DPLL in locked mode.

Quoted 8 lines
Quoted 6 lines

once after system suspend the value is not restored I am seeing that as
0x11 indicates IVA2 DPLL is low power stop mode.

Can any one please provide your inputs on the above error? I tried reconfiguring the CM_CLKEN_PLL_IVA2 to lock mode but still I am seeing the same messages as above while enabling iva2 clock.

Are you suspending into retention or off-mode?

I am suspending into Off mode.

regards
Ramesh Gupta G

#8 lore raw
Quoted 24 lines · Ramesh Gupta Guntha

Kevin,

Quoted 20 lines · Kevin Hilman
Quoted 18 lines · Ramesh Gupta Guntha

Hi,

I am able to resolve all other issues with this pm branch except one issue,

I am not able to enable the iva2 clock once system is suspended and resumed, I am getting below messages.

Quoted 5 lines

<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'
<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'

Once after booting ( without adding bridgedriver/ installing bridgedriver) CM_CLKEN_PLL_IVA2 value shows as 0x37 indicates IVA2 DPLL in locked mode.

once after system suspend the value is not restored I am seeing that as
0x11 indicates IVA2 DPLL is low power stop mode.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Can any one please provide your inputs on the above error? I tried reconfiguring the CM_CLKEN_PLL_IVA2 to lock mode but still I am seeing the same messages as above while enabling iva2 clock.

Are you suspending into retention or off-mode?

I am suspending into Off mode.

Do you see this problem when only going into retention?

If not, sounds like we're missing some registers being saved/restored across off-mode.

Kevin

#9 lore raw

Hi Kevin,

Quoted 32 lines · Kevin Hilman
Quoted 30 lines · Ramesh Gupta Guntha

Kevin,

Quoted 25 lines · Kevin Hilman
Quoted 15 lines · Ramesh Gupta Guntha

Hi,

I am able to resolve all other issues with this pm branch except one issue,

I am not able to enable the iva2 clock once system is suspended and resumed, I am getting below messages.

Quoted 5 lines

<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'
<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'

Once after booting ( without adding bridgedriver/ installing bridgedriver) CM_CLKEN_PLL_IVA2 value shows as 0x37 indicates IVA2 DPLL in locked mode.

Quoted 6 lines

once after system suspend the value is not restored I am seeing that as
0x11 indicates IVA2 DPLL is low power stop mode.

Can any one please provide your inputs on the above error? I tried reconfiguring the CM_CLKEN_PLL_IVA2 to lock mode but still I am seeing the same messages as above while enabling iva2 clock.

Are you suspending into retention or off-mode?

Quoted 7 lines
Quoted 2 lines

I am suspending into Off mode.

Do you see this problem when only going into retention?

If not, sounds like we're missing some registers being saved/restored across off-mode.

I am seeing this issue only with OFF mode , retention works fine for me, yeah, looks like some registers are not restored properly across off mode. please let me know your inputs on this.

Signature · 2 lines
Thanks
Ramesh Gupta G
#17 lore raw
In reply to Kevin Hilman
Quoted 46 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of ext Kevin Hilman
Sent: 04.02.2009 08:10
To: Ramesh Gupta Guntha
Cc: [email protected]
Subject: Re: PM branch updates: 3430sdp and omap3evm results

Quoted 12 lines · Ramesh Gupta Guntha

Kevin,

Quoted 8 lines · Kevin Hilman
Quoted 6 lines · Ramesh Gupta Guntha

Hi,

I am able to resolve all other issues with this pm branch except
one issue,

I am not able to enable the iva2 clock once system is

suspended and

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

resumed, I am getting below messages.

Quoted 5 lines

<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'
<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'

Once after booting ( without adding bridgedriver/ installing bridgedriver)
CM_CLKEN_PLL_IVA2 value shows as 0x37 indicates IVA2 DPLL

in locked mode.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

once after system suspend the value is not restored I am seeing that as
0x11 indicates IVA2 DPLL is low power stop mode.

Can any one please provide your inputs on the above

error? I tried

Quoted 5 lines
Quoted 4 lines
Quoted 2 lines

reconfiguring the CM_CLKEN_PLL_IVA2 to lock mode but still I am seeing the same messages as above while enabling iva2 clock.

Are you suspending into retention or off-mode?

Quoted 7 lines
Quoted 2 lines

I am suspending into Off mode.

Do you see this problem when only going into retention?

If not, sounds like we're missing some registers being saved/restored across off-mode.

This remids me about another issue which is with DPLL5. ROM code is not currently saving/restoring that. Maybe there is similar situation with DPLL2.

Quoted 8 lines

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at
http://vger.kernel.org/majordomo-info.html

#10 lore raw
In reply to Ramesh Gupta Guntha
Quoted 39 lines · Ramesh Gupta Guntha

Hi Kevin,

Quoted 35 lines · Kevin Hilman
Quoted 32 lines · Ramesh Gupta Guntha

Kevin,

Quoted 17 lines · Kevin Hilman
Quoted 15 lines · Ramesh Gupta Guntha

Hi,

I am able to resolve all other issues with this pm branch except one issue,

I am not able to enable the iva2 clock once system is suspended and resumed, I am getting below messages.

Quoted 5 lines

<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'
<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'

Once after booting ( without adding bridgedriver/ installing bridgedriver) CM_CLKEN_PLL_IVA2 value shows as 0x37 indicates IVA2 DPLL in locked mode.

Quoted 8 lines
Quoted 6 lines

once after system suspend the value is not restored I am seeing that as
0x11 indicates IVA2 DPLL is low power stop mode.

Can any one please provide your inputs on the above error? I tried reconfiguring the CM_CLKEN_PLL_IVA2 to lock mode but still I am seeing the same messages as above while enabling iva2 clock.

Are you suspending into retention or off-mode?

I am suspending into Off mode.

Quoted 9 lines
Quoted 4 lines

Do you see this problem when only going into retention?

If not, sounds like we're missing some registers being saved/restored across off-mode.

I am seeing this issue only with OFF mode , retention works fine for me, yeah, looks like some registers are not restored properly across off mode. please let me know your inputs on this.

I have just updated the PM branch with a fix from Jouni to save/restore CM_CLKSEL1_PLL_IVA2.

Can you try the latest PM branch?

Thanks,

Kevin

#11 lore raw

Kevin,
I applied the patch maually at my end and tested, this works fine for me. anyway I will try with pm branch .

thanks
Ramesh Gupta G

Quoted 60 lines · Kevin Hilman
Quoted 39 lines · Ramesh Gupta Guntha

Hi Kevin,

Quoted 35 lines · Kevin Hilman
Quoted 32 lines · Ramesh Gupta Guntha

Kevin,

Quoted 17 lines · Kevin Hilman
Quoted 15 lines · Ramesh Gupta Guntha

Hi,

I am able to resolve all other issues with this pm branch except one issue,

I am not able to enable the iva2 clock once system is suspended and resumed, I am getting below messages.

Quoted 5 lines

<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'
<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'

Once after booting ( without adding bridgedriver/ installing bridgedriver) CM_CLKEN_PLL_IVA2 value shows as 0x37 indicates IVA2 DPLL in locked mode.

Quoted 8 lines
Quoted 6 lines

once after system suspend the value is not restored I am seeing that as
0x11 indicates IVA2 DPLL is low power stop mode.

Can any one please provide your inputs on the above error? I tried reconfiguring the CM_CLKEN_PLL_IVA2 to lock mode but still I am seeing the same messages as above while enabling iva2 clock.

Are you suspending into retention or off-mode?

I am suspending into Off mode.

Quoted 9 lines
Quoted 4 lines

Do you see this problem when only going into retention?

If not, sounds like we're missing some registers being saved/restored across off-mode.

I am seeing this issue only with OFF mode , retention works fine for me, yeah, looks like some registers are not restored properly across off mode. please let me know your inputs on this.

I have just updated the PM branch with a fix from Jouni to save/restore CM_CLKSEL1_PLL_IVA2.

Can you try the latest PM branch?

Thanks,

Kevin

Signature · 2 lines
Thanks
Ramesh Gupta G
#12 lore raw

Kevin,
I pulled git kernel today but still I am not seeing this patch in pm branch, looks like this patch is missing in the pm branch. Can you please recheck the same?

thanks
Ramesh Gupta G

Quoted 73 lines · Ramesh Gupta Guntha

Kevin,
I applied the patch maually at my end and tested, this works fine for me. anyway I will try with pm branch .

thanks
Ramesh Gupta G

Quoted 51 lines · Kevin Hilman
Quoted 39 lines · Ramesh Gupta Guntha

Hi Kevin,

Quoted 35 lines · Kevin Hilman
Quoted 32 lines · Ramesh Gupta Guntha

Kevin,

Quoted 17 lines · Kevin Hilman
Quoted 15 lines · Ramesh Gupta Guntha

Hi,

I am able to resolve all other issues with this pm branch except one issue,

I am not able to enable the iva2 clock once system is suspended and resumed, I am getting below messages.

Quoted 5 lines

<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'
<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'

Once after booting ( without adding bridgedriver/ installing bridgedriver) CM_CLKEN_PLL_IVA2 value shows as 0x37 indicates IVA2 DPLL in locked mode.

Quoted 8 lines
Quoted 6 lines

once after system suspend the value is not restored I am seeing that as
0x11 indicates IVA2 DPLL is low power stop mode.

Can any one please provide your inputs on the above error? I tried reconfiguring the CM_CLKEN_PLL_IVA2 to lock mode but still I am seeing the same messages as above while enabling iva2 clock.

Are you suspending into retention or off-mode?

I am suspending into Off mode.

Quoted 9 lines
Quoted 4 lines

Do you see this problem when only going into retention?

If not, sounds like we're missing some registers being saved/restored across off-mode.

I am seeing this issue only with OFF mode , retention works fine for me, yeah, looks like some registers are not restored properly across off mode. please let me know your inputs on this.

Quoted 9 lines

I have just updated the PM branch with a fix from Jouni to save/restore CM_CLKSEL1_PLL_IVA2.

Can you try the latest PM branch?

Thanks,

Kevin

--
Thanks
Ramesh Gupta G

Signature · 2 lines
Thanks
Ramesh Gupta G
#13 lore raw
Quoted 4 lines · Ramesh Gupta Guntha

Kevin,
I pulled git kernel today but still I am not seeing this patch in pm branch, looks like this patch is missing in the pm branch. Can you please recheck the same?

Hi Ramesh,

It looks like Tony's tree is not sync'ing with my PM branch anymore. I will check with Tony.

In the mean-time, you could try to pull directly from my git repo[1]

Kevin

[1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git

Quoted 81 lines · Ramesh Gupta Guntha
Quoted 73 lines

Kevin,
I applied the patch maually at my end and tested, this works fine for me. anyway I will try with pm branch .

thanks
Ramesh Gupta G

Quoted 51 lines · Kevin Hilman
Quoted 39 lines · Ramesh Gupta Guntha

Hi Kevin,

Quoted 35 lines · Kevin Hilman
Quoted 32 lines · Ramesh Gupta Guntha

Kevin,

Quoted 17 lines · Kevin Hilman
Quoted 15 lines · Ramesh Gupta Guntha

Hi,

I am able to resolve all other issues with this pm branch except one issue,

I am not able to enable the iva2 clock once system is suspended and resumed, I am getting below messages.

Quoted 5 lines

<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'
<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'

Once after booting ( without adding bridgedriver/ installing bridgedriver) CM_CLKEN_PLL_IVA2 value shows as 0x37 indicates IVA2 DPLL in locked mode.

Quoted 8 lines
Quoted 6 lines

once after system suspend the value is not restored I am seeing that as
0x11 indicates IVA2 DPLL is low power stop mode.

Can any one please provide your inputs on the above error? I tried reconfiguring the CM_CLKEN_PLL_IVA2 to lock mode but still I am seeing the same messages as above while enabling iva2 clock.

Are you suspending into retention or off-mode?

I am suspending into Off mode.

Quoted 9 lines
Quoted 4 lines

Do you see this problem when only going into retention?

If not, sounds like we're missing some registers being saved/restored across off-mode.

I am seeing this issue only with OFF mode , retention works fine for me, yeah, looks like some registers are not restored properly across off mode. please let me know your inputs on this.

Quoted 9 lines

I have just updated the PM branch with a fix from Jouni to save/restore CM_CLKSEL1_PLL_IVA2.

Can you try the latest PM branch?

Thanks,

Kevin

--
Thanks
Ramesh Gupta G

Signature · 2 lines
Thanks
Ramesh Gupta G
maintainer
#14 lore raw
Quoted 11 lines · Kevin Hilman
Quoted 4 lines · Ramesh Gupta Guntha

Kevin,
I pulled git kernel today but still I am not seeing this patch in pm branch, looks like this patch is missing in the pm branch. Can you please recheck the same?

Hi Ramesh,

It looks like Tony's tree is not sync'ing with my PM branch anymore. I will check with Tony.

Is there still a problem? I have not changed anything on that for few weeks.

Regards,

Tony

Quoted 5 lines

In the mean-time, you could try to pull directly from my git repo[1]

Kevin

[1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git

<snip>

#15 lore raw

Hi Tony,

Quoted 8 lines · Tony Lindgren
Quoted 7 lines · Kevin Hilman
Quoted 4 lines · Ramesh Gupta Guntha

Kevin,
I pulled git kernel today but still I am not seeing this patch in pm branch, looks like this patch is missing in the pm branch. Can you please recheck the same?

Quoted 7 lines
Quoted 4 lines

Hi Ramesh,

It looks like Tony's tree is not sync'ing with my PM branch anymore. I will check with Tony.

Is there still a problem? I have not changed anything on that for few weeks.

I didn't try from your tree today, When I checked it 2 days back those patches were not synced. I will try and let you know.

Regards
Ramesh Gupta G

#16 lore raw

Hi Tony,

Quoted 18 lines · Ramesh Gupta Guntha

Hi Tony,

Quoted 15 lines · Tony Lindgren
Quoted 11 lines · Kevin Hilman
Quoted 4 lines · Ramesh Gupta Guntha

Kevin,
I pulled git kernel today but still I am not seeing this patch in pm branch, looks like this patch is missing in the pm branch. Can you please recheck the same?

Hi Ramesh,

It looks like Tony's tree is not sync'ing with my PM branch anymore. I will check with Tony.

Is there still a problem? I have not changed anything on that for few weeks.

Now I am seeing this patch in pm branch.

regards
Ramesh Gupta G