Skip to contentSkip to conversation

2.6.11 breaks modules gratuitously

DISCUSSION Greg Stark 2 participants 2 messages Mar 18, 2005

lore
Share & tools
lore

Greg Stark

author
#0 lore raw

When you guys go on these "make needlessly global code static" kicks you should maybe consider that even functions that aren't currently used by any other area of the tree might be useful for module writers.

Instead of just checking which functions are currently used by other parts of the kernel perhaps you should think about what makes a logical API and stick to that, even if not all of the functions are currently used.

In the case of net/core/datagram.c, why make skb_copy_datagram private but leave skb_copy_datagram_iovec global? If the latter is a useful public function why not the former?

In particular vmware used skb_copy_datagram. So 2.6.11 broke vmware for no good reason.

<[email protected]>
[NET]: misc cleanups

The patch below contains the following cleanups:
- make needlessly global code static
- remove the following unused global functions:
- datagram.c: skb_copy_datagram
- iovec.c: memcpy_tokerneliovec
- remove the following unneeded EXPORT_SYMBOL's:
- datagram.c: skb_copy_datagram
- dev.c: ing_filter
- iovec.c: memcpy_tokerneliovec
- netpoll.c: netpoll_send_skb
- rtnetlink.c: rtnetlink_dump_ifinfo
- sock.c: sock_alloc_send_pskb

Signature · 1 line
greg
#1 lore raw
Quoted 2 lines · Greg Stark

In particular vmware used skb_copy_datagram. So 2.6.11 broke vmware for no good reason.

I don't know about the validity or otherwise of (un)exporting skb_copy_datagram but for what it's worth
http://ftp.cvut.cz/vmware/vmware-any-any-update89.tar.gz has been updated to work with 2.6.11.

Ian.

Signature · 4 lines
Ian Campbell
Current Noise: Entombed - Out of Heaven

Santa Claus is watching!