Skip to contentSkip to conversation

QUATECH driver (was Free Linux Driver Development!)

PATCH In review Sergei Organov 2 participants 3 messages Feb 1, 2007 – Feb 2, 2007 Pcmcia

lore
Share & tools
lore
#0 lore raw
Quoted 6 lines · Alan
Quoted 3 lines

3. Vendor driver is rather close to the generic one being in the kernel, so maybe it's better to improve generic one instead of adding yet another driver to the tree.

Firstly can you post a patch which adds the relevant identifiers to the current pcmcia serial driver so that 115,200 works but nothing higher.

OK, I'll try to recover what I did (as I've dropped the change after I saw it can't do 460,800), and submit the patch.

Quoted 2 lines

After that I'd like to take a look at the needed changes for higher speed support using the 2.6.20-mm work which adds arbitary speed support.

I expect it'll be rather hard for me to test the changes then, as my IBM ThinkPad T43 suffers from kernel IDE/SATA/PATA issues, and running every new kernel was a big pain so far (it currently runs 2.6.16.8) :(

-- Sergei.

#1 lore raw

PATCH 1/1 serial: Add PCMCIA IDs for Quatech DSP-100 dual RS232 adapter.

Add PCMCIA IDs for Quatech DSP-100 dual RS232 adapter.

---

drivers/serial/serial_cs.c +5 -0
index 431433f..5757442 100644
@@ -249,6 +249,10 @@ static const struct serial_quirk quirks[] = {
 		.multi	= 2,
 	}, {
 		.manfid	= MANFID_QUATECH,
+		.prodid	= PRODID_QUATECH_DUAL_RS232_G,
+		.multi	= 2,
+	}, {
+		.manfid	= MANFID_QUATECH,
 		.prodid	= PRODID_QUATECH_QUAD_RS232,
 		.multi	= 4,
 	}, {
@@ -893,6 +897,7 @@ static struct pcmcia_device_id serial_ids[] = {
 	PCMCIA_DEVICE_PROD_ID12("OEM      ", "C288MX     ", 0xb572d360, 0xd2385b7a),
 	PCMCIA_DEVICE_PROD_ID12("PCMCIA   ", "C336MX     ", 0x99bcafe9, 0xaa25bcab),
 	PCMCIA_DEVICE_PROD_ID12("Quatech Inc", "PCMCIA Dual RS-232 Serial Port Card", 0xc4420b35, 0x92abc92f),
+	PCMCIA_DEVICE_PROD_ID12("Quatech Inc", "Dual RS-232 Serial Port PC Card", 0xc4420b35, 0x031a380d),
 	PCMCIA_PFC_DEVICE_CIS_PROD_ID12(1, "PCMCIA", "EN2218-LAN/MODEM", 0x281f1c5d, 0x570f348e, "PCMLM28.cis"),
 	PCMCIA_PFC_DEVICE_CIS_PROD_ID12(1, "PCMCIA", "UE2218-LAN/MODEM", 0x281f1c5d, 0x6fdcacee, "PCMLM28.cis"),
 	PCMCIA_PFC_DEVICE_CIS_PROD_ID12(1, "Psion Dacom", "Gold Card V34 Ethernet", 0xf5f025c2, 0x338e8155, "PCMLM28.cis"),
include/pcmcia/ciscode.h +1 -0
index c1da855..eae7e2e 100644
@@ -95,6 +95,7 @@
 #define PRODID_QUATECH_DUAL_RS232	0x0012
 #define PRODID_QUATECH_DUAL_RS232_D1	0x0007
 #define PRODID_QUATECH_DUAL_RS232_D2	0x0052
+#define PRODID_QUATECH_DUAL_RS232_G	0x004d
 #define PRODID_QUATECH_QUAD_RS232	0x001b
 #define PRODID_QUATECH_DUAL_RS422	0x000e
 #define PRODID_QUATECH_QUAD_RS422	0x0045