Make 'xm save' sanity check the path
PATCH 1/1 Make 'xm save' sanity check the path
This patch adds a quick check in "xm save" to make sure the path given exists, and is writable.
This will fix the issue detected by xm-test 03_save_bogusfile_neg.
Signed-off-by Dan Smith <[email protected]>
tools/python/xen/xm/main.py +4 -0
@@ -175,6 +175,10 @@ dom = args[0] # TODO: should check if this exists savefile = os.path.abspath(args[1]) + + if not os.access(os.path.dirname(savefile), os.W_OK): + err("xm save: Unable to create file %s" % savefile) + sys.exit(1) from xen.xend.XendClient import server server.xend_domain_save(dom, savefile)
Signature · 4 lines
Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [email protected]
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
Ewan Mellor
AppliedQuoted 6 lines · Dan Smith
This patch adds a quick check in "xm save" to make sure the path given exists, and is writable.
This will fix the issue detected by xm-test 03_save_bogusfile_neg.
Signed-off-by Dan Smith <[email protected]>
Applied, thanks.
Ewan.