Skip to contentSkip to conversation

[email protected]

PATCH Christer Weinigel 1 participant 1 message Nov 22, 2002 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

Hi,

Chris Wilson found and fixed a few bugs in the failure paths of the scx200_wdt driver that I'm the maintainer for. Could you please apply this patch that fixes these.

/Christer

drivers/char/scx200_wdt.c +6 -1
@@ -240,23 +240,28 @@
 	}
 
 	scx200_wdt_update_margin();
 	scx200_wdt_disable();
 
 	sema_init(&open_semaphore, 1);
 
 	r = misc_register(&scx200_wdt_miscdev);
-	if (r)
+	if (r) {
+		release_region(SCx200_CB_BASE + SCx200_WDT_OFFSET,
+				SCx200_WDT_SIZE);
 		return r;
+	}
 
 	r = register_reboot_notifier(&scx200_wdt_notifier);
         if (r) {
                 printk(KERN_ERR NAME ": unable to register reboot notifier");
 		misc_deregister(&scx200_wdt_miscdev);
+		release_region(SCx200_CB_BASE + SCx200_WDT_OFFSET,
+				SCx200_WDT_SIZE);
                 return r;
         }
 
 	return 0;
 }
 
 static void __exit scx200_wdt_cleanup(void)
 {
Signature · 5 lines
-- 
"Just how much can I get away with and still go to heaven?"

Freelance consultant specializing in device driver programming for Linux 
Christer Weinigel <[email protected]>  http://www.weinigel.se