Skip to contentSkip to conversation

DocG3 patch

DISCUSSION Robert Jarzmik 2 participants 3 messages Sep 18, 2011 – Sep 19, 2011 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

Hello Artem,

It's been 2 months, and I had no news.
The DocG3 driver was submitted and not reviewed in [1] and [2].

Could you merge the patch into your tree please (patch in [2]) ?

Cheers.

Signature · 4 lines
Robert

[1] http://comments.gmane.org/gmane.linux.drivers.mtd/35284
[2] http://comments.gmane.org/gmane.linux.drivers.mtd/36146
#1 lore raw
Quoted 6 lines · Robert Jarzmik

Hello Artem,

It's been 2 months, and I had no news.
The DocG3 driver was submitted and not reviewed in [1] and [2].

Could you merge the patch into your tree please (patch in [2]) ?

Oh, I missed your v2 completely.

The problem I see with this driver is that it uses sysfs interfaces for debugging purposes. You should not do this - we have debugfs for stuff like that. I suggest you to just kill sysfs interfaces and re-send your patch. You can later add debugfs interfaces instead.

Signature · 2 lines
Best Regards,
Artem Bityutskiy
#2 lore raw
Quoted 6 lines · Artem Bityutskiy
Quoted 5 lines · Robert Jarzmik

Hello Artem,

It's been 2 months, and I had no news.
The DocG3 driver was submitted and not reviewed in [1] and [2].

Quoted 8 lines
Quoted 1 line

Could you merge the patch into your tree please (patch in [2]) ?

Oh, I missed your v2 completely.

The problem I see with this driver is that it uses sysfs interfaces for debugging purposes. You should not do this - we have debugfs for stuff like that. I suggest you to just kill sysfs interfaces and re-send your patch. You can later add debugfs interfaces instead.

Converted sysfs -> debufs, and resent in V3.

Cheers.

Signature · 1 line
Robert