Skip to contentSkip to conversation

Remove superfluous error check

PATCH In review Giuseppe Scrivano 2 participants 2 messages Sep 8, 2009 – Sep 10, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove superfluous error check

Quoted 1 line

From 0be5c84f21c8b163ed81b7e38f87e8d7a807b975 Mon Sep 17 00:00:00 2001

From: Giuseppe Scrivano <[email protected]>
Date: Tue, 8 Sep 2009 23:40:03 +0200
Subject: [PATCH] Remove superfluous return code check

---
 fs/notify/inotify/inotify_user.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
fs/notify/inotify/inotify_user.c +0 -2
index dcd2040..d8135e5 100644
@@ -747,8 +747,6 @@ SYSCALL_DEFINE3(inotify_add_watch, int, fd, const char __user *, pathname,
 
 	/* create/update an inode mark */
 	ret = inotify_update_watch(group, inode, mask);
-	if (unlikely(ret))
-		goto path_put_and_out;
 
 path_put_and_out:
 	path_put(&path);
Signature · 1 line
1.6.3.3
#1 lore raw
Quoted 4 lines · Giuseppe Scrivano

From 0be5c84f21c8b163ed81b7e38f87e8d7a807b975 Mon Sep 17 00:00:00 2001
From: Giuseppe Scrivano <[email protected]>
Date: Tue, 8 Sep 2009 23:40:03 +0200
Subject: [PATCH] Remove superfluous return code check

Thanks, I'll add it to my -next tree.

-Eric

Quoted 15 lines

---
 fs/notify/inotify/inotify_user.c |    2 --

 1 files changed, 0 insertions(+), 2 deletions(-)
fs/notify/inotify/inotify_user.c +0 -2
index dcd2040..d8135e5 100644
@@ -747,8 +747,6 @@ SYSCALL_DEFINE3(inotify_add_watch, int, fd, const char __user *, pathname,
 
        /* create/update an inode mark */
        ret = inotify_update_watch(group, inode, mask);
-       if (unlikely(ret))
-               goto path_put_and_out;
 
Quoted 7 lines

 path_put_and_out:
       path_put(&path);
--
1.6.3.3

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html