Skip to contentSkip to conversation

potential parse error, drivers/serial/dz.h

PATCH In review Yoann Padioleau 3 participants 3 messages Jul 16, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 potential parse error, drivers/serial/dz.h

potential parse error in declaration under a #ifdef.

drivers/serial/dz.h +2 -2
index 9674d4e..9141c37 100644
@@ -125,8 +125,8 @@ #define DZ_XMIT_SIZE   4096             
 #define DZ_WAKEUP_CHARS   DZ_XMIT_SIZE/4
 
 #ifdef MODULE
-int init_module (void)
-void cleanup_module (void)
+int init_module (void);
+void cleanup_module (void);
 #endif
 
 #endif /* DZ_SERIAL_H */
#1 lore raw
Quoted 2 lines · On Mon, 16 Jul 2007 17:02:13 +0200 Yoann Padioleau <[email protected]> wrote:

potential parse error in declaration under a #ifdef.

A certain parse error, I'd say. How come nobody is reporting it?

Quoted 8 lines
drivers/serial/dz.h +0 -0
index 9674d4e..9141c37 100644

drivers/serial/dz.h #define DZ_XMIT_SIZE 4096 · line 132

Quoted 10 lines
drivers/serial/dz.h +2 -2
@@ -125,8 +125,8 @@ #define DZ_XMIT_SIZE   4096             
 #define DZ_WAKEUP_CHARS   DZ_XMIT_SIZE/4
 
 #ifdef MODULE
-int init_module (void)
-void cleanup_module (void)
+int init_module (void);
+void cleanup_module (void);
 #endif
 
 #endif /* DZ_SERIAL_H */

I don't think these symbols are actually implemented in anything which uses this header. If they _do_ exist then they are awfully named and should be renamed ASAP. Or they should be made static.

However I suspect they just don't exist, and this stuff should be simply deleted.

#2 lore raw
Quoted 25 lines · Andrew Morton
Quoted 2 lines · On Mon, 16 Jul 2007 17:02:13 +0200 Yoann Padioleau <[email protected]> wrote:

potential parse error in declaration under a #ifdef.

A certain parse error, I'd say. How come nobody is reporting it?

Quoted 17 lines
drivers/serial/dz.h +2 -2
index 9674d4e..9141c37 100644
@@ -125,8 +125,8 @@ #define DZ_XMIT_SIZE   4096
 #define DZ_WAKEUP_CHARS   DZ_XMIT_SIZE/4
 
 #ifdef MODULE
-int init_module (void)
-void cleanup_module (void)
+int init_module (void);
+void cleanup_module (void);
 #endif
 
Quoted 8 lines

drivers/serial/dz.h #define DZ_XMIT_SIZE 4096 · line 132

Quoted 1 line
drivers/serial/dz.h +0 -0
 #endif /* DZ_SERIAL_H */

I don't think these symbols are actually implemented in anything which uses this header. If they _do_ exist then they are awfully named and should be renamed ASAP. Or they should be made static.

However I suspect they just don't exist, and this stuff should be simply deleted.

that header file is included only by drivers/serial/dz.c, whose Kconfig controlling setting is:

config SERIAL_DZ
bool "DECstation DZ serial driver"
...

so, since it's "bool," there's no way "#ifdef MODULE" can ever be true, yes?

rday

Signature · 7 lines
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================