Skip to contentSkip to conversation

invalid user 123456-fsgqa

DISCUSSION Aurélien Aptel 3 participants 3 messages Jun 4, 2020 – Jun 8, 2020

lore
Share & tools
lore
#0 lore raw

Hi,

Some tests require a second user named 123456-fsgqa (generic/{381,383,597,598}) but that username is invalid on some Linux systems (SUSE distros at least) where a username cannot start with a digit.

Would it be ok to send a patch to change that second user to "fsgqa2"?

Cheers,

Signature · 4 lines
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
#1 lore raw
Quoted 8 lines · Aurélien Aptel

Hi,

Some tests require a second user named 123456-fsgqa (generic/{381,383,597,598}) but that username is invalid on some Linux systems (SUSE distros at least) where a username cannot start with a digit.

Would it be ok to send a patch to change that second user to "fsgqa2"?

Does it break generic/381 or generic/383? Those look like regression tests for broken behavior when usernames start with digits.

This sounds more like something to _notrun the test from a _require* check.

--D

Quoted 6 lines

Cheers,

Signature · 4 lines
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
#2 lore raw
In reply to Aurélien Aptel
Quoted 8 lines · Aurélien Aptel

Hi,

Some tests require a second user named 123456-fsgqa (generic/{381,383,597,598}) but that username is invalid on some Linux systems (SUSE distros at least) where a username cannot start with a digit.

Would it be ok to send a patch to change that second user to "fsgqa2"?

No.

For g/381 and g/383, the 123456-fsgqa is necessary, they test xfs_quota with user/group name beginning with digits, they're known bug coverage. If you system can't create a user name likes 123456-fsgqa, just skip that. I think if your system doesn't have 123456-fsgqa, the g/381 and g/383 will _notrun automatically, right?

I don't learn about g/597,598(Eric might know that), if some other cases just need another user name, you can have fsgqa2 or anyother names. But please update README, if you change that.

Thanks,
Zorro

Quoted 8 lines

Cheers,

Signature · 4 lines
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)