Skip to contentSkip to conversation

ARM: mvebu: fix ReadyNAS 102 Power button GPIO to make it active high

PATCH New Arnaud Ebalard 2 participants 2 messages Sep 29, 2013 – Sep 30, 2013 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: mvebu: fix ReadyNAS 102 Power button GPIO to make it active high

NETGEAR ReadyNAS 102 Power button definition in .dts file flags associated GPIO active low instead of active high. This results in reversed events reported by input subsystem (0 returned when the button is pressed, 1 when released). This patch makes associated GPIO active high to recover correct behaviour.

---
RN102 .dts file sits in Linus tree only since 3.12-rc1 so I guess no one has currently relied on current reversed behaviour, i.e. this can be fixed w/o impact on any userspace program. As a side note, the initial error is mine.

 arch/arm/boot/dts/armada-370-netgear-rn102.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/armada-370-netgear-rn102.dts +1 -1
index 05e4485..396949d 100644
@@ -160,7 +160,7 @@
 		button at 1 {
 			label = "Power Button";
 			linux,code = <116>;     /* KEY_POWER */
-			gpios = <&gpio1 30 1>;
+			gpios = <&gpio1 30 0>;
 		};
 
 		button at 2 {
Signature · 1 line
1.8.4.rc3
Applied
#1 lore raw

PATCH 1/1 ARM: mvebu: fix ReadyNAS 102 Power button GPIO to make it active high

Quoted 8 lines · Arnaud Ebalard

NETGEAR ReadyNAS 102 Power button definition in .dts file flags associated GPIO active low instead of active high. This results in reversed events reported by input subsystem (0 returned when the button is pressed, 1 when released). This patch makes associated GPIO active high to recover correct behaviour.

Quoted 8 lines

---
RN102 .dts file sits in Linus tree only since 3.12-rc1 so I guess no one has currently relied on current reversed behaviour, i.e. this can be fixed w/o impact on any userspace program. As a side note, the initial error is mine.

 arch/arm/boot/dts/armada-370-netgear-rn102.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to mvebu/fixes

thx,

Jason.