Skip to contentSkip to conversation

envtools with tools-only_defconfig fails to build after v2019.10-rc1

U-Boot Vagrant Cascadian 4 participants 9 messages Sep 24, 2019

lore
Share & tools
lore

Vagrant Cascadian

author Acked-by Joe Hershberger
#0 lore raw

I've been unable to successfully run "make envtools" on recent versions of u-boot, and finally got a chance to git bisect it.

It looks like commit 9fb625ce05539fe6876a59ce1dcadb76b33c6f6e, introduced after 2019.10-rc1, breaks building envtools:

#!/bin/sh

# test-bisect
set -e
set -x
make clean
make tools-only_defconfig
make NO_SDL=1 envtools

....
Bisecting: 8 revisions left to test after this (roughly 3 steps) [9fb625ce05539fe6876a59ce1dcadb76b33c6f6e] env: Move env_set() to env.h running ../test-bisect
+ make clean
CLEAN u-boot.cfg
+ make tools-only_defconfig

  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/kconfig/conf.o
  YACC    scripts/kconfig/zconf.tab.c
  LEX     scripts/kconfig/zconf.lex.c
  HOSTCC  scripts/kconfig/zconf.tab.o
  HOSTLD  scripts/kconfig/conf
#
# configuration written to .config
#
+ make NO_SDL=1 envtools
scripts/kconfig/conf  --syncconfig Kconfig
  CHK     include/config.h
  CFG     u-boot.cfg
  GEN     include/autoconf.mk
  GEN     include/autoconf.mk.dep
  CHK     include/config/uboot.release
  UPD     include/config/uboot.release
  CHK     include/generated/version_autogenerated.h
  UPD     include/generated/version_autogenerated.h
  CHK     include/generated/timestamp_autogenerated.h
  UPD     include/generated/timestamp_autogenerated.h
  LD      tools/env/built-in.o
  HOSTCC  tools/env/crc32.o
  HOSTCC  tools/env/ctype.o
  HOSTCC  tools/env/env_attr.o
  HOSTCC  tools/env/env_flags.o
In file included from tools/env/../../env/flags.c:7,
                 from tools/env/env_flags.c:1:
include/env.h:97:1: error: unknown type name 'ulong'; did you mean
'long'?
   97 | ulong env_get_ulong(const char *name, int base, ulong
   default_val);
      | ^~~~~
      | long
include/env.h:97:49: error: unknown type name 'ulong'; did you mean
'long'?
   97 | ulong env_get_ulong(const char *name, int base, ulong
   default_val);
      |                                                 ^~~~~
      |                                                 long
include/env.h:106:40: error: unknown type name 'ulong'; did you mean
'long'?
  106 | int env_set_ulong(const char *varname, ulong value);
      |                                        ^~~~~
      |                                        long
include/env.h:118:1: error: unknown type name 'ulong'; did you mean
'long'?
  118 | ulong env_get_hex(const char *varname, ulong default_val);
      | ^~~~~
      | long
include/env.h:118:40: error: unknown type name 'ulong'; did you mean
'long'?
  118 | ulong env_get_hex(const char *varname, ulong default_val);
      |                                        ^~~~~
      |                                        long
include/env.h:127:38: error: unknown type name 'ulong'; did you mean
'long'?
  127 | int env_set_hex(const char *varname, ulong value);
      |                                      ^~~~~
      |                                      long
include/env.h: In function 'env_set_addr':
include/env.h:138:31: error: 'ulong' undeclared (first use in this
function)
  138 |  return env_set_hex(varname, (ulong)addr);
      |                               ^~~~~
include/env.h:138:31: note: each undeclared identifier is reported only
once for each function it appears in
include/env.h:138:37: error: expected ')' before 'addr'
  138 |  return env_set_hex(varname, (ulong)addr);
      |                                     ^~~~
      |                                     )
make[1]: *** [scripts/Makefile.host:114: tools/env/env_flags.o] Error 1
make: *** [Makefile:1778: envtools] Error 2
Bisecting: 3 revisions left to test after this (roughly 2 steps)
...
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[cdbff9fc4002fdd47181088d5abe90e5f2fa1904] env: Move env_get_hex() to
...
9fb625ce05539fe6876a59ce1dcadb76b33c6f6e is the first bad commit
commit 9fb625ce05539fe6876a59ce1dcadb76b33c6f6e
Author: Simon Glass <[email protected]>
Date:   Thu Aug 1 09:46:51 2019 -0600

env: Move env_set() to env.h

Move env_set() over to the new header file.

Would be great to get this building again before 2019.10 release!

live well,
vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190923/6cdc517a/attachment.sig>

#1 lore raw

Hi Vagrant,

Le 24/09/2019 à 04:04, Vagrant Cascadian a écrit :

Quoted 106 lines

I've been unable to successfully run "make envtools" on recent versions of u-boot, and finally got a chance to git bisect it.

It looks like commit 9fb625ce05539fe6876a59ce1dcadb76b33c6f6e, introduced after 2019.10-rc1, breaks building envtools:

#!/bin/sh

# test-bisect
set -e
set -x
make clean
make tools-only_defconfig
make NO_SDL=1 envtools

....
Bisecting: 8 revisions left to test after this (roughly 3 steps) [9fb625ce05539fe6876a59ce1dcadb76b33c6f6e] env: Move env_set() to env.h running ../test-bisect
+ make clean
CLEAN u-boot.cfg
+ make tools-only_defconfig

   HOSTCC  scripts/basic/fixdep
   HOSTCC  scripts/kconfig/conf.o
   YACC    scripts/kconfig/zconf.tab.c
   LEX     scripts/kconfig/zconf.lex.c
   HOSTCC  scripts/kconfig/zconf.tab.o
   HOSTLD  scripts/kconfig/conf
#
# configuration written to .config
#
+ make NO_SDL=1 envtools
scripts/kconfig/conf  --syncconfig Kconfig
   CHK     include/config.h
   CFG     u-boot.cfg
   GEN     include/autoconf.mk
   GEN     include/autoconf.mk.dep
   CHK     include/config/uboot.release
   UPD     include/config/uboot.release
   CHK     include/generated/version_autogenerated.h
   UPD     include/generated/version_autogenerated.h
   CHK     include/generated/timestamp_autogenerated.h
   UPD     include/generated/timestamp_autogenerated.h
   LD      tools/env/built-in.o
   HOSTCC  tools/env/crc32.o
   HOSTCC  tools/env/ctype.o
   HOSTCC  tools/env/env_attr.o
   HOSTCC  tools/env/env_flags.o
In file included from tools/env/../../env/flags.c:7,
                  from tools/env/env_flags.c:1:
include/env.h:97:1: error: unknown type name 'ulong'; did you mean
'long'?
    97 | ulong env_get_ulong(const char *name, int base, ulong
    default_val);
       | ^~~~~
       | long
include/env.h:97:49: error: unknown type name 'ulong'; did you mean
'long'?
    97 | ulong env_get_ulong(const char *name, int base, ulong
    default_val);
       |                                                 ^~~~~
       |                                                 long
include/env.h:106:40: error: unknown type name 'ulong'; did you mean
'long'?
   106 | int env_set_ulong(const char *varname, ulong value);
       |                                        ^~~~~
       |                                        long
include/env.h:118:1: error: unknown type name 'ulong'; did you mean
'long'?
   118 | ulong env_get_hex(const char *varname, ulong default_val);
       | ^~~~~
       | long
include/env.h:118:40: error: unknown type name 'ulong'; did you mean
'long'?
   118 | ulong env_get_hex(const char *varname, ulong default_val);
       |                                        ^~~~~
       |                                        long
include/env.h:127:38: error: unknown type name 'ulong'; did you mean
'long'?
   127 | int env_set_hex(const char *varname, ulong value);
       |                                      ^~~~~
       |                                      long
include/env.h: In function 'env_set_addr':
include/env.h:138:31: error: 'ulong' undeclared (first use in this
function)
   138 |  return env_set_hex(varname, (ulong)addr);
       |                               ^~~~~
include/env.h:138:31: note: each undeclared identifier is reported only
once for each function it appears in
include/env.h:138:37: error: expected ')' before 'addr'
   138 |  return env_set_hex(varname, (ulong)addr);
       |                                     ^~~~
       |                                     )
make[1]: *** [scripts/Makefile.host:114: tools/env/env_flags.o] Error 1
make: *** [Makefile:1778: envtools] Error 2
Bisecting: 3 revisions left to test after this (roughly 2 steps)
...
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[cdbff9fc4002fdd47181088d5abe90e5f2fa1904] env: Move env_get_hex() to
...
9fb625ce05539fe6876a59ce1dcadb76b33c6f6e is the first bad commit
commit 9fb625ce05539fe6876a59ce1dcadb76b33c6f6e
Author: Simon Glass <[email protected]>
Date:   Thu Aug 1 09:46:51 2019 -0600

env: Move env_set() to env.h

Quoted 7 lines

Move env_set() over to the new header file.

Would be great to get this building again before 2019.10 release!

I sent the following series to fix this build issue:
- http://patchwork.ozlabs.org/project/uboot/list/?series=127297

Hope it will be merged soon.

Thanks!

Pierre-Jean

Quoted 11 lines

live well,
vagrant

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

Signature · 3 lines
Pierre-Jean Texier
Embedded Linux Engineer
https://koncepto.io
#2 lore raw
Quoted 115 lines · Pierre-Jean Texier

Hi Vagrant,

Le 24/09/2019 à 04:04, Vagrant Cascadian a écrit :

Quoted 112 lines

I've been unable to successfully run "make envtools" on recent versions of u-boot, and finally got a chance to git bisect it.

It looks like commit 9fb625ce05539fe6876a59ce1dcadb76b33c6f6e, introduced after 2019.10-rc1, breaks building envtools:

#!/bin/sh

# test-bisect
set -e
set -x
make clean
make tools-only_defconfig
make NO_SDL=1 envtools

....
Bisecting: 8 revisions left to test after this (roughly 3 steps) [9fb625ce05539fe6876a59ce1dcadb76b33c6f6e] env: Move env_set() to env.h running ../test-bisect
+ make clean
CLEAN u-boot.cfg
+ make tools-only_defconfig

  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/kconfig/conf.o
  YACC    scripts/kconfig/zconf.tab.c
  LEX     scripts/kconfig/zconf.lex.c
  HOSTCC  scripts/kconfig/zconf.tab.o
  HOSTLD  scripts/kconfig/conf
#
# configuration written to .config
#
+ make NO_SDL=1 envtools
scripts/kconfig/conf  --syncconfig Kconfig
  CHK     include/config.h
  CFG     u-boot.cfg
  GEN     include/autoconf.mk
  GEN     include/autoconf.mk.dep
  CHK     include/config/uboot.release
  UPD     include/config/uboot.release
  CHK     include/generated/version_autogenerated.h
  UPD     include/generated/version_autogenerated.h
  CHK     include/generated/timestamp_autogenerated.h
  UPD     include/generated/timestamp_autogenerated.h
  LD      tools/env/built-in.o
  HOSTCC  tools/env/crc32.o
  HOSTCC  tools/env/ctype.o
  HOSTCC  tools/env/env_attr.o
  HOSTCC  tools/env/env_flags.o
In file included from tools/env/../../env/flags.c:7,
                 from tools/env/env_flags.c:1:
include/env.h:97:1: error: unknown type name 'ulong'; did you mean
'long'?
   97 | ulong env_get_ulong(const char *name, int base, ulong
   default_val);
      | ^~~~~
      | long
include/env.h:97:49: error: unknown type name 'ulong'; did you mean
'long'?
   97 | ulong env_get_ulong(const char *name, int base, ulong
   default_val);
      |                                                 ^~~~~
      |                                                 long
include/env.h:106:40: error: unknown type name 'ulong'; did you mean
'long'?
  106 | int env_set_ulong(const char *varname, ulong value);
      |                                        ^~~~~
      |                                        long
include/env.h:118:1: error: unknown type name 'ulong'; did you mean
'long'?
  118 | ulong env_get_hex(const char *varname, ulong default_val);
      | ^~~~~
      | long
include/env.h:118:40: error: unknown type name 'ulong'; did you mean
'long'?
  118 | ulong env_get_hex(const char *varname, ulong default_val);
      |                                        ^~~~~
      |                                        long
include/env.h:127:38: error: unknown type name 'ulong'; did you mean
'long'?
  127 | int env_set_hex(const char *varname, ulong value);
      |                                      ^~~~~
      |                                      long
include/env.h: In function 'env_set_addr':
include/env.h:138:31: error: 'ulong' undeclared (first use in this
function)
  138 |  return env_set_hex(varname, (ulong)addr);
      |                               ^~~~~
include/env.h:138:31: note: each undeclared identifier is reported only
once for each function it appears in
include/env.h:138:37: error: expected ')' before 'addr'
  138 |  return env_set_hex(varname, (ulong)addr);
      |                                     ^~~~
      |                                     )
make[1]: *** [scripts/Makefile.host:114: tools/env/env_flags.o] Error 1
make: *** [Makefile:1778: envtools] Error 2
Bisecting: 3 revisions left to test after this (roughly 2 steps)
...
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[cdbff9fc4002fdd47181088d5abe90e5f2fa1904] env: Move env_get_hex() to
...
9fb625ce05539fe6876a59ce1dcadb76b33c6f6e is the first bad commit
commit 9fb625ce05539fe6876a59ce1dcadb76b33c6f6e
Author: Simon Glass <[email protected]>
Date:   Thu Aug 1 09:46:51 2019 -0600

env: Move env_set() to env.h

Move env_set() over to the new header file.

Quoted 6 lines
Quoted 1 line

Would be great to get this building again before 2019.10 release!

I sent the following series to fix this build issue:
- http://patchwork.ozlabs.org/project/uboot/list/?series=127297

Hope it will be merged soon.

Looks like we also need to change travis/gitlab to building "tools-all" not "tools-only". Can someone send a patch please? And Joe, are you happy with those env changes? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190924/2671903f/attachment.sig>
#3 lore raw

Hi Tom,

Le 24/09/2019 à 21:52, Tom Rini a écrit :

Quoted 1 line

Looks like we also need to change travis/gitlab to building "tools-al

Already in the series [1].
In fact, I added a step for building "envtools" with the command:
$: make tools-only_config envtools

I preferred not to use "tools-all" in order to have a better visualization on Travis and Gitlab.

Also, It appears that Joe has already "Acked".

Thanks !

[1] - http://patchwork.ozlabs.org/patch/1153104/

Signature · 3 lines
Pierre-Jean Texier
Embedded Linux Engineer
https://koncepto.io
#5 lore raw
In reply to Tom Rini

Hi Tom,

Quoted 119 lines · Tom Rini
Quoted 117 lines · Pierre-Jean Texier

Hi Vagrant,

Quoted 113 lines · Vagrant Cascadian

I've been unable to successfully run "make envtools" on recent versions of u-boot, and finally got a chance to git bisect it.

It looks like commit 9fb625ce05539fe6876a59ce1dcadb76b33c6f6e, introduced after 2019.10-rc1, breaks building envtools:

#!/bin/sh

# test-bisect
set -e
set -x
make clean
make tools-only_defconfig
make NO_SDL=1 envtools

....
Bisecting: 8 revisions left to test after this (roughly 3 steps) [9fb625ce05539fe6876a59ce1dcadb76b33c6f6e] env: Move env_set() to env.h running ../test-bisect
+ make clean
CLEAN u-boot.cfg
+ make tools-only_defconfig

  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/kconfig/conf.o
  YACC    scripts/kconfig/zconf.tab.c
  LEX     scripts/kconfig/zconf.lex.c
  HOSTCC  scripts/kconfig/zconf.tab.o
  HOSTLD  scripts/kconfig/conf
#
# configuration written to .config
#
+ make NO_SDL=1 envtools
scripts/kconfig/conf  --syncconfig Kconfig
  CHK     include/config.h
  CFG     u-boot.cfg
  GEN     include/autoconf.mk
  GEN     include/autoconf.mk.dep
  CHK     include/config/uboot.release
  UPD     include/config/uboot.release
  CHK     include/generated/version_autogenerated.h
  UPD     include/generated/version_autogenerated.h
  CHK     include/generated/timestamp_autogenerated.h
  UPD     include/generated/timestamp_autogenerated.h
  LD      tools/env/built-in.o
  HOSTCC  tools/env/crc32.o
  HOSTCC  tools/env/ctype.o
  HOSTCC  tools/env/env_attr.o
  HOSTCC  tools/env/env_flags.o
In file included from tools/env/../../env/flags.c:7,
                 from tools/env/env_flags.c:1:
include/env.h:97:1: error: unknown type name 'ulong'; did you mean
'long'?
   97 | ulong env_get_ulong(const char *name, int base, ulong
   default_val);
      | ^~~~~
      | long
include/env.h:97:49: error: unknown type name 'ulong'; did you mean
'long'?
   97 | ulong env_get_ulong(const char *name, int base, ulong
   default_val);
      |                                                 ^~~~~
      |                                                 long
include/env.h:106:40: error: unknown type name 'ulong'; did you mean
'long'?
  106 | int env_set_ulong(const char *varname, ulong value);
      |                                        ^~~~~
      |                                        long
include/env.h:118:1: error: unknown type name 'ulong'; did you mean
'long'?
  118 | ulong env_get_hex(const char *varname, ulong default_val);
      | ^~~~~
      | long
include/env.h:118:40: error: unknown type name 'ulong'; did you mean
'long'?
  118 | ulong env_get_hex(const char *varname, ulong default_val);
      |                                        ^~~~~
      |                                        long
include/env.h:127:38: error: unknown type name 'ulong'; did you mean
'long'?
  127 | int env_set_hex(const char *varname, ulong value);
      |                                      ^~~~~
      |                                      long
include/env.h: In function 'env_set_addr':
include/env.h:138:31: error: 'ulong' undeclared (first use in this
function)
  138 |  return env_set_hex(varname, (ulong)addr);
      |                               ^~~~~
include/env.h:138:31: note: each undeclared identifier is reported only
once for each function it appears in
include/env.h:138:37: error: expected ')' before 'addr'
  138 |  return env_set_hex(varname, (ulong)addr);
      |                                     ^~~~
      |                                     )
make[1]: *** [scripts/Makefile.host:114: tools/env/env_flags.o] Error 1
make: *** [Makefile:1778: envtools] Error 2
Bisecting: 3 revisions left to test after this (roughly 2 steps)
...
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[cdbff9fc4002fdd47181088d5abe90e5f2fa1904] env: Move env_get_hex() to
...
9fb625ce05539fe6876a59ce1dcadb76b33c6f6e is the first bad commit
commit 9fb625ce05539fe6876a59ce1dcadb76b33c6f6e
Author: Simon Glass <[email protected]>
Date:   Thu Aug 1 09:46:51 2019 -0600

env: Move env_set() to env.h

Move env_set() over to the new header file.

Would be great to get this building again before 2019.10 release!

Quoted 8 lines
Quoted 4 lines

I sent the following series to fix this build issue:
- http://patchwork.ozlabs.org/project/uboot/list/?series=127297

Hope it will be merged soon.

Looks like we also need to change travis/gitlab to building "tools-all" not "tools-only". Can someone send a patch please? And Joe, are you happy with those env changes? Thanks!

Yes, I've acked those patches. I can pull them through the net tree if you like.

Let me know,
-Joe

#4 lore raw
In reply to Pierre-Jean Texier
Quoted 10 lines · Pierre-Jean Texier

Hi Tom,

Le 24/09/2019 à 21:52, Tom Rini a écrit :

Quoted 1 line

Looks like we also need to change travis/gitlab to building "tools-al

Already in the series [1].
In fact, I added a step for building "envtools" with the command:
$: make tools-only_config envtools

I preferred not to use "tools-all" in order to have a better visualization on Travis and Gitlab.

That's the same as 'tools-all', but OK. Lets just hope things don't get out of sync in the future.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190924/e149e1a0/attachment.sig>
#6 lore raw
In reply to Joe Hershberger
Quoted 125 lines · Joe Hershberger

Hi Tom,

Quoted 122 lines · Tom Rini
Quoted 120 lines · Pierre-Jean Texier

Hi Vagrant,

Quoted 106 lines · Vagrant Cascadian

I've been unable to successfully run "make envtools" on recent versions of u-boot, and finally got a chance to git bisect it.

It looks like commit 9fb625ce05539fe6876a59ce1dcadb76b33c6f6e, introduced after 2019.10-rc1, breaks building envtools:

#!/bin/sh

# test-bisect
set -e
set -x
make clean
make tools-only_defconfig
make NO_SDL=1 envtools

....
Bisecting: 8 revisions left to test after this (roughly 3 steps) [9fb625ce05539fe6876a59ce1dcadb76b33c6f6e] env: Move env_set() to env.h running ../test-bisect
+ make clean
CLEAN u-boot.cfg
+ make tools-only_defconfig

  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/kconfig/conf.o
  YACC    scripts/kconfig/zconf.tab.c
  LEX     scripts/kconfig/zconf.lex.c
  HOSTCC  scripts/kconfig/zconf.tab.o
  HOSTLD  scripts/kconfig/conf
#
# configuration written to .config
#
+ make NO_SDL=1 envtools
scripts/kconfig/conf  --syncconfig Kconfig
  CHK     include/config.h
  CFG     u-boot.cfg
  GEN     include/autoconf.mk
  GEN     include/autoconf.mk.dep
  CHK     include/config/uboot.release
  UPD     include/config/uboot.release
  CHK     include/generated/version_autogenerated.h
  UPD     include/generated/version_autogenerated.h
  CHK     include/generated/timestamp_autogenerated.h
  UPD     include/generated/timestamp_autogenerated.h
  LD      tools/env/built-in.o
  HOSTCC  tools/env/crc32.o
  HOSTCC  tools/env/ctype.o
  HOSTCC  tools/env/env_attr.o
  HOSTCC  tools/env/env_flags.o
In file included from tools/env/../../env/flags.c:7,
                 from tools/env/env_flags.c:1:
include/env.h:97:1: error: unknown type name 'ulong'; did you mean
'long'?
   97 | ulong env_get_ulong(const char *name, int base, ulong
   default_val);
      | ^~~~~
      | long
include/env.h:97:49: error: unknown type name 'ulong'; did you mean
'long'?
   97 | ulong env_get_ulong(const char *name, int base, ulong
   default_val);
      |                                                 ^~~~~
      |                                                 long
include/env.h:106:40: error: unknown type name 'ulong'; did you mean
'long'?
  106 | int env_set_ulong(const char *varname, ulong value);
      |                                        ^~~~~
      |                                        long
include/env.h:118:1: error: unknown type name 'ulong'; did you mean
'long'?
  118 | ulong env_get_hex(const char *varname, ulong default_val);
      | ^~~~~
      | long
include/env.h:118:40: error: unknown type name 'ulong'; did you mean
'long'?
  118 | ulong env_get_hex(const char *varname, ulong default_val);
      |                                        ^~~~~
      |                                        long
include/env.h:127:38: error: unknown type name 'ulong'; did you mean
'long'?
  127 | int env_set_hex(const char *varname, ulong value);
      |                                      ^~~~~
      |                                      long
include/env.h: In function 'env_set_addr':
include/env.h:138:31: error: 'ulong' undeclared (first use in this
function)
  138 |  return env_set_hex(varname, (ulong)addr);
      |                               ^~~~~
include/env.h:138:31: note: each undeclared identifier is reported only
once for each function it appears in
include/env.h:138:37: error: expected ')' before 'addr'
  138 |  return env_set_hex(varname, (ulong)addr);
      |                                     ^~~~
      |                                     )
make[1]: *** [scripts/Makefile.host:114: tools/env/env_flags.o] Error 1
make: *** [Makefile:1778: envtools] Error 2
Bisecting: 3 revisions left to test after this (roughly 2 steps)
...
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[cdbff9fc4002fdd47181088d5abe90e5f2fa1904] env: Move env_get_hex() to
...
9fb625ce05539fe6876a59ce1dcadb76b33c6f6e is the first bad commit
commit 9fb625ce05539fe6876a59ce1dcadb76b33c6f6e
Author: Simon Glass <[email protected]>
Date:   Thu Aug 1 09:46:51 2019 -0600

env: Move env_set() to env.h

Quoted 7 lines

Move env_set() over to the new header file.

Would be great to get this building again before 2019.10 release!

I sent the following series to fix this build issue:
- http://patchwork.ozlabs.org/project/uboot/list/?series=127297

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

Hope it will be merged soon.

Looks like we also need to change travis/gitlab to building "tools-all" not "tools-only". Can someone send a patch please? And Joe, are you happy with those env changes? Thanks!

Yes, I've acked those patches. I can pull them through the net tree if you like.

Ah, good. How do you want to handle stuff moving forward? I can take a PR when you're ready with stuff or I can just make sure it has you or Wolfgang ack/reviewed-by before grabbing myself. Thanks!

Quoted 3 lines

Let me know,
-Joe

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190924/4f0991f7/attachment.sig>
#7 lore raw
Quoted 133 lines · Tom Rini
Quoted 131 lines · Joe Hershberger

Hi Tom,

Quoted 127 lines · Tom Rini
Quoted 115 lines · Pierre-Jean Texier

Hi Vagrant,

Quoted 112 lines · Vagrant Cascadian

I've been unable to successfully run "make envtools" on recent versions of u-boot, and finally got a chance to git bisect it.

It looks like commit 9fb625ce05539fe6876a59ce1dcadb76b33c6f6e, introduced after 2019.10-rc1, breaks building envtools:

#!/bin/sh

# test-bisect
set -e
set -x
make clean
make tools-only_defconfig
make NO_SDL=1 envtools

....
Bisecting: 8 revisions left to test after this (roughly 3 steps) [9fb625ce05539fe6876a59ce1dcadb76b33c6f6e] env: Move env_set() to env.h running ../test-bisect
+ make clean
CLEAN u-boot.cfg
+ make tools-only_defconfig

  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/kconfig/conf.o
  YACC    scripts/kconfig/zconf.tab.c
  LEX     scripts/kconfig/zconf.lex.c
  HOSTCC  scripts/kconfig/zconf.tab.o
  HOSTLD  scripts/kconfig/conf
#
# configuration written to .config
#
+ make NO_SDL=1 envtools
scripts/kconfig/conf  --syncconfig Kconfig
  CHK     include/config.h
  CFG     u-boot.cfg
  GEN     include/autoconf.mk
  GEN     include/autoconf.mk.dep
  CHK     include/config/uboot.release
  UPD     include/config/uboot.release
  CHK     include/generated/version_autogenerated.h
  UPD     include/generated/version_autogenerated.h
  CHK     include/generated/timestamp_autogenerated.h
  UPD     include/generated/timestamp_autogenerated.h
  LD      tools/env/built-in.o
  HOSTCC  tools/env/crc32.o
  HOSTCC  tools/env/ctype.o
  HOSTCC  tools/env/env_attr.o
  HOSTCC  tools/env/env_flags.o
In file included from tools/env/../../env/flags.c:7,
                 from tools/env/env_flags.c:1:
include/env.h:97:1: error: unknown type name 'ulong'; did you mean
'long'?
   97 | ulong env_get_ulong(const char *name, int base, ulong
   default_val);
      | ^~~~~
      | long
include/env.h:97:49: error: unknown type name 'ulong'; did you mean
'long'?
   97 | ulong env_get_ulong(const char *name, int base, ulong
   default_val);
      |                                                 ^~~~~
      |                                                 long
include/env.h:106:40: error: unknown type name 'ulong'; did you mean
'long'?
  106 | int env_set_ulong(const char *varname, ulong value);
      |                                        ^~~~~
      |                                        long
include/env.h:118:1: error: unknown type name 'ulong'; did you mean
'long'?
  118 | ulong env_get_hex(const char *varname, ulong default_val);
      | ^~~~~
      | long
include/env.h:118:40: error: unknown type name 'ulong'; did you mean
'long'?
  118 | ulong env_get_hex(const char *varname, ulong default_val);
      |                                        ^~~~~
      |                                        long
include/env.h:127:38: error: unknown type name 'ulong'; did you mean
'long'?
  127 | int env_set_hex(const char *varname, ulong value);
      |                                      ^~~~~
      |                                      long
include/env.h: In function 'env_set_addr':
include/env.h:138:31: error: 'ulong' undeclared (first use in this
function)
  138 |  return env_set_hex(varname, (ulong)addr);
      |                               ^~~~~
include/env.h:138:31: note: each undeclared identifier is reported only
once for each function it appears in
include/env.h:138:37: error: expected ')' before 'addr'
  138 |  return env_set_hex(varname, (ulong)addr);
      |                                     ^~~~
      |                                     )
make[1]: *** [scripts/Makefile.host:114: tools/env/env_flags.o] Error 1
make: *** [Makefile:1778: envtools] Error 2
Bisecting: 3 revisions left to test after this (roughly 2 steps)
...
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[cdbff9fc4002fdd47181088d5abe90e5f2fa1904] env: Move env_get_hex() to
...
9fb625ce05539fe6876a59ce1dcadb76b33c6f6e is the first bad commit
commit 9fb625ce05539fe6876a59ce1dcadb76b33c6f6e
Author: Simon Glass <[email protected]>
Date:   Thu Aug 1 09:46:51 2019 -0600

env: Move env_set() to env.h

Move env_set() over to the new header file.

Quoted 6 lines
Quoted 1 line

Would be great to get this building again before 2019.10 release!

I sent the following series to fix this build issue:
- http://patchwork.ozlabs.org/project/uboot/list/?series=127297

Hope it will be merged soon.

Looks like we also need to change travis/gitlab to building "tools-all" not "tools-only". Can someone send a patch please? And Joe, are you happy with those env changes? Thanks!

Quoted 5 lines
Quoted 1 line

Yes, I've acked those patches. I can pull them through the net tree if you like.

Ah, good. How do you want to handle stuff moving forward? I can take a PR when you're ready with stuff or I can just make sure it has you or Wolfgang ack/reviewed-by before grabbing myself. Thanks!

I'm hoping the volume will be pretty low, so lets start with just looking for an Acked-by and go from there. We can later decide if we use an env/master branch in the net tree or add another tree if the volume makes the first approach unattractive.

Cheers,
-Joe

#8 lore raw
Quoted 136 lines · Joe Hershberger
Quoted 135 lines · Tom Rini
Quoted 132 lines · Joe Hershberger

Hi Tom,

Quoted 119 lines · Tom Rini
Quoted 117 lines · Pierre-Jean Texier

Hi Vagrant,

Quoted 113 lines · Vagrant Cascadian

I've been unable to successfully run "make envtools" on recent versions of u-boot, and finally got a chance to git bisect it.

It looks like commit 9fb625ce05539fe6876a59ce1dcadb76b33c6f6e, introduced after 2019.10-rc1, breaks building envtools:

#!/bin/sh

# test-bisect
set -e
set -x
make clean
make tools-only_defconfig
make NO_SDL=1 envtools

....
Bisecting: 8 revisions left to test after this (roughly 3 steps) [9fb625ce05539fe6876a59ce1dcadb76b33c6f6e] env: Move env_set() to env.h running ../test-bisect
+ make clean
CLEAN u-boot.cfg
+ make tools-only_defconfig

  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/kconfig/conf.o
  YACC    scripts/kconfig/zconf.tab.c
  LEX     scripts/kconfig/zconf.lex.c
  HOSTCC  scripts/kconfig/zconf.tab.o
  HOSTLD  scripts/kconfig/conf
#
# configuration written to .config
#
+ make NO_SDL=1 envtools
scripts/kconfig/conf  --syncconfig Kconfig
  CHK     include/config.h
  CFG     u-boot.cfg
  GEN     include/autoconf.mk
  GEN     include/autoconf.mk.dep
  CHK     include/config/uboot.release
  UPD     include/config/uboot.release
  CHK     include/generated/version_autogenerated.h
  UPD     include/generated/version_autogenerated.h
  CHK     include/generated/timestamp_autogenerated.h
  UPD     include/generated/timestamp_autogenerated.h
  LD      tools/env/built-in.o
  HOSTCC  tools/env/crc32.o
  HOSTCC  tools/env/ctype.o
  HOSTCC  tools/env/env_attr.o
  HOSTCC  tools/env/env_flags.o
In file included from tools/env/../../env/flags.c:7,
                 from tools/env/env_flags.c:1:
include/env.h:97:1: error: unknown type name 'ulong'; did you mean
'long'?
   97 | ulong env_get_ulong(const char *name, int base, ulong
   default_val);
      | ^~~~~
      | long
include/env.h:97:49: error: unknown type name 'ulong'; did you mean
'long'?
   97 | ulong env_get_ulong(const char *name, int base, ulong
   default_val);
      |                                                 ^~~~~
      |                                                 long
include/env.h:106:40: error: unknown type name 'ulong'; did you mean
'long'?
  106 | int env_set_ulong(const char *varname, ulong value);
      |                                        ^~~~~
      |                                        long
include/env.h:118:1: error: unknown type name 'ulong'; did you mean
'long'?
  118 | ulong env_get_hex(const char *varname, ulong default_val);
      | ^~~~~
      | long
include/env.h:118:40: error: unknown type name 'ulong'; did you mean
'long'?
  118 | ulong env_get_hex(const char *varname, ulong default_val);
      |                                        ^~~~~
      |                                        long
include/env.h:127:38: error: unknown type name 'ulong'; did you mean
'long'?
  127 | int env_set_hex(const char *varname, ulong value);
      |                                      ^~~~~
      |                                      long
include/env.h: In function 'env_set_addr':
include/env.h:138:31: error: 'ulong' undeclared (first use in this
function)
  138 |  return env_set_hex(varname, (ulong)addr);
      |                               ^~~~~
include/env.h:138:31: note: each undeclared identifier is reported only
once for each function it appears in
include/env.h:138:37: error: expected ')' before 'addr'
  138 |  return env_set_hex(varname, (ulong)addr);
      |                                     ^~~~
      |                                     )
make[1]: *** [scripts/Makefile.host:114: tools/env/env_flags.o] Error 1
make: *** [Makefile:1778: envtools] Error 2
Bisecting: 3 revisions left to test after this (roughly 2 steps)
...
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[cdbff9fc4002fdd47181088d5abe90e5f2fa1904] env: Move env_get_hex() to
...
9fb625ce05539fe6876a59ce1dcadb76b33c6f6e is the first bad commit
commit 9fb625ce05539fe6876a59ce1dcadb76b33c6f6e
Author: Simon Glass <[email protected]>
Date:   Thu Aug 1 09:46:51 2019 -0600

env: Move env_set() to env.h

Move env_set() over to the new header file.

Would be great to get this building again before 2019.10 release!

Quoted 8 lines
Quoted 4 lines

I sent the following series to fix this build issue:
- http://patchwork.ozlabs.org/project/uboot/list/?series=127297

Hope it will be merged soon.

Looks like we also need to change travis/gitlab to building "tools-all" not "tools-only". Can someone send a patch please? And Joe, are you happy with those env changes? Thanks!

Yes, I've acked those patches. I can pull them through the net tree if you like.

Quoted 8 lines
Quoted 3 lines

Ah, good. How do you want to handle stuff moving forward? I can take a PR when you're ready with stuff or I can just make sure it has you or Wolfgang ack/reviewed-by before grabbing myself. Thanks!

I'm hoping the volume will be pretty low, so lets start with just looking for an Acked-by and go from there. We can later decide if we use an env/master branch in the net tree or add another tree if the volume makes the first approach unattractive.

OK, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190924/7204019b/attachment.sig>