USB: gadget: pxa25x: Add DT probing
PATCH 2/2 USB: gadget: pxa25x: Add DT probing
Quoted 8 lines · Linus Walleij
This makes it possible to instantiate the PXA25x UDC driver from the device tree.
Cc Robert Jarzmik <[email protected]>Signed-off-by Linus Walleij <[email protected]>--- drivers/usb/gadget/udc/pxa25x_udc.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
Mmmh it's a good start, but I don't think it's complete. The kind of errors that bother me are lines such as :
Quoted 3 lines
static int
pxa25x_udc_probe(struct platform_device *pdev)
...if (gpio_is_valid(dev->mach->gpio_pullup)) {
I think this will be a NULL deref and kernel crash ...
From memory this driver relies on an always filled mach platform_data structure, so the port to devicetree should be a bit more painful.
This makes me think that either :
- you have not run tested the patch
- or I'm late in the last patches and I'm missing some information
Cheers.
---
Robert